Berlin
Account created on 15 June 2009, over 16 years ago
#

Merge Requests

More

Recent comments

πŸ‡©πŸ‡ͺGermany yannickoo Berlin
πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ created an issue.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin
πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ created an issue.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hello again πŸ‘‹ I wanted to share the minimal plugin implementation based on Embedded Content β†’ module ➑️ ✨ Embedded Content plugin Active .

Even if we don't want to introduce new dependencies I think that can be helpful for people so they could already place components in CKEditor.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin
πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ created an issue.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I had to create a follow-up issue since we are not allowing dots to be used in the library name which is needed when you want to load a SDC library ➑️ πŸ“Œ Fix RegEx for Icon library schema definition Active

πŸ‡©πŸ‡ͺGermany yannickoo Berlin
πŸ‡©πŸ‡ͺGermany yannickoo Berlin
πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ created an issue.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin
πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ created an issue.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ made their first commit to this issue’s fork.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin
πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ created an issue.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ created an issue.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

The Frontend Editing module is making use of hook_entity_view_alter which is not a preprocess but some other sort of altering the data. Do you think support for that can be possible?

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

@mogtofu33 already made it clear that any module which is using pseudo-fields won't show up. E.g the Frontend Editing β†’ is also using a pseudo-field to provide the markup for the markup that is needed.

If we wouldn't support those we would need to allow something that can be added and which is context-sensitive.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ created an issue.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Oh wow, so nice to see that this was committed <3 Thank you very much πŸ’ͺ

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Thank you for the presentation, really impressive what happened in the meantime πŸ’ͺ

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

For anonymous users we will other placement options like "Sticky" or "Inline" later.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

It seems like the spellchecker is not able to run, so how should we deal with that? https://git.drupalcode.org/issue/drupal-2895477/-/jobs/6300642

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I have adjusted the condition for the validation so that from now on only elements with type="submit" attribute are used for validation.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ made their first commit to this issue’s fork.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Thank you very much πŸ’ͺ

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hello πŸ‘‹ I am coming from #2807857: Exposed filters do not appear on attachment display β†’ and can confirm that the patch #40 has fixed the issue, thanks for that πŸ’ͺ

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Since the other issue πŸ› Attachments on Views Content Panes don't always inherit exposed filters Postponed: needs info is taking care of the same problem and a working patch is there I am closing this issue

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I have experienced the same issue and can confirm that that the patch linked above πŸ› Attachments on Views Content Panes don't always inherit exposed filters Postponed: needs info fixed the problem πŸ’ͺ

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

This looks good from my side! Let's get this forward with another review so setting to RTBC 😎

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Thank you ksenzee, really nice change! I have requested a small thing to change the way we are accessing the configuration, otherwise approved from my side πŸ˜‡

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Thank you for the quick feedback! I will forward this this to the kitchen πŸ§‘β€πŸ³

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Fresh out of the oven four new candidates for the logo πŸ”₯

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Here you can find a screenshot of the changes with explanations:

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

It is important for me to add classes for styling purposes directly on the link, therefore the flexible function is very useful πŸŽ‰

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

In order to provide a quick overview about all the current candidates I have prepared this here to make it easier:

I think it is important to have a proper logo for the Experience Builder that is not just a πŸ’§ but something on its own. When you check the Modules β†’ overview page on drupal.org you will see that many projects are just having a drop with something inside. The Experience Builder should have something unique because it will be visible in presentations where we cannot just two drops next to each other, that would look too similar.

Here are few logos of other projects that are using the drop approach which we should not necessarily follow:

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I forgot to post my feedback for the stacked layers: I think that can confuse people since this is exactly the same icon we use in the Navigation for the Structure link.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I have created a MR that is allowing setting the key to access the Paragraph behavior setting manually. I think it's not needed to let the user choose from the default values since they are not being used to set the value as mentioned in the issue description.

Furthermore I have renamed the paragraphs_behaviors plugin to paragraph_behavior which is the better term in this case since we are only fetching a value from one Paragraph behavior.

Let me know what you think πŸ˜‡

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

In my case it was not applied due to Gin theme. I have added 2 more selectors which are covering the Gin vertical toolbar and the "fake navigation" bar that the theme provides as well.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Wouldn't it be nice to just have the local version which could be automatically installed via composer.libraries.json file?

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

After a while I was able to figure out the root cause for this: Ensure that your normalize / reset CSS code is not having generic selectors like [type="checkbox"] but input[type="checkbox"] instead to avoid overriding the CSS style of the contextual menu items πŸ’‘

Closing this one but might be helpful for future ✨

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I have created a new follow-up issue to handle this after the refactoring: πŸ› Z-index is still too low to cover Navigation bar Active

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I can confirm that the fix is not there anymore, I think this has been changed in this here πŸ› Z index problems Active

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Here are some more examples:

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey together πŸ‘‹ I have also noticed that the Twig function did not work as expected.

My goal was to create an obfuscated email link for info@example.com with an extra class attribute for styling. Unfortunately the MR that has been created could not help me since there is no support for attributes even if the module itself could handle that :(

After checking the code I figured out that we got a small mess here regarding the order of the arguments: Sometimes it was $email, $params, $text and somewhere else $email, $text, $params.

The MR I have created fixes

  • The broken Twig function
  • Wrong order for arguments
  • Attribute support for Twig function

Example usages

Minimal example

{{ obfuscate('info@example.com') }}

➑️ <a href="mailto:info@example.com">info@example.com</a>

With link text

{{ obfuscate('info@example.com', 'Link text') }}

➑️ <a href="mailto:info@example.com">Link text</a>

With link attributes

{{ obfuscate('info@example.com', 'Link text', {
  class: 'font-bold'
}) }}

➑️ <a href="mailto:info@example.com" class="font-bold">Link text</a>

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ made their first commit to this issue’s fork.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I have just asked ChatGPT and it's saying the following:

πŸ” Interpretation of the Logo

Puzzle Piece Shape 🧩
This suggests modularity, plug-and-play architecture, and customizability β€” all key traits of Experience Builder and Drupal functionality.

Pencil Icon ✏️
Indicates editing, customization, or content creation β€” a natural fit for a WYSIWYG (what you see is what you get) or low-code editor.

Color Scheme πŸ”΅
The blue and white color is reminiscent of Drupal’s own branding, which strengthens the association.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I am really happy to share the work of my colleague Ángela β†’ πŸŽ‰

The logo is showing a puzzle piece which stands for components that can be placed into the Experience Builder. The pencil inside of it indicates editing functionality which is a great combination! It is following the new CI of Drupal and looks very clean so it can be used for promotion of Experience Builder.

SVG and 512Γ—512 PNG files have been attached βœ…

What do you think about it?

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

So we have a new MR now that is against 11.x branch. Tests are still missing.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ changed the visibility of the branch 11.x to hidden.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I am happy that I found this and never needed to use that in my time working with Drupal - until now :D Even when having the patch applied I cannot see a differen action attribute in the exposed filters forms.

Do you think we should also try to read that configured Custom URL first before taking the <current> URL like this?

$form_action = $view->display_handler->getPath() ?: Url::fromRoute('<current>')->toString();
πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey πŸ‘‹ I just wanted to let you know that the design department of 1xINTERNET is currently working on a logo for this, I will provide it here once it is available.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I can confirm that we need to investigate here because of the size calculation with the new navigation :/

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I have no clue how I encountered this but the merge request was a quick fix for that, thanks πŸŽ‰

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I agree that removing the type="checkbox" needs to be there but I am still wondering what could be the reason that the contextual menu doesn't render properly in a custom theme.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

In case that people are still interested in seeing how to solve this nowadays: You can use the combination of Menu Item Extras β†’ and UI Icons to get this working πŸ’ͺ

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hello @weseze, can you provide me an example of the values you are using for the attributes so I can have another look on that? Let's try to get another fix that also works in your case out asap!

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey @just_like_good_vibes! I would recommend to use the Embedded Content β†’ module and provide a way to provide plugin derivatives for all SDCs.

Here you can find an example implementation of an Embedded Content plugin

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

Production build 0.71.5 2024