🇩🇪Germany @yannickoo

FYI I just created another issue to adjust Local tasks to allow editors faster editing of content – 📌 Improve UX for Local Tasks in Toolbar Active

yannickoo → created an issue.

This has been released with the latest version of YAML Editor 🤗

Hey jradhak! Thanks for your support, really appreciated 🤗 I have just realized a new version that is compatible with Drupal 11 🚀

heroicnick → credited yannickoo → .

@kmonty before dir attribute was used to determine whether to put margin-left or margin-right here. Now the patch is using margin-inline-start which makes it already dynamic since this will be applied to the left or right based on the language direction of the user.

Therefore I'm not expecting regressions here.

This is awesome news, really modern design!

1. I would love if we can make sure that for the graphics SVG files are being used insteaf of pixelated PNG fileslike this.

2. Images should be available in at least 2x their size so they look sharp on all devices. Right now this here is a file that is being used and should be provided by designer in a higher resolution

3. Is an underline really needed inside the mega menu? When hovering items inside the mega menu both the title and the description get an underline. Isn't it better to have the underline just on the title? Otherwise it looks odd and I'm not sure if that is helping a11y more.

4. The "Platform" menu item has regular underline when hovering + bottom border, I think that regular underline shouldn't be there.

5. Buttons should have a :focus-visible instead of :focus so people using the cursor doesn't see that extra blue ring

FYI after applying the patch it was needed to run composer update jquery/icheck so that the new URL of the libraries is changed in composer.lock file as well ✨

I was just experiencing the same issue and could handle this by stopping any further modifications of the view if there are no results.

Hey 👋 It took a while to debug this and to land here. It seems like removing the leading / is doing the trick. Couldn't create a new MR for this so adding a patch.

Thanks!

dan2k3k4 → credited yannickoo → .

Thanks for the quick response! Yeah it seems all the other CKEditor plugins were unavailable for loading so the whole thing crashed :/

yannickoo → created an issue.

Change in issue fork can be found here.

yannickoo → created an issue.

I have added another commit to that MR to prevent an error when having entity types without multiple bundles (e.g. user or custom entities).

Warning: Undefined array key "bundle_boosts" in Drupal\elasticsearch_connector\Plugin\search_api\processor\ElasticsearchTypeBoost->preprocessSearchQuery() (line 34 of modules/contrib/elasticsearch_connector/src/Plugin/search_api/processor/ElasticsearchTypeBoost.php).

yannickoo → made their first commit to this issue’s fork.

yannickoo → created an issue.

I just experienced this one here with 7.x version when trying to use BEF for a vocabulary

yannickoo → changed the visibility of the branch 1.x to hidden.

yannickoo → created an issue.

yannickoo → created an issue.

yannickoo → created an issue.

Thanks for your efforts here! I have re-rolled the patch so it works with the latest 2.0.1.

Hey there 👋 I'm sorry but I missed Grevil's message on my radar, thank you very much for helping here! I will be more active during the next weeks so happy to focus on this module again since we have a lot of usage here!

yannickoo → created an issue.

FYI it's also possible to open a specific commit in GitLab and then just append .patch which might be safer when downloading patches from remote.

@shweta__sharma please create a new issues for that, this this issue for something else.

I have created a merge request which uses 202 status code aka "Accepted":

The request has been accepted for processing, but the processing has not been completed. The request might or might not be eventually acted upon, and may be disallowed when processing occurs.

yannickoo → created an issue.

In case you need to apply the patch for a 10.1.x Drupal you can find the patch attached 😇

Really nice to see that this has been fixed, thank you so much to everyone who was working on this 💪

I did some minor tweaks like

• Using × instead of × unicode directly in Twig template
• Change upsale config select list label from If image is too small: to Upscaling behavior
• Fix indentation

I'm going to make some adjustments for the PHP code but really nice changes so far!

Hey @paulrad, I had to do a quick research to see if empty alt attributes are valid & meaningful but it seems like this is totally fine for decorative images. Patch looks and works as expected, thanks!

Hey 👋 I've just tried to reproduce this issue but I cannot see any weird alignments here. Nothing visually bad with the close icon of the modal nor the "Apply filters" button.

The only wrong thing I can see here are the vertical tabs that you can see when having multiple media bundles enabled for referencing.

I have fixed a notice that showed up so this is working now as expected.

yannickoo → made their first commit to this issue’s fork.

Rerolled patch

yannickoo → created an issue.

yannickoo → created an issue.

Oh Jimmy thank you so much for pointing me to that issue!

yannickoo → made their first commit to this issue’s fork.

yannickoo → created an issue.

Hey herved, I think you forgot two important things here:

You need to change your Facet's widget type to Views exposed filters so it doesn't break.

The next step to adjust your facet source configuration as well so it can read the new URL parameters:

What I have noticed is that there are just simple select lists and no checkboxes anymore :/

I was just experiencing the same as #196 but it seems like you need to change your Facet's widget type to Views exposed filters so it doesn't break.

The next step to adjust your facet source configuration as well so it can read the new URL parameters:

What I have noticed is that there are just simple select lists and no more checkboxes :/

I was just experiencing the same as #196 but fortunately found the fix for that 🎉

It seems like you need to change your Facet's widget type to Views exposed filters so it can work properly.

yannickoo → created an issue.

yannickoo → created an issue.

In case that people want to use a pencil icon here I have a patch attached for that 😇

Hey! Thank you for showing interest in helping with this module. I will make sure that all the existing issues on GitHub will be transferred to drupal.org and then we can start improving this 💪

I created this module in the past to provide a simple solution but yeah it's time to revisit this again and start with some refactoring and put energy into this here again ⚡️

Hey together! I'm going to add D10 support during the weekend, thanks for pushing this 💪

Patch works fine, the only thing I'm wondering about is the `data-src` attribute of the `

yannickoo → created an issue.

yannickoo → created an issue.

yannickoo → created an issue.

yannickoo → created an issue.

yannickoo → created an issue.

A new release 8.x-1.2 was published 😇

yannickoo → created an issue.

This has been fixed in the latest dev version.

yannickoo → created an issue.

Hey 👋 Sorry for the delay with this one! There were some hickups when syncing the code from GitHub to drupal.org. I am going to move the module away from GitHub and back to drupal.org since we have much better features now which didn't exist back in the days.

Thank you for reaching out to support this project, really appreciated, closing this one 💪

I was able to solve this problem by moving my wrapping <div> elements from views-view--unformatted--VIEW.html.twig into views-view--VIEW.html.twig, now Views Infinite Scroll is appending new content into the existing <div> instead of creating another one.

Thanks for the patch! Applies & works as expected 👌

Patch works as expected 💪

yannickoo → created an issue.