yannickoo β changed the visibility of the branch 1.x to hidden.
yannickoo β created an issue.
yannickoo β created an issue.
yannickoo β created an issue.
Thanks for your efforts here! I have re-rolled the patch so it works with the latest 2.0.1
.
Hey there π I'm sorry but I missed Grevil's message on my radar, thank you very much for helping here! I will be more active during the next weeks so happy to focus on this module again since we have a lot of usage here!
yannickoo β created an issue.
FYI it's also possible to open a specific commit in GitLab and then just append .patch
which might be safer when downloading patches from remote.
@shweta__sharma please create a new issues for that, this this issue for something else.
I have created a merge request which uses 202
status code aka "Accepted":
The request has been accepted for processing, but the processing has not been completed. The request might or might not be eventually acted upon, and may be disallowed when processing occurs.
yannickoo β created an issue.
In case you need to apply the patch for a 10.1.x
Drupal you can find the patch attached π
Really nice to see that this has been fixed, thank you so much to everyone who was working on this πͺ
I did some minor tweaks like
- Using
×
instead ofΓ
unicode directly in Twig template - Change upsale config select list label from
If image is too small:
toUpscaling behavior
- Fix indentation
I'm going to make some adjustments for the PHP code but really nice changes so far!
Hey @paulrad, I had to do a quick research to see if empty alt
attributes are valid & meaningful but it seems like this is totally fine for decorative images. Patch looks and works as expected, thanks!
Hey π I've just tried to reproduce this issue but I cannot see any weird alignments here. Nothing visually bad with the close icon of the modal nor the "Apply filters" button.
The only wrong thing I can see here are the vertical tabs that you can see when having multiple media bundles enabled for referencing.
I have fixed a notice that showed up so this is working now as expected.
yannickoo β made their first commit to this issueβs fork.
Rerolled patch
yannickoo β created an issue.
yannickoo β created an issue.
Oh Jimmy thank you so much for pointing me to that issue!
yannickoo β made their first commit to this issueβs fork.
yannickoo β created an issue.
Hey herved, I think you forgot two important things here:
You need to change your Facet's widget type to Views exposed filters so it doesn't break.
The next step to adjust your facet source configuration as well so it can read the new URL parameters:
What I have noticed is that there are just simple select lists and no checkboxes anymore :/
I was just experiencing the same as #196 but it seems like you need to change your Facet's widget type to Views exposed filters so it doesn't break.
The next step to adjust your facet source configuration as well so it can read the new URL parameters:
What I have noticed is that there are just simple select lists and no more checkboxes :/
I was just experiencing the same as #196 but fortunately found the fix for that π
It seems like you need to change your Facet's widget type to Views exposed filters so it can work properly.
yannickoo β created an issue.
yannickoo β created an issue.
In case that people want to use a pencil icon here I have a patch attached for that π
Hey! Thank you for showing interest in helping with this module. I will make sure that all the existing issues on GitHub will be transferred to drupal.org and then we can start improving this πͺ
I created this module in the past to provide a simple solution but yeah it's time to revisit this again and start with some refactoring and put energy into this here again β‘οΈ
Hey together! I'm going to add D10 support during the weekend, thanks for pushing this πͺ
Patch works fine, the only thing I'm wondering about is the `data-src` attribute of the `
` inside the `` tag since there is no chance to execute that at all. Shouldn't we rather remove it completely?yannickoo β created an issue.
yannickoo β created an issue.
yannickoo β created an issue.
yannickoo β created an issue.
yannickoo β created an issue.
A new release 8.x-1.2
was published π
yannickoo β created an issue.
This has been fixed in the latest dev version.
yannickoo β created an issue.
Hey π Sorry for the delay with this one! There were some hickups when syncing the code from GitHub to drupal.org. I am going to move the module away from GitHub and back to drupal.org since we have much better features now which didn't exist back in the days.
Thank you for reaching out to support this project, really appreciated, closing this one πͺ
I was able to solve this problem by moving my wrapping <div>
elements from views-view--unformatted--VIEW.html.twig
into views-view--VIEW.html.twig
, now Views Infinite Scroll is appending new content into the existing <div>
instead of creating another one.
Thanks for the patch! Applies & works as expected π
Patch works as expected πͺ
yannickoo β created an issue.
I was just searching for this functionality and found this old issue here π
You can find a new patch attached which is compatible with the latest version of Views Infinite Scroll.
There is this pull request which can be used instead of this patch here, so closing again.
When trying to disable the previewer (because you might want to check how the content could look like on Drupal) you just get get
Uncaught PHP Exception Error: "Call to a member function getSitesForEntity() on null" at web/modules/contrib/next/src/Render/MainContent/HtmlRenderer.php line 115
A simple check to check if the site resolver exists can fix the problem, see patch attached.
Ignore the patches above, here we go π
Ignore the two patches above, here we go π
I am still experiencing this when using the autocomplete form element in a custom form. I saw the patch in #13 π Autocomplete/autosuggestions are not language-context sensitive Fixed so I was re-rolling this so it works with the latest version.
yannickoo β created an issue.
Let's close this in favor of β¨ Use search and search_api_autocomplete form elements for search form and implement auto-submit Fixed .
I just realized that search_api_autocomplete
provides it's own form element that we could use here and that would allow us to support auto-submit.
In order to get a search insteaf of a text field you would need to apply the patch from β¨ Use search form element instead of text Needs review .
FYI I was just creating a new merge request for
β¨
Use search form element instead of text
Needs review
for using input[type="search"]
instead of input[type="text"]
. The cool thing about that is that a clear button comes OOTB and could be hidden via CSS if people don't want that.
yannickoo β created an issue.
I have created a merge request for this. Please have a look π
yannickoo β created an issue.
I have created a MR to change the input type, please have a look π