Berlin
Account created on 15 June 2009, about 16 years ago
#

Merge Requests

More

Recent comments

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

It is important for me to add classes for styling purposes directly on the link, therefore the flexible function is very useful πŸŽ‰

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

In order to provide a quick overview about all the current candidates I have prepared this here to make it easier:

I think it is important to have a proper logo for the Experience Builder that is not just a πŸ’§ but something on its own. When you check the Modules β†’ overview page on drupal.org you will see that many projects are just having a drop with something inside. The Experience Builder should have something unique because it will be visible in presentations where we cannot just two drops next to each other, that would look too similar.

Here are few logos of other projects that are using the drop approach which we should not necessarily follow:

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I forgot to post my feedback for the stacked layers: I think that can confuse people since this is exactly the same icon we use in the Navigation for the Structure link.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I have created a MR that is allowing setting the key to access the Paragraph behavior setting manually. I think it's not needed to let the user choose from the default values since they are not being used to set the value as mentioned in the issue description.

Furthermore I have renamed the paragraphs_behaviors plugin to paragraph_behavior which is the better term in this case since we are only fetching a value from one Paragraph behavior.

Let me know what you think πŸ˜‡

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

In my case it was not applied due to Gin theme. I have added 2 more selectors which are covering the Gin vertical toolbar and the "fake navigation" bar that the theme provides as well.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Wouldn't it be nice to just have the local version which could be automatically installed via composer.libraries.json file?

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

After a while I was able to figure out the root cause for this: Ensure that your normalize / reset CSS code is not having generic selectors like [type="checkbox"] but input[type="checkbox"] instead to avoid overriding the CSS style of the contextual menu items πŸ’‘

Closing this one but might be helpful for future ✨

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I have created a new follow-up issue to handle this after the refactoring: πŸ› Z-index is still too low to cover Navigation bar Active

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I can confirm that the fix is not there anymore, I think this has been changed in this here πŸ› Z index problems Active

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Here are some more examples:

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey together πŸ‘‹ I have also noticed that the Twig function did not work as expected.

My goal was to create an obfuscated email link for info@example.com with an extra class attribute for styling. Unfortunately the MR that has been created could not help me since there is no support for attributes even if the module itself could handle that :(

After checking the code I figured out that we got a small mess here regarding the order of the arguments: Sometimes it was $email, $params, $text and somewhere else $email, $text, $params.

The MR I have created fixes

  • The broken Twig function
  • Wrong order for arguments
  • Attribute support for Twig function

Example usages

Minimal example

{{ obfuscate('info@example.com') }}

➑️ <a href="mailto:info@example.com">info@example.com</a>

With link text

{{ obfuscate('info@example.com', 'Link text') }}

➑️ <a href="mailto:info@example.com">Link text</a>

With link attributes

{{ obfuscate('info@example.com', 'Link text', {
  class: 'font-bold'
}) }}

➑️ <a href="mailto:info@example.com" class="font-bold">Link text</a>

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ made their first commit to this issue’s fork.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I have just asked ChatGPT and it's saying the following:

πŸ” Interpretation of the Logo

Puzzle Piece Shape 🧩
This suggests modularity, plug-and-play architecture, and customizability β€” all key traits of Experience Builder and Drupal functionality.

Pencil Icon ✏️
Indicates editing, customization, or content creation β€” a natural fit for a WYSIWYG (what you see is what you get) or low-code editor.

Color Scheme πŸ”΅
The blue and white color is reminiscent of Drupal’s own branding, which strengthens the association.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I am really happy to share the work of my colleague Ángela β†’ πŸŽ‰

The logo is showing a puzzle piece which stands for components that can be placed into the Experience Builder. The pencil inside of it indicates editing functionality which is a great combination! It is following the new CI of Drupal and looks very clean so it can be used for promotion of Experience Builder.

SVG and 512Γ—512 PNG files have been attached βœ…

What do you think about it?

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

So we have a new MR now that is against 11.x branch. Tests are still missing.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ changed the visibility of the branch 11.x to hidden.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I am happy that I found this and never needed to use that in my time working with Drupal - until now :D Even when having the patch applied I cannot see a differen action attribute in the exposed filters forms.

Do you think we should also try to read that configured Custom URL first before taking the <current> URL like this?

$form_action = $view->display_handler->getPath() ?: Url::fromRoute('<current>')->toString();
πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey πŸ‘‹ I just wanted to let you know that the design department of 1xINTERNET is currently working on a logo for this, I will provide it here once it is available.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I can confirm that we need to investigate here because of the size calculation with the new navigation :/

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I have no clue how I encountered this but the merge request was a quick fix for that, thanks πŸŽ‰

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

I agree that removing the type="checkbox" needs to be there but I am still wondering what could be the reason that the contextual menu doesn't render properly in a custom theme.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

In case that people are still interested in seeing how to solve this nowadays: You can use the combination of Menu Item Extras β†’ and UI Icons to get this working πŸ’ͺ

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hello @weseze, can you provide me an example of the values you are using for the attributes so I can have another look on that? Let's try to get another fix that also works in your case out asap!

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey @just_like_good_vibes! I would recommend to use the Embedded Content β†’ module and provide a way to provide plugin derivatives for all SDCs.

Here you can find an example implementation of an Embedded Content plugin

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey bessonweb, unfortunately this is not supported by the module since it only acts on the field value.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

πŸ“£ Drupal 7 has officially reached it's EOL in January 2025, we are closing this issue accordingly

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey peter.thorndycraft, thank you for creating this issue. In order to replicate your described problem I would need to get some steps to reproduce since I didn't have any problems with HTML chars.

Thanks!

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey aaron.ferris, thanks for your MR! This has been handled over in πŸ› Config form arguments error Active but you got credited as well πŸ’ͺ

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Thanks to everyone who contributed here! The MR has been merged and will be released with the next version of Linked Field!

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey Daniel, thank you very much for this contribution! Really nice to see that the Link Attributes & Linked Field modules work smoothly together 🀝 I had to adjust the MR a bit so that class and rel are merged correctly and support for delta has been added as well.

Merging this and will be shipped with the next release 🚒

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

yannickoo β†’ made their first commit to this issue’s fork.

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Thanks to everyone for fixing this important issue! The merge request !20 has been merged and will be released with the next version πŸ’ͺ

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Thank you very much Damien! The MR has been merged and will be released with the next version πŸŽ‰

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

@dalin the cool thing about the new Icon API is that any extension can provide an icon pack so it might be totally enough to have a custom module with an images folder that contains screenshot of your different paragraph types.

You can easily let Drupal scan your folder for any *.png files and tell Drupal how to render your "icons" e.g.

paragraph_icons:
  extractor: path
  config:
    # One icon per listed source, allowed extensions: svg, png, gif, relative to
    # this file or to drupal root if start with a `/`. Remote icons are allowed too
    # Format can be mixed but only one template is possible. If same id (name here)
    # later will override.
    # If an icon does not exist, it will be ignored and a log message will be created.
    sources:
      - images/gallery.png
      - images/another-image.png
      - images/text-paragraph.gif
      - https://www.drupal.org/files/drupal-wordmark.png
  template: '<img src="{{ source }}" width="270" height="160" alt="{{ icon_id }}">'

That would register and provide four different screenshots that could be referenced like paragraph_icons:gallery, paragraph_icons:another-image, paragraph_icons:text-paragraph, paragraph_icons:drupal-wordmark.

No matter if we have nicely prepared SVG files or just screenshots, the new Icon API would allow us to expose them easily and use them by just their ID πŸ”₯

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey! I just want to mention that I have suggested using the new Icon API β†’ for managing paragraph icons over in 2854585#24 ✨ Improve icon selection in paragraphs type form. Needs review , that could bring this here to another level πŸš€

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hello together πŸ‘‹ What do you think about changing the direction here completely and make use of Drupal's new API for icon management β†’ ?

That would allow themes or modules to define icon packs that can be easily referenced in the Paragraph type configuration like my_icon_pack_name:gallery and can be rendered via PHP or Twig:

PHP:

$build['icon'] = [
   '#type' => 'icon',
   '#pack_id' => 'my_icon_pack_name',
   '#icon_id' => 'gallery',
   '#settings' => [
     'size' => 64,
   ],
 ];

Twig:

{{ icon('my_icon_pack_name', 'gallery', {size: 64}) }}

There is a really cool widget that is available when installing the UI Icons β†’ module that allows you to choose icons via autocomplete:

When storing simple IDs of icons we don't need to care about storing paragraph icons anymore and they can easily survive deployments 😏

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey I just checked the implementation in the MR and I am not sure if we want to rely on the breakpoints that are defined in the YAML file. What would you think about using a JS condition for this, e.g.

if ('ontouchstart' in window)

πŸ‡©πŸ‡ͺGermany yannickoo Berlin

Hey! First of all thanks for the contribution!

I'm currently reviewing the MR and I think this modules should provide attribute for the menu links (which covers the <li> and the <a> elements. I don't see big reasons to allow site managers to add attributes to the <ul> element itself and those could be rather added via a dedicated menu.html.twig file.

What do you think?

Production build 0.71.5 2024