🇩🇪Germany @yannickoo

Hey I just checked the implementation in the MR and I am not sure if we want to rely on the breakpoints that are defined in the YAML file. What would you think about using a JS condition for this, e.g.

if ('ontouchstart' in window)

Hey! First of all thanks for the contribution!

I'm currently reviewing the MR and I think this modules should provide attribute for the menu links (which covers the <li> and the <a> elements. I don't see big reasons to allow site managers to add attributes to the <ul> element itself and those could be rather added via a dedicated menu.html.twig file.

What do you think?

yannickoo → created an issue.

yannickoo → created an issue.

yannickoo → created an issue.

It seems like shadowrootmode="open" attribute is influencing the behavior of a cloned <responsive-img> element. After removing that attribute everything works as expected 💅

yannickoo → made their first commit to this issue’s fork.

joachim namyslo → credited yannickoo → .

Oh wow I didn't know that the toolbar looks so crazy without Gin theme 🤯

The big problem is that the regular toolbar does not open on hover, only when clicking. Having a simple Edit link could work but then we lose all the ability to choose one of the other local tasks.

Gin solves it in a really nice way: On wider viewports you expand the tray when hovering and on narrow screens you get the "click to open" behavior which simply shows all the other local tasks.

➡️ I have attached a patch → so you can quickly test that without polluting the MR

Regular toolbar with "Edit" link that has icon

Regular toolbar with hidden "Edit" link when on entity edit form

Gin toolbar (wide) with separated "Edit" link

Gin toolbar (narrow) with try that opens on click

I would love if we could somehow get the UX that Gin provides otherwise I find that standalone "Edit" button a bit tricky from UX perspective :/

joachim namyslo → credited yannickoo → .

Thanks for your effort @dydave! I had to think about this for a longer while and also asked other people what they could easily understand to navigate around easily.

New suggestions that I really like and never saw in Drupal before:

• Page Tools
• Page Actions
• Quick Actions
• Actions

@dydave I think we can keep the other one open since we still need to figure out which labels could be a good replacement for Local Tasks 😇

Hey @dydave, I just took the time to quickly implement this request. The idea is to show an Edit button instead of Local Tasks if there is an entity edit form URL available. Like that editors could simply click that button to edit an entity which is a node in many cases.

A while ago it was possible to show the local tasks inside the vertical Gin toolbar ✨ Add option for node local tasks in toolbar Closed: won't fix . That issue was closed due to the functionality that Admin Toolbar Tools module provides. In order to make editor's life as easy as possible this is what I suggest:

Entity pages

In case that the local task links contain a route that has the pattern entity.TYPE.edit_form we use that URL for the button itself and also rewrite the label from Local Tasks to Edit so editing an entity is just one click away.

All other pages

If there is no entity edit form URL available we just take the current behavior which is showing Local Tasks.

yannickoo → created an issue.

yannickoo → created an issue.

leymannx → credited yannickoo → .

joachim namyslo → credited yannickoo → .

joachim namyslo → credited yannickoo → .

heroicnick → credited yannickoo → .

Fixed typo

FYI I just created another issue to adjust Local tasks to allow editors faster editing of content – 📌 Improve UX for Local Tasks in Toolbar Active

yannickoo → created an issue.

This has been released with the latest version of YAML Editor 🤗

Hey jradhak! Thanks for your support, really appreciated 🤗 I have just realized a new version that is compatible with Drupal 11 🚀

heroicnick → credited yannickoo → .

@kmonty before dir attribute was used to determine whether to put margin-left or margin-right here. Now the patch is using margin-inline-start which makes it already dynamic since this will be applied to the left or right based on the language direction of the user.

Therefore I'm not expecting regressions here.

This is awesome news, really modern design!

1. I would love if we can make sure that for the graphics SVG files are being used insteaf of pixelated PNG fileslike this.

2. Images should be available in at least 2x their size so they look sharp on all devices. Right now this here is a file that is being used and should be provided by designer in a higher resolution

3. Is an underline really needed inside the mega menu? When hovering items inside the mega menu both the title and the description get an underline. Isn't it better to have the underline just on the title? Otherwise it looks odd and I'm not sure if that is helping a11y more.

4. The "Platform" menu item has regular underline when hovering + bottom border, I think that regular underline shouldn't be there.

5. Buttons should have a :focus-visible instead of :focus so people using the cursor doesn't see that extra blue ring

FYI after applying the patch it was needed to run composer update jquery/icheck so that the new URL of the libraries is changed in composer.lock file as well ✨

I was just experiencing the same issue and could handle this by stopping any further modifications of the view if there are no results.

Hey 👋 It took a while to debug this and to land here. It seems like removing the leading / is doing the trick. Couldn't create a new MR for this so adding a patch.

Thanks!

dan2k3k4 → credited yannickoo → .

Thanks for the quick response! Yeah it seems all the other CKEditor plugins were unavailable for loading so the whole thing crashed :/

yannickoo → created an issue.

Change in issue fork can be found here.

yannickoo → created an issue.

I have added another commit to that MR to prevent an error when having entity types without multiple bundles (e.g. user or custom entities).

Warning: Undefined array key "bundle_boosts" in Drupal\elasticsearch_connector\Plugin\search_api\processor\ElasticsearchTypeBoost->preprocessSearchQuery() (line 34 of modules/contrib/elasticsearch_connector/src/Plugin/search_api/processor/ElasticsearchTypeBoost.php).

yannickoo → made their first commit to this issue’s fork.

yannickoo → created an issue.

I just experienced this one here with 7.x version when trying to use BEF for a vocabulary

yannickoo → changed the visibility of the branch 1.x to hidden.

yannickoo → created an issue.

yannickoo → created an issue.

yannickoo → created an issue.

Thanks for your efforts here! I have re-rolled the patch so it works with the latest 2.0.1.

Hey there 👋 I'm sorry but I missed Grevil's message on my radar, thank you very much for helping here! I will be more active during the next weeks so happy to focus on this module again since we have a lot of usage here!

yannickoo → created an issue.

FYI it's also possible to open a specific commit in GitLab and then just append .patch which might be safer when downloading patches from remote.

@shweta__sharma please create a new issues for that, this this issue for something else.

I have created a merge request which uses 202 status code aka "Accepted":

The request has been accepted for processing, but the processing has not been completed. The request might or might not be eventually acted upon, and may be disallowed when processing occurs.

yannickoo → created an issue.

In case you need to apply the patch for a 10.1.x Drupal you can find the patch attached 😇

Really nice to see that this has been fixed, thank you so much to everyone who was working on this 💪

I did some minor tweaks like

• Using × instead of × unicode directly in Twig template
• Change upsale config select list label from If image is too small: to Upscaling behavior
• Fix indentation

I'm going to make some adjustments for the PHP code but really nice changes so far!

Hey @paulrad, I had to do a quick research to see if empty alt attributes are valid & meaningful but it seems like this is totally fine for decorative images. Patch looks and works as expected, thanks!

Hey 👋 I've just tried to reproduce this issue but I cannot see any weird alignments here. Nothing visually bad with the close icon of the modal nor the "Apply filters" button.

The only wrong thing I can see here are the vertical tabs that you can see when having multiple media bundles enabled for referencing.

I have fixed a notice that showed up so this is working now as expected.

yannickoo → made their first commit to this issue’s fork.

Rerolled patch

yannickoo → created an issue.

yannickoo → created an issue.