- Merge request !34Issue #2854585: Improve icon selection in paragraphs type form. → (Open) created by dieterholvoet
- last update
over 1 year ago 180 pass - 🇩🇪Germany hctom
The patch from #17 misses a lot of code changes from #10, therefore hiding it. The MR diff contains all the code changes from #10 and also fixes the deprecated usage of
file_create_url()
. You should use the MR and its diff instead. - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Not currently mergeable. - last update
about 1 year ago 180 pass - 🇩🇪Germany stborchert
I rebased branch 2854585-improve-icon-selection with 8.x-1.x and improved the calls to
file_create_url()
resp. the file_url_generator service. - Open on Drupal.org →Core: 10.1.4 + Environment: PHP 8.1 & MariaDB 10.3.22last update
10 months ago Not currently mergeable. - 🇩🇪Germany hctom
Just found a small bug with this patch: The following element is added to
ParagraphsTypeForm::form()
method's form array by this patch:<?php $form['static_icon_file']['description'] = [ '#type' => 'item', '#description' => $description, ];
Unfortunately an element with
'#type' => 'item'
is treated as an input value and thus interferes with the form's actualdescription
form field value.So my changes add
'#input' => FALSE
to the new$form['static_icon_file']['description']
element to NOT treat this element as a form value anymore.