- Issue created by @pdureau
- 🇩🇪Germany yannickoo Berlin
Wouldn't it be nice to just have the local version which could be automatically installed via
composer.libraries.json
file? - 🇫🇷France pdureau Paris
Wouldn't it be nice to just have the local version which could be automatically installed via composer.libraries.json file? It feels like we would need to add an extra configuration form that is only for this setting.
Hi Yannick, good idea, I will propose to just have the local version. Also, it will be better for the e2e tests must work without external access and should not depend on it.
However, I don't know about
composer.libraries.json
file. I will keep thenpm
installation method already described in the documentation for now. - @pdureau opened merge request.
- 🇫🇷France pdureau Paris
I have also removed this from the SDC stories:
library_wrapper: > <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@shoelace-style/shoelace@2.20.1/cdn/themes/light.css" /> <script type="module" src="https://cdn.jsdelivr.net/npm/@shoelace-style/shoelace@2.20.1/cdn/shoelace-autoloader.js"></script> {{ _story }}
This is not mandatory anymore now we have the expected libraries dependencies.
@mogtofu33: Do you know about
composer.libraries.json
? - 🇫🇷France pdureau Paris
However, currently asset.packagist do not provide the last version of Shoelace.
@mogtofu33: it seems I was wrong, asset-packagist.org has Shoelace 2.20.*: https://asset-packagist.org/package/npm-asset/shoelace-style--shoelace
Do I add a commit with the updated
docs/install.md
? - 🇫🇷France mogtofu33
We need local by default for ci e2e tests and cdn for users with option to switch local.
- 🇫🇷France pdureau Paris
- 🇫🇷France mogtofu33
The cli switch is not working for Playwright tests and we need to be able to run tests and use the Display builder without an internet connection.
- 🇫🇷France mogtofu33
Seems tricky with ENV, Playwright work on an installed Display Builder, every act is manual (or drush).
We need a local/cdn switch in the codebase, either a config, a state, something we can set with drush.