Quick win for beta1, keep open to have better.
Thanks for the report but it has been removed 1 week ago: https://git.drupalcode.org/project/display_builder/-/blob/1.0.x/composer...
Looking good, need more real tests.
For sure the window.addEventListener('htmx:load', triggerDrupalBehaviorsFromHtmxEvent); is way too much, and need to be replaced, will do some tryout on this issue.
Managing the tabs is more work, this feature request is simple and address only the content, which is a good start.
After merge we can have a follow up to hide the tabs.
Off course ComponentSource::settingsSummary() would be a good place, but as today it only add variant. So this is a quick win to have the config available in layer, and we can have a follow up to add it in UI Patterns.
Some Playwright tests can be flaky, but it's not the whole test, when you check the report it's only a small step.
And I am afraid there is something bigger here, something we may regret to ship in beta1
The HTMX part is not finished and messy, but it's not a problem as the js can be updated and refactored, for me not a blocker for beta1.
It works most of the time without SSE, and some refresh can fix some hang up.
Until then we have to break the problem, SSE will not work and makes the builder fail even without concurrent editing, do we release without or wait next year?
The Playwright test seems ok on local.
Our current attachBehaviors and HTMX core usage will need to be updated, but at least it works out of SSE.
So we probably need to decide which time frame we have to provide something we are confident in here.
mogtofu33 โ made their first commit to this issueโs fork.
Partial merge for beta1, need some work and discussion.
mogtofu33 โ changed the visibility of the branch 3538724-provide-some-generic to active.
mogtofu33 โ changed the visibility of the branch 3538724-provide-some-generic to hidden.
The merge split columns remarks need discussion. For now They are useful for me like that.
mogtofu33 โ made their first commit to this issueโs fork.
mogtofu33 โ made their first commit to this issueโs fork.
mogtofu33 โ changed the visibility of the branch 3549867-first-step-is to active.
superseeded by https://www.drupal.org/project/display_builder/issues/3538724 ๐ Provide some generic components Active
The field image seems related to prod mode when the generated sample is not good sometimes.
Dev tools provide a refresh sample, but that's annoying.
Blocks (Views row, Page title...) are replaced with a placeholder until we have a better solution.
As textfield is working, will remove token for now like Wyswiyg.
mogtofu33 โ changed the visibility of the branch 3561038-beta-fixes to hidden.
mogtofu33 โ changed the visibility of the branch 3561038-beta-fixes to active.
mogtofu33 โ made their first commit to this issueโs fork.
mogtofu33 โ changed the visibility of the branch 3561038-beta-fixes to hidden.