🇫🇷France @mogtofu33

mogtofu33 → made their first commit to this issue’s fork.

Fixed the js to not be called multiple times, fixed a but of jsdoc.
Fixed missing schema.
Add a compact mode, update the select twig.
Add e2e test.

mogtofu33 → made their first commit to this issue’s fork.

The cli switch is not working for Playwright tests and we need to be able to run tests and use the Display builder without an internet connection.

Thanks for the work, added tests and some minor refactoring.
We are at the edge of using too much trait instead of abstract or services,this makes reading and tests harder to write, and ide failing completion. To discuss.

New version, discussion with @grimreaper, to add this class in sdc_devel and extend it with a const name.

Related to ✨ Provide the Drush command as bin Active

Better approach to have a unit test class: 📌 Ci: add SDC Devel check in ci Active

We need local by default for ci e2e tests and cdn for users with option to switch local.

Don't know, seems they've been written hover by 📌 Merge island_settings & island_configuration in profiles Active .
Could you create a new branch here to add theme to current 1.0.X?

mogtofu33 → created an issue.

You mean in the composer.json of the module?
For me it's not working, the patch need to be in the main, it's not merge even with "enable-patching": true.

mogtofu33 → created an issue. See original summary → .

Let's have a follow up issue for the performance.

Let force patches 1, I kept the merge in doc as it's still relevant for third party like ui_patterns.
Thanks for the work!

Both instances are different, moving something to a slot trigger a post:

• The path instance_id is the component instance_id that receive the request at the end of drag and triggered the post
• The request instance_id is the component / block moved in the slot

Also if we "move to root a component", why is it the attachToSlot method that is called?

There's a chance it's not needed, this where we need to investigate. This is mostly a legacy code.
There is 2 cases:

• Move from outside (library, an other dropzone like layers -> builder) to root
• Or existing instance moved from a slot to root

mogtofu33 → created an issue.

As discussed with @just_like_good_vibes seems working with ui_patterns 2.x-dev and 2.0.8 release, so need to come back and finish here when 2.0.8 is out.

Still not good, had to fallback to:

          'source' => [
            'component' => [
              'component_id' => $source->getChoiceSettings($component_id),
            ],
          ],

Because it's a big regression I set back the getDataSkeleton, let me know if there can be optimization here.

Seems this broke the component library, adding a component_id when we want an instance_id.

When moving a component we have now an error.

Back to alpha as the complexity of the Island is growing.

mogtofu33 → made their first commit to this issue’s fork.

pdureau → credited mogtofu33 → .

mogtofu33 → made their first commit to this issue’s fork.

When changing any configuration we have a schema error, because each island configuration will be added and is not defined in the schema, for example configure the history on profile default to enable clear button, save.

Error schema:
islands.history.display_clear_button Undefined undefined No 1 missing schema 'display_clear_button' is not a supported key.

Previously it was ignored, as we already have keys defined (enable / weight / region), I am not sure how we can add unknown keys to match any configuration values.

mogtofu33 → created an issue.

mogtofu33 → made their first commit to this issue’s fork.

mogtofu33 → created an issue.

mogtofu33 → made their first commit to this issue’s fork.

mogtofu33 → made their first commit to this issue’s fork.

Thanks, merge, trying to add some tests around the page layout entity, but will need some work on a follow up issue.

Fixed, thanks.

mogtofu33 → made their first commit to this issue’s fork.

In the meantime we could clean the lists part for instances which is a bit everywhere, we have multiple path, class names and opertations, let's try to have a main DisplayBuilderListBuilder class with getOperationLinks, and each module extends if needed.
Route path, names and page titles must be consistent as well.

I don't have option on titles, just proposition to make it consistent.

Page

• List of page config with display config with instances
• /admin/structure/page-layout
  • @todo move to /admin/structure/page-layout/display-builder for consistency
• title: Page layouts
  • @todo change to: Page layouts with Display Builder
• PageLayoutListBuilder
  • entity::getDefaultOperations + build display
  • @todo change to entity::getDefaultOperations + DisplayBuilderDevelHelper::getOperationLinks

Views

• List of instances in Views
• /admin/structure/views/display_builder
  • @todo move to /admin/structure/views/display-builder for consistency
• title: Display builders in Views
  • @todo change to: Views with Display Builder
• ViewsManagementController::pageViewsIndex => @todo rename to ViewsDisplayBuilderList
  • has delete custom operation + build display
  • @todo change to delete custom operation + DisplayBuilderDevelHelper::getOperationLinks

Entity - @todo nothing yet

• List of instances in Entities
• @todo create /admin/structure/entity/display-builder
• title : Entities with Display Builder
• EntityDisplayBuilderList
  • DisplayBuilderDevelHelper::getOperationLinks

UI

• Nothing yet, move from Devel
• @todo: list of instances moved from devel
  • /admin/structure/display-builder/index
  • title: Entities with Display Builder
  • DisplayBuilderList
    • DisplayBuilderDevelHelper::getOperationLinks

Devel @todo move to UI

• List of all instances
• /admin/structure/display-builder/index
• title: Display Builder all instances
• DisplayBuilderDevelController
  • DisplayBuilderDevelHelper::getOperationLinks

mogtofu33 → made their first commit to this issue’s fork.

See the updated content of this issue, 2 of them were included in other mr.

Fixed missing @group. Unrelated func test StatusTest failing.

Added the show variants/grouped/mosaic option
Added validation for no show or no provider
Added no_ui support
Add a basic form test (not covering the configuration, just the config entity)
Add some generics from 📌 Provide some generic components Active

Some styles fixes, phrasing and sorting.

mogtofu33 → created an issue.

We simply need manual tests in full production mode to decide if we need to keep them or not.
Best is a Kernel (or Functional) test.

mogtofu33 → made their first commit to this issue’s fork.

g4mbini → credited mogtofu33 → .

PHPUnit attributes updated.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → made their first commit to this issue’s fork.

mogtofu33 → made their first commit to this issue’s fork.

Thanks for the work.
Fixed the link error (from display_builder_devel).
Added a preview placeholder until we can render the real views area.

The second is from display builder devel operations island, will fix it.

Seems better now, fixed the config on dropzone, seems to have problems when layers is in sidebar but something to address later.

Mild refacto, fixed as well the copy/duplicate/paste that was not keeping the third party (styles).

mogtofu33 → created an issue.

Fresh install with ui_patterns 2.0.5

• Apply Patch https://www.drupal.org/project/display_builder/issues/3534215#comment-16... 📌 Align config storage properties & mechanisms Active
• Enable the module display_builder_views
• Disable css/js, render cache, twig cache

Problem : All views are overridden and there is no fallback to regular view

Quick investigation, the display_builder variable in the view templates can have an empty #cache array

First set of tests:

• Create a new test view for article and page
• Set a display builder
• Save
• Edit the Builder and add a token and views rows, note: I don't see the DB plugin '[View] Rows' but the UI patterns source 'Views rows'

> Visit the page, error UI Patterns (probably because of source plugin being the one from UI Patterns.

Error: Call to a member function getOption() on null in Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewsSourceBase->getViewsFieldOptions() (line 99 of modules/contrib/ui_patterns/modules/ui_patterns_views/src/Plugin/UiPatterns/Source/ViewsSourceBase.php).
Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewRowsSource->getPropValue() (Line: 206)
Drupal\ui_patterns\SourcePluginBase->getValue() (Line: 166)
Drupal\ui_patterns\Element\ComponentElementBuilder->buildSource() (Line: 55)
Drupal\display_builder_views\Hook\PreprocessViewsView->preprocessViewsView() (Line: 367)

Create a new view and create DB with not default config, for example devel config,
If Enable on a view a display builder > save, then edit and change configuration for devel, same error:

Symfony\Component\Routing\Exception\MissingMandatoryParametersException: Some mandatory parameters are missing ("view", "display") to generate a URL for route "display_builder_views.views.manage". in Drupal\Core\Routing\UrlGenerator->doGenerate() (line 189 of core/lib/Drupal/Core/Routing/UrlGenerator.php).
Drupal\Core\Routing\UrlGenerator->getInternalPathFromRoute() (Line: 310)
Drupal\Core\Routing\UrlGenerator->generateFromRoute() (Line: 105)
Drupal\Core\Render\MetadataBubblingUrlGenerator->generateFromRoute() (Line: 773)
Drupal\Core\Url->toString() (Line: 37)
Drupal\display_builder_devel\Plugin\display_builder\Island\OperationButton->build() (Line: 393)
Drupal\display_builder\Entity\DisplayBuilder->buildPanes() (Line: 165)
Drupal\display_builder\Entity\DisplayBuilder->build() (Line: 68)
Drupal\display_builder_views\Controller\ViewsController->getBuilder()

If Display builder is enabled on a view, and the view not saved, if click on the view on the Display builder > build display, this redirect to 'Page not found'
> Expected: If there is a link and the builder appear in 'Views builder', should be able to edit it

Can not edit a display from 'Display builders in Views' (/admin/structure/views/display_builder), so cannot change the configuration
If Builder deleted from 'Display builders in Views' (/admin/structure/views/display_builder), still set in the views

When enabled display should we have the default views zone field set to not start empty?

When add a display builder in a view, schema error:
Schema errors for views.view.content with the following errors: views.view.content:display.page_1.display_options.display_extenders.display_builder.sources missing schema.