Account created on 17 April 2008, over 17 years ago
#

Merge Requests

More

Recent comments

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

Quick win for beta1, keep open to have better.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

Thanks for the report but it has been removed 1 week ago: https://git.drupalcode.org/project/display_builder/-/blob/1.0.x/composer...

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

Looking good, need more real tests.

For sure the window.addEventListener('htmx:load', triggerDrupalBehaviorsFromHtmxEvent); is way too much, and need to be replaced, will do some tryout on this issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

Managing the tabs is more work, this feature request is simple and address only the content, which is a good start.
After merge we can have a follow up to hide the tabs.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

Off course ComponentSource::settingsSummary() would be a good place, but as today it only add variant. So this is a quick win to have the config available in layer, and we can have a follow up to add it in UI Patterns.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

Some Playwright tests can be flaky, but it's not the whole test, when you check the report it's only a small step.

And I am afraid there is something bigger here, something we may regret to ship in beta1

The HTMX part is not finished and messy, but it's not a problem as the js can be updated and refactored, for me not a blocker for beta1.
It works most of the time without SSE, and some refresh can fix some hang up.

Until then we have to break the problem, SSE will not work and makes the builder fail even without concurrent editing, do we release without or wait next year?

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

The Playwright test seems ok on local.
Our current attachBehaviors and HTMX core usage will need to be updated, but at least it works out of SSE.
So we probably need to decide which time frame we have to provide something we are confident in here.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

Fixed in ๐Ÿ› CKEditor css bleeding Active

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

Beta 1 is ready, let's go!

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

Partial merge for beta1, need some work and discussion.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ changed the visibility of the branch 3538724-provide-some-generic to active.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ changed the visibility of the branch 3538724-provide-some-generic to hidden.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

The merge split columns remarks need discussion. For now They are useful for me like that.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ changed the visibility of the branch 3549867-first-step-is to active.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

superseeded by https://www.drupal.org/project/display_builder/issues/3538724 ๐Ÿ“Œ Provide some generic components Active

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

The field image seems related to prod mode when the generated sample is not good sometimes.
Dev tools provide a refresh sample, but that's annoying.

Blocks (Views row, Page title...) are replaced with a placeholder until we have a better solution.

As textfield is working, will remove token for now like Wyswiyg.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

For no it's removed from our UI.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ changed the visibility of the branch 3561038-beta-fixes to hidden.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

We missed some.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

Replaced on dev_tools fixtures.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ changed the visibility of the branch 3561038-beta-fixes to active.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

Detaching an instance is enough to disable/enable.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ created an issue.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33

mogtofu33 โ†’ changed the visibility of the branch 3561038-beta-fixes to hidden.

๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
๐Ÿ‡ซ๐Ÿ‡ทFrance mogtofu33
Production build 0.71.5 2024