🇫🇷France @mogtofu33

Fixed missing @group. Unrelated func test StatusTest failing.

Added the show variants/grouped/mosaic option
Added validation for no show or no provider
Added no_ui support
Add a basic form test (not covering the configuration, just the config entity)
Add some generics from 📌 Provide some generic components Active

Some styles fixes, phrasing and sorting.

mogtofu33 → created an issue.

We simply need manual tests in full production mode to decide if we need to keep them or not.
Best is a Kernel (or Functional) test.

mogtofu33 → made their first commit to this issue’s fork.

g4mbini → credited mogtofu33 → .

PHPUnit attributes updated.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → made their first commit to this issue’s fork.

mogtofu33 → made their first commit to this issue’s fork.

Thanks for the work.
Fixed the link error (from display_builder_devel).
Added a preview placeholder until we can render the real views area.

The second is from display builder devel operations island, will fix it.

Seems better now, fixed the config on dropzone, seems to have problems when layers is in sidebar but something to address later.

Mild refacto, fixed as well the copy/duplicate/paste that was not keeping the third party (styles).

mogtofu33 → created an issue.

Fresh install with ui_patterns 2.0.5

• Apply Patch https://www.drupal.org/project/display_builder/issues/3534215#comment-16... 📌 Align config storage properties & mechanisms Active
• Enable the module display_builder_views
• Disable css/js, render cache, twig cache

Problem : All views are overridden and there is no fallback to regular view

Quick investigation, the display_builder variable in the view templates can have an empty #cache array

First set of tests:

• Create a new test view for article and page
• Set a display builder
• Save
• Edit the Builder and add a token and views rows, note: I don't see the DB plugin '[View] Rows' but the UI patterns source 'Views rows'

> Visit the page, error UI Patterns (probably because of source plugin being the one from UI Patterns.

Error: Call to a member function getOption() on null in Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewsSourceBase->getViewsFieldOptions() (line 99 of modules/contrib/ui_patterns/modules/ui_patterns_views/src/Plugin/UiPatterns/Source/ViewsSourceBase.php).
Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewRowsSource->getPropValue() (Line: 206)
Drupal\ui_patterns\SourcePluginBase->getValue() (Line: 166)
Drupal\ui_patterns\Element\ComponentElementBuilder->buildSource() (Line: 55)
Drupal\display_builder_views\Hook\PreprocessViewsView->preprocessViewsView() (Line: 367)

Create a new view and create DB with not default config, for example devel config,
If Enable on a view a display builder > save, then edit and change configuration for devel, same error:

Symfony\Component\Routing\Exception\MissingMandatoryParametersException: Some mandatory parameters are missing ("view", "display") to generate a URL for route "display_builder_views.views.manage". in Drupal\Core\Routing\UrlGenerator->doGenerate() (line 189 of core/lib/Drupal/Core/Routing/UrlGenerator.php).
Drupal\Core\Routing\UrlGenerator->getInternalPathFromRoute() (Line: 310)
Drupal\Core\Routing\UrlGenerator->generateFromRoute() (Line: 105)
Drupal\Core\Render\MetadataBubblingUrlGenerator->generateFromRoute() (Line: 773)
Drupal\Core\Url->toString() (Line: 37)
Drupal\display_builder_devel\Plugin\display_builder\Island\OperationButton->build() (Line: 393)
Drupal\display_builder\Entity\DisplayBuilder->buildPanes() (Line: 165)
Drupal\display_builder\Entity\DisplayBuilder->build() (Line: 68)
Drupal\display_builder_views\Controller\ViewsController->getBuilder()

If Display builder is enabled on a view, and the view not saved, if click on the view on the Display builder > build display, this redirect to 'Page not found'
> Expected: If there is a link and the builder appear in 'Views builder', should be able to edit it

Can not edit a display from 'Display builders in Views' (/admin/structure/views/display_builder), so cannot change the configuration
If Builder deleted from 'Display builders in Views' (/admin/structure/views/display_builder), still set in the views

When enabled display should we have the default views zone field set to not start empty?

When add a display builder in a view, schema error:
Schema errors for views.view.content with the following errors: views.view.content:display.page_1.display_options.display_extenders.display_builder.sources missing schema.

Did you test last version and flush css cache? it was fixed here.

For me it's ok.

Fixed the new case, some style review and should be ok.

Fixed the configure click problem, the route {display_builder}/{instance_id} was conflicting with {display_builder}/delete
Still have a problem when creating a new config of DB islands, the route require an id which is not ready yet and will raise an error.

I created a rebased version, bug is still there, and cannot add a new DB config as well.

mogtofu33 → changed the visibility of the branch 3529067-make-island-plugins to hidden.

I struggled on the rebase so canceled it, would be probable easier to squash the current mr to one commit.

For the the configuration form of History island raise an ajax error without message.

• Fresh install
• Go to Default islands configuration
• Click configure in front of History
• -> Ajax error

There is still some issues if the layers is enabled in the same time as builder, probably a number of possible dropzone problems.

christian.wiedemann → credited mogtofu33 → .

mogtofu33 → created an issue. See original summary → .

It was not working because of the commented auto update, set it back.

In my opinion this is not a problem, obviously it's coming from DSFR with some specific radio js that assume there is only one set of radios in the page.
see display-selector.js
and display.js.

So there is nothing we can do worth the effort.
You will have the same kind of problems with other components like consent banner.

mogtofu33 → created an issue.

pdureau → credited mogtofu33 → .

mogtofu33 → created an issue.

mogtofu33 → created an issue.

Yes let's wait for configuration before merging this one.
Not activated by default, and should be marked partial.
Undo / redo should probably have a reference in ✨ Add real-time collaboration Active ?

Parent is working because it's parent menu entry.
But the strict structure is not good and should accept render array.

We could add an items_megamenu as array prop to allow richer content. If is_mega_menu and empty items_megamenu, then fallback on items to avoid breaking.

Or we could have a new component.

Until then here is the story updated to reflect the megamenu.

mogtofu33 → made their first commit to this issue’s fork.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

pdureau → credited mogtofu33 → .

Moved to display with modal.

Tile in a grid for better display.

Schema added, description and title could be optimized, feel free to update them directly on the MR.

pdureau → credited mogtofu33 → .

Added card story in a grid for better display.
Used wrapper with bg_boxes loop.

mogtofu33 → made their first commit to this issue’s fork.

We don't have this feature in Drupal pagination, the last page is already available with 'last' property.
So I don't think there is a story to update here. To discuss.

Cannot be added on the display level, added on the modal level.
In the meantime fix the modal story by adding a wrapper, so now it works. Plus a group.

mogtofu33 → made their first commit to this issue’s fork.

The phpunit error is not related.
Added to grid as well for small version.
Here is the result:

Back to no_ui as it makes more sense if missing then it is false.

Yes with has_ui, if missing, it is like has_ui= true

@pdureau is fast, so my proposition is a 3rd one, has_ui with default true!

I like this request, here is a starting point proposition.
I would like to challenge the no_ui term because of negative naming (boolean blindness).
I understand it's used on plugins, but we can go to has_ui as default true.

mogtofu33 → made their first commit to this issue’s fork.

Can you reproduce without loading a fixture?
Can you reproduce if you create your own fixture with valid icon ids you have installed and working?

It's not broken, it was cleaned on purpose. Hence the commit title: 'fix: instance form css cleanup'.
Too many specific fixes and quirks depending front theme, so better to start from clean and see what we can do without bleeding or tweaks.

It's not sass, just modern nested css and variables.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

mogtofu33 → created an issue.

Message fixed.

I have a problem from a clean install, all caches ON, no dev only verbose error logging:

• Layout builder is NOT enabled
• Go to ui modules list and enable display_builder_entity_view
• Accept other modules including layout builder
• Submit, error appear:

Drupal\Core\Entity\Exception\NoCorrespondingEntityClassException: The Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay class does not correspond to an entity type. in Drupal\Core\Entity\EntityTypeRepository->getEntityTypeFromClass() (line 111 of core/lib/Drupal/Core/Entity/EntityTypeRepository.php).

This makes the display_builder config to not be installed properly (missing config default) and add some failing on the display of entity.

Do we have a way to ensure layout_builder is enabled before? perhaps with a dependencies?