- Issue created by @pdureau
- 🇫🇷France pdureau Paris
This may also help the use of
iframe
inbuilder
and preview panels - 🇫🇷France pdureau Paris
This may also the opportunity of tidying ApiController:
- Move builder and island id to properties?
- Merge
update
andthirdPartySettingsUpdate
?
- 🇫🇷France pdureau Paris
So, when do we want to block refresh:
BuilderPanel
&LayersPanel
:onRootDrop
andonSlotDrop
, but only on move (because we need the refresh to get the placeholder replacement when on add)InstanceFormPanel
:onInstanceFormChange
andonInstanceUpdateButtonClick
- ThirdPartySettings panels (UI Styles, UI Skins...)
Other islands triggering HTMX events but which needs to be refreshed:
- HistoryButton (onUndo, onRedo, onClear)
- MenuDelete (onClickDelete)
- StateButtons (onSave, onReset, onRevert)
- Menu (onClickDuplicate, onClickPaste)
Those islands don't trigger events:
- ViewportSwitcher
- ComponentLibraryPanel
- BlockLibraryPanel
- ...
- 🇫🇷France pdureau Paris
We will also do those non-relaetd tasks:
- Merge InfoPanel into InstanceForm panel
- Add
readonly
keywords to HistoryStep
- Merge request !100Issue #3531269 by pdureau: Don't replace unchanged panels → (Merged) created by pdureau
- 🇫🇷France pdureau Paris
2 things to be careful about:
- If the UIP2 AJAX issue is solved on 1.0.x (to be confirmed), it is not the case in ths MR so it may be a regression
- the last commit Remove previous use of current_island_id is a bit bold with the removal of a badly understood mechanism:
- if ($form_state->isRebuilding() && (!isset($options['current_island_id']) || $this->getPluginId() === $options['current_island_id'])) { + if ($form_state->isRebuilding()) {
if there is any doubt, let's revert it and move the change to a dedicated issue
-
mogtofu33 →
committed e3f5c0f7 on 1.0.x authored by
pdureau →
[#3531269] fix: do not replace unchanged panels
-
mogtofu33 →
committed e3f5c0f7 on 1.0.x authored by
pdureau →
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.