- Issue created by @pdureau
- 🇫🇷France pdureau Paris
According to Christian, the reason for 2 properties is to avoid to override values because they are not written by the same controller.
According to Jean it may be possible to merge them now but we need to check.
- Merge request !58Issue #3538440 by pdureau: Merge island_settings & island_configuration in profiles → (Merged) created by pdureau
- 🇫🇷France pdureau Paris
Waiting for 📌 Split DisplayBuilderForm::form() in 3 to ease maitainance Active to be merged
- 🇫🇷France pdureau Paris
Done.
Kept on my side because I will do extra checks before sending it to review.
- 🇫🇷France mogtofu33
When changing any configuration we have a schema error, because each island configuration will be added and is not defined in the schema, for example configure the history on profile default to enable clear button, save.
Error schema:
islands.history.display_clear_button Undefined undefined No 1 missing schema 'display_clear_button' is not a supported key.Previously it was ignored, as we already have keys defined (enable / weight / region), I am not sure how we can add unknown keys to match any configuration values.
-
mogtofu33 →
committed 9911576d on 1.0.x authored by
pdureau →
Issue #3538440 by pdureau: Merge island_settings...
-
mogtofu33 →
committed 9911576d on 1.0.x authored by
pdureau →