Wrong event triggered by ApiController::attachToSlot()

pdureau → credited grimreaper → .

pdureau → credited mogtofu33 → .

Accordign to Jean:

It's here because if you move to root a component there is no slot, it must be added to the root, if not it will fail.

So the expected change must be to keep the mechanism but to rename something and add a comment

In attachToSlot, what is the point to have $instance_id in the route, when it is also obtained with parameters? $request->request->has('instance_id')

Except for a debug message.

Also if we "move to root a component", why is it the attachToSlot method that is called?

Not sure I am the best to know what is to be renamed/commented.

Not sure I am the best to know what is to be renamed/commented.

@mogtofu33?

Both instances are different, moving something to a slot trigger a post:

• The path instance_id is the component instance_id that receive the request at the end of drag and triggered the post
• The request instance_id is the component / block moved in the slot

Also if we "move to root a component", why is it the attachToSlot method that is called?

There's a chance it's not needed, this where we need to investigate. This is mostly a legacy code.
There is 2 cases:

• Move from outside (library, an other dropzone like layers -> builder) to root
• Or existing instance moved from a slot to root