- Issue created by @pdureau
- 🇫🇷France pdureau Paris
Moved to alpha4 because we need 📌 Align source contexts Active before
- 🇫🇷France pdureau Paris
3 little other tasks:
- Do we need to implement
EntiyWithDisplayBuilderInterface
? - Use
ConfigFormBuilderInterface::SOURCES_PROPERTY
- Remove "Machine name" from /admin/structure/display-builder
- Do we need to implement
- 🇫🇷France pdureau Paris
I will also remove the unused Form\DisplayBuilderDeleteForm
- 🇫🇷France pdureau Paris
Work in progress.
Current status:
- Context awareness: TODO
- Theme dependency (and other dependencies?): TODO
- Fix the source storage: ✅ DONE
- Use ConfigFormBuilderInterface::SOURCES_PROPERTY: Finally not, because this is not the same as WithDisplayBuilderInterface::getSources(). the root level is a single nestable source plugin instead of a list.
- Remove "Machine name" from /admin/structure/display-builder: ✅ DONE
- Reorganize a bit the entity form: ✅ DONE
- Remove the unused Form\DisplayBuilderDeleteForm: ✅ DONE
- @pdureau opened merge request.
- 🇫🇷France pdureau Paris
PHPunit fails because of pipeline timeout. I don't know if it is related to my changes.
- 🇫🇷France pdureau Paris
OK for review.
Now we have a proper dependencies management, when we uninstall a theme which is a dependency of a PatternPreset, the PatternPreset config entity is deleted.
Is it what we want? Do we prefer to block theme uninstallation instead? - First commit to issue fork.
-
mogtofu33 →
committed 19e6f7dc on 1.0.x authored by
pdureau →
Issue #3534190 by pdureau: Pattern presets storage and dependencies
-
mogtofu33 →
committed 19e6f7dc on 1.0.x authored by
pdureau →
- 🇫🇷France pdureau Paris
Jean, it seems some commits have disappeared when you merged this issue.
For example:
- 22cb6215 - Restore annotated_name because we are multi provider again
- 2a7d9827 - Some adjustments related to theme and 3rd party settings management
What happened? How can we restore them? How can we make sure it will not happen again?
- 🇫🇷France mogtofu33
Don't know, seems they've been written hover by 📌 Merge island_settings & island_configuration in profiles Active .
Could you create a new branch here to add theme to current 1.0.X? - @pdureau opened merge request.
- 🇫🇷France pdureau Paris
Pushed: https://git.drupalcode.org/project/display_builder/-/merge_requests/76
I check if everything is still OK and i send to review
-
mogtofu33 →
committed 5de3ceb9 on 1.0.x authored by
pdureau →
Issue #3534190 by pdureau: Pattern presets storage and dependencies
-
mogtofu33 →
committed 5de3ceb9 on 1.0.x authored by
pdureau →
- Status changed to Fixed
27 days ago 12:59pm 5 September 2025 Automatically closed - issue fixed for 2 weeks with no activity.