- Issue created by @pdureau
- 🇫🇷France pdureau Paris
Would it be possible to do the same for
[Entity] ➜ Referenced [Entity]"
?So, with both modifications:
- First commit to issue fork.
- @just_like_good_vibes opened merge request.
- Status changed to Needs work
16 days ago 7:58am 9 August 2025 - 🇫🇷France pdureau Paris
Thanks for your ongoing work.
Can you also remove
SourcesBundlerInterface
andComponentSource
fromui_patterns_overrides
module? You will need to update the class actually depending on this interface:- SlotSourceProxy : replace
SourcesBundlerInterface::getOptionLabel()
by something fromSourceWithChoicesInterface
- ComponentLibraryPanel: replaces
SourcesBundlerInterface::getDataSkeleton()
bySourceWithChoicesInterface::getChoiceSettings()
- BlockLibraryPanel: a linter will remove automatically the remaining
SourcesBundlerInterface
- WysiwygWidget: just remove it,
SourcesBundlerInterface
doesn't make sense here
We also need to check the UI (not because UI is part of this issue scope, but because it will tell us if we did things the right way):
- In BuilderPanel, LayersPanel and TreePanel: we have source label + summary (example: "[Entity] ➜ [Field]: body") instead of the choice label ("Body")
- In Menu islands: we have only source label (example: "[Entity] ➜ [Field]") instead of the choice label ("Body')
- What else?
- SlotSourceProxy : replace
-
mogtofu33 →
committed fed137aa on 1.0.x authored by
just_like_good_vibes →
Issue #3529260 by just_like_good_vibes, pdureau: Flatten the Fields list
-
mogtofu33 →
committed fed137aa on 1.0.x authored by
just_like_good_vibes →
-
mogtofu33 →
committed b1a68ce4 on 1.0.x
Issue #3529260 style: some style fixes
-
mogtofu33 →
committed b1a68ce4 on 1.0.x
- 🇫🇷France mogtofu33
Seems this broke the component library, adding a component_id when we want an instance_id.
When moving a component we have now an error.
-
mogtofu33 →
committed de1f3626 on 1.0.x
Issue #3529260 by just_like_good_vibes, pdureau, mogtofu33: Flatten the...
-
mogtofu33 →
committed de1f3626 on 1.0.x
- 🇫🇷France mogtofu33
Because it's a big regression I set back the getDataSkeleton, let me know if there can be optimization here.
- @just_like_good_vibes opened merge request.
- 🇫🇷France just_like_good_vibes PARIS
i posted an update of the code which seems to correct the issue,
but this issue in ui_patterns is needed : https://www.drupal.org/project/ui_patterns/issues/3540835 🐛 [2.0.8] correct ChoiceSettings for Component source Active -
mogtofu33 →
committed 919deca9 on 1.0.x authored by
just_like_good_vibes →
Issue #3529260 by just_like_good_vibes, pdureau: Flatten the Fields list
-
mogtofu33 →
committed 919deca9 on 1.0.x authored by
just_like_good_vibes →
- 🇫🇷France mogtofu33
Still not good, had to fallback to:
'source' => [ 'component' => [ 'component_id' => $source->getChoiceSettings($component_id), ], ],
-
mogtofu33 →
committed 7bbe9c89 on 1.0.x
Issue #3529260 by just_like_good_vibes, pdureau: Flatten the Fields list
-
mogtofu33 →
committed 7bbe9c89 on 1.0.x
-
mogtofu33 →
committed 5cc64d50 on 1.0.x
Issue #3529260 by just_like_good_vibes, pdureau: Flatten the Fields list
-
mogtofu33 →
committed 5cc64d50 on 1.0.x
- 🇫🇷France mogtofu33
As discussed with @just_like_good_vibes seems working with ui_patterns 2.x-dev and 2.0.8 release, so need to come back and finish here when 2.0.8 is out.
- @just_like_good_vibes opened merge request.
- 🇫🇷France Grimreaper France 🇫🇷
Thanks!
It fixes the fatal on latest dev version of ui_patterns 2.0.8.
- 🇫🇷France just_like_good_vibes PARIS
this fix has been pushed and re-pushed again until we finally have it now with a clean dependency to a required ui_patterns min version.
finally... but this is not finished, we will follow-up - in that issue or not? - performances issues introduced now. -
mogtofu33 →
committed 8d9ec8c1 on 1.0.x authored by
just_like_good_vibes →
Issue #3529260 by just_like_good_vibes, pdureau: Flatten the Fields list...
-
mogtofu33 →
committed 8d9ec8c1 on 1.0.x authored by
just_like_good_vibes →