- Issue created by @pdureau
- 🇫🇷France mogtofu33
In the meantime we could clean the lists part for instances which is a bit everywhere, we have multiple path, class names and opertations, let's try to have a main DisplayBuilderListBuilder class with getOperationLinks, and each module extends if needed.
Route path, names and page titles must be consistent as well.I don't have option on titles, just proposition to make it consistent.
Page
- List of page config with display config with instances
- /admin/structure/page-layout
- @todo move to /admin/structure/page-layout/display-builder for consistency
- title: Page layouts
- @todo change to: Page layouts with Display Builder
- PageLayoutListBuilder
- entity::getDefaultOperations + build display
- @todo change to entity::getDefaultOperations + DisplayBuilderDevelHelper::getOperationLinks
Views
- List of instances in Views
- /admin/structure/views/display_builder
- @todo move to /admin/structure/views/display-builder for consistency
- title: Display builders in Views
- @todo change to: Views with Display Builder
- ViewsManagementController::pageViewsIndex => @todo rename to ViewsDisplayBuilderList
- has delete custom operation + build display
- @todo change to delete custom operation + DisplayBuilderDevelHelper::getOperationLinks
Entity - @todo nothing yet
- List of instances in Entities
- @todo create /admin/structure/entity/display-builder
- title : Entities with Display Builder
- EntityDisplayBuilderList
- DisplayBuilderDevelHelper::getOperationLinks
UI
- Nothing yet, move from Devel
- @todo: list of instances moved from devel
- /admin/structure/display-builder/index
- title: Entities with Display Builder
- DisplayBuilderList
- DisplayBuilderDevelHelper::getOperationLinks
Devel @todo move to UI
- List of all instances
- /admin/structure/display-builder/index
- title: Display Builder all instances
- DisplayBuilderDevelController
- DisplayBuilderDevelHelper::getOperationLinks
- 🇫🇷France pdureau Paris
Great idea. Standardization is welcomed.
My personal feedbacks:
Page
- List of page config with display config with instances
- /admin/structure/page-layout
- @todo move to /admin/structure/page-layout/display-builder for consistency >> ⚠️ So what would be the content of /admin/structure/page-layout/ ?
- title: Page layouts
- @todo change to: Page layouts with Display Builder >> ⚠️ OK but let's keep the menu entry in /admin/structure simply "Page layouts" ?
- PageLayoutListBuilder
- entity::getDefaultOperations + build display
- @todo change to entity::getDefaultOperations + DisplayBuilderDevelHelper::getOperationLinks
Views
- List of instances in Views
- /admin/structure/views/display_builder
- @todo move to /admin/structure/views/display-builder for consistency >>👍 cool
- title: Display builders in Views
- @todo change to: Views with Display Builder >> 👍 way better
- ViewsManagementController::pageViewsIndex => @todo rename to ViewsDisplayBuilderList >> 👍 nice
- has delete custom operation + build display
- @todo change to delete custom operation + DisplayBuilderDevelHelper::getOperationLinks
Entity - @todo nothing yet
⚠️ I am not sure about the purpose of this list (maybe too overkill for site builders and developers already have /admin/structure/display-builder/index) but we can add it now and move it to Devel later if users find it confusing.
- List of instances in Entities
- @todo create /admin/structure/entity/display-builder >> ⚠️ /admin/structure/entity is not a thing. Can we put it in an existing place? I don't see one to be honest. That may be the int this list is not expected.
- title : Entities with Display Builder >> ⚠️ Would "Entity displays with Display Builder" be better? Or maybe "Entity view displays with Display Builder" to avoid future confusion with
display_builder_entity_form
? - EntityDisplayBuilderList
- DisplayBuilderDevelHelper::getOperationLinks
UI & Devel
⚠️ are you sure it would not be confusing for users to have access to /admin/structure/display-builder/index ? It looks like low level information and I am afraid we will move it back to Devel after some users feedbacks in beta phase.
-
mogtofu33 →
committed 569ed6ec on 1.0.x
Issue #3538607 by pdureau, mogtofu33: Pre task: consistent paths dash
-
mogtofu33 →
committed 569ed6ec on 1.0.x
- Merge request !90Draft: #3538607 feat: rewrite ui, mode devel module, button to leave the builder → (Open) created by mogtofu33
- 🇫🇷France mogtofu33
mogtofu33 → changed the visibility of the branch 3538607-ui-refactor to hidden.
- 🇫🇷France pdureau Paris
Test feature:
- Page Layout : OK, works as expected
- View: OK, works as expected
- Entity View: KO:
Symfony\Component\Routing\Exception\RouteNotFoundException: Route "entity.entity_view_display.node.teaser" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 214 of core/lib/Drupal/Core/Routing/RouteProvider.php).
- Entity View Override: OK, no button because there is already the tabs
To discuss in a follow-up issue for beta1 (because changing the pluginId will alter config storage):
- Wording: "Parent link" & "Allow a direct link in parent display."
- Icon in button
- Add title attribute to button.
Now that this issue is closed, please review the contribution record.
As a contributor, attribute any organization helped you, or if you volunteered your own time.
Maintainers, please credit people who helped resolve this issue.
-
mogtofu33 →
committed ed71b1c2 on 1.0.x
[#3538607] feat: island parent button
-
mogtofu33 →
committed ed71b1c2 on 1.0.x