Contrib.social

Tidy DisplayBuilderHelpers

Open on Drupal.org →
Created on 3 August 2025, 10 days ago

Problem/Motivation

DisplayBuilderHelpers is doing too much and some parts belong display_builder_devel

6 public static methods:

::findArrayReplaceSource() used in:

  • display_builder_page_layout/Plugin/DisplayVariant/DisplayBuilder
  • display_builder/Plugin/display_builder/Island/PreviewPanel

And in ::getFixtureDataFromExtension()

::getFixtureData() used in:

  • display_builder_devel/Form/AddForm
  • display_builder_page_layout/Entity/PageLayout
  • display_builder_views/Plugin/views/display_extender/DisplayBuilder

::getFixturesOptions() never used outside of ::getAllFixturesOptions()

::getAllFixturesOptions() used in:

  • display_builder_devel/Form/AddForm
  • display_builder_devel/Form/ImportForm

::getAllFixturesData() used in

  • display_builder_devel/Form/ImportForm

::getFixtureDataFromExtension() used in:

  1. display_builder_page_layout/Entity/PageLayout
  2. display_builder_views/Plugin/views/display_extender/DisplayBuilder

And in ::getAllFixturesData()

Proposed resolution

Move to display_builder_devel:

  • ::getAllFixturesOptions()
  • ::getFixturesOptions() and make it private
  • ::getAllFixturesData()

Keep in display_builder:

  • ::findArrayReplaceSource()
  • ::getFixtureData()
  • ::getFixtureDataFromExtension() and remove unused $suffix parameter
📌 Task
Status

Active

Version

1.0

Component

Main / Misc.

Created by

🇫🇷France pdureau Paris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024