🇵🇱Poland @salmonek

Thank you guys for reporting and fix.

Ideally, the query would be limited to users with the to be mentioned permission.

Yup, that's ideal scenario and possibly enough for many sites. I'v added a checkbox setting at the module's config page - defaults to FALSE to not surprise existing users with potential sudden change, but set to TRUE on module installation.
If the setting is TRUE then simple query with role condition is used. In case someone needs more complex solution then tagged query with per user access check is available.
Appears to be working fine, however feedback will be very much appreciated.

I removed tag constat type delcaration to preserve PHP 8.1 compatibility.

250k users - that's impressive. I have worked with sites having houndreads of k's of entities, but never with such amount of users.

salmonek → made their first commit to this issue’s fork.

Hi Stephen
Yes, this is default. We went with this approach to not worry about version incompatibilities between base CKEditor script and plugins. Drupal 10.3 for example was released with CKEditor that introduced breaking changes that made a lot of plugins incompatible. With cdn we are able to load plugins that maches base CKEditor script version.

Drupal now uses the dll installation method, where each plugin is loaded with separate file. By the time Plugin Pack was created not all plugins were installed by Drupal. This changed apparently in Drupal 10.4/11.0

There is a setting at /admin/config/ckeditor5-plugin-pack that allows to set the local path for dll's used by Plugin Pack, so you can set /core/assets/vendor/ckeditor5/ path if you use recent Drupal version.

I'll also update the module code to check at vendor dir automatically. (Changing to feature request)

Hi James,
The patch looks good. When installing from configuration the user field should indeed be created with proper config. The notification can be also assumed to be already viewed.
The question for reproduction attempt: I tried to create fresh site, change the site uuid and import config with drush - was that your procedure too or something else? I didn't reproduce isse this way.

Hi Stephen,

Thank you for reporting this issue.
In case both Table and Layout table plugins are added (plus HTML filter is disabled) then the contextual toolbar elements are added by both of them.
I have added hook_editor_js_settings_alter implementation that will ensure that table toolbar elements are unique (so cache rebuild is required)

salmonek → made their first commit to this issue’s fork.

@hades322

Is there a possibility to get your editor configuration?
We're testing this internally and it looks for us that GeneralHtmlSupport plugin (which provides support for html elements that do not have related toolbar plugins, for example div, span, iframe) causes that `supportAllValues` does not have any effect on the output code - even your example has always the Poppins font retained on the "bb" when I test it.
It might be helpful to check it on your editor configuration - editor.editor.XXX.yml and filter.format.XXX.yml.
If it indeed works with some configurations, but don't with others we could add the option with proper description.

Added a deprecated FileSystemInterface::EXISTS_REPLACE replacement. With this change also minimum core requirement is bumped to 10.3. We'll release this update when we'll have a new submodule (in 1.5.0)

salmonek → made their first commit to this issue’s fork.

Added a paragraph about default values to merge fields section.

@jons

In the "Active toolabar" textarea find and delete "fullScreen", text (or with comma in front in case fullscreen was the last item in your toolbar). You should be able to save the text format and subsequent edit will have toolbars rendered correctly.
The old configuration doesn't work with new module as the new plugin has minimally different label for the toolbar item.
On the module side we'll think about implementing hook_uninstall which will check existing text formats and remove old item if necessary.

In version 1.6.0 we have bumped required Drupal version to 10.3, so we can now replace deprecated DocumentList in the next release.
The patch compatible with 1.6.0 is available through gitlab MR

Hi Ferdinand,

Thank you for bringing this to our attention and your fix.
I have added a LegacyInstaller class for compatibility with <11.2

salmonek → made their first commit to this issue’s fork.

Screenshot added

I did small refactor of the code.
We didn't had time to slip this fix in today's release so it'll land in next one.

Added Merge fields ane Export with inline styles configuration guides

We have released the autoembed submodule in version 1.4.1
I'm sorry for not sharing the MR here before, I'll marks the ticket as Needs Review for now (it was approved by our QA team)
The plugin works with Youtube, Vimeo, Dailymotion and Spotify - for those sites CKEditor can create a code that browsers can render out of the box.
The other sites embeds can be displayed only as <oembed> element that requires some third party scripts. I didn't find a drupal module that could handle this. If there would be something, we could add the configuration form in the text format settings to allow other sources.

Please try new module and share your opinion.

Released in 1.4.1

Released in 1.6.0

Released in 1.6.0

Reviewed and tested by our QA team, merged into 1.5.x and will be released in 1.6.0 tomorrow. In addition to bumping minimum required Drupal version, we'll have a new submodule.

Hi Aaron
I've pushed a quickfix, that should work for you. I'm not changing the issue status as we'll have to check which CKEditor version changed the format and make sure it'll work correctly with any supported CKEditor version.

salmonek → made their first commit to this issue’s fork.

Add info about workflow in new CKEditor versions

Hi,
Thank you for your contribution.

I've added few other deprecation fixes, pushed everything to 1.5.x MR and closed the 1.4.x MR

@Vinodhini
I've removed the strip_tags() as renderPlain() did return HTML and we want it in notifications.

The renderInIsolation() function and FileExists enum were added in Drupal 10.3 so I bumped the required core version. We'll release these updates in 1.6.0 - which will be released soon (will contain a new submodule), so that'll be good occasion to drop <10.3 support.
We don't want to mark Drupal 12 as supported yet, because of https://www.drupal.org/project/drupal/issues/3527914 📌 Use New installation methods for CKEditor5 Active which may land in 12.0 and will affect Premium Features module.

salmonek → made their first commit to this issue’s fork.

Added info about self hoste/EU cloud endpoints

Hi Sathish

Please provide screenshot of dev console content above that error. The information about which plugin cannot be loaded is logged before the error itself.

Hi hades322,

I've pushed changes that adds a config option for supportAllValues in the text format settings. Default is set to FALSE as that is default for CKEditor 5 itself.
As a bonus I've added support for predefined size classes: https://ckeditor.com/docs/ckeditor5/latest/features/font.html#using-the-...

salmonek → made their first commit to this issue’s fork.

Hi Stephen,

Thank you for bringing this to our attention.
Indeed, the Drupal UI dialogs have lower z-index than fullscreen.
I've pushed a patch with added css rule to make Drupal UI dialogs visible when using fullscreen.
Works with Claro and Gin.

salmonek → made their first commit to this issue’s fork.

Merged into 1.5.x. I also set 1.5.x as default as this was omitted after recent release.

Thank you Hendrik for the patch and mscieszka for review.

salmonek → made their first commit to this issue’s fork.

Hi dcooke01

The link popup has changed in a version of CKEditor 5 that is available in Drupal 10.5.
Now you have to add url first, and then clcik on the link to show contextual menu and click on middle icon. Link attributes will be available in the poput that'll appear.
We'll update the feature guide with info about that change.

404 on translation download won't have any negative impact to the editor. I suppose markdown plugin does not have translations at all. We'll check it and disable translation downloading for that plugin.

I have created a local environment with PHP 8.3.4 and the issue is still not reproducable for me - tested both on latest (1.4.0) and 1.2.2 versions of Plugin Pack.

Ok, closing then. Thanks for the info.

Hi Stephen

Is there any error in th developer console on souce editing enable?
I have tried to reproduce the issue - tested a field with 17892 words and 120372 characters and so far everything is working fine.
In your case is it that you cannot scroll to the bottom or content looks chopped at the bottom?

Yes, that one is for CKEditor 4

CKEditor 5 also has something similar: https://ckeditor.com/docs/ckeditor5/latest/features/media-embed.html
We didn't thought abut that so far as Drupal has own Media system with option for external sources. Hower I can imagine that someone would prefer simple "copy a link" embedding method.
We'll take a loot at this plugin's integration. I cannot provide any ETA at this moment though.

Hi,

There is a AutoLink plugin for CKEditor 5 and it looks like it's missing in Drupal.
Please check out the demo page: https://ckeditor.com/docs/ckeditor5/latest/features/link.html#autolink-f... - does it meet your needs?

How would I use Composer to uninstall CKEditor 5 Full-screen Mode (legacy) specifically and not the entire module?

That is not possible. The legacy module is a submodule of Premium Features, while the new one is within a Plugin Pack.
Updating both our modules should result with "CKEditor 5 Fullscreen" in a "CKEditor 5 Plugin Pack" package and "CKEditor 5 Full-screen Mode (legacy)" in a "CKEditor 5 Premium Features" package in the Extend page.

I'll try to check the process again, the error message would be helpful anyway.
Which Drupal version did you have before and after rhe update?

Hi Josh

Thank you for the feedback.
The problem with automatic text formats update is that it would need to work only in case when Drupal is also updated to 10.5/11.2 (Official Fullscreen plugin requires CKEditor 5 v45.0.0)

Run update -W and cry

By -W flag I assume it is about Composer, can you share the command output? I didn't thought that composer update may fail due to change of Fullscreen module. I've made a test update with composer after the release and didn't had any issue.

We're marking as postponed for now. Form is compatible with Key → module which allows to store config values outside the database at all. There is also possiblity to enter the values in settings.php file.

Closing as works as designed as there seems nothing to do on our side.

Added menu link

Added menu link

Added menu link

Added info about deprecation

Switched position of image and list

The following reason prevents Ckeditor 5 Inline Styles from being uninstalled:

Go to the Full HTML text format configuration, remove Inline Styles form the Active Toolbar, and in Filers section disable the inline styles checkbox. Save the text format and then you'll be able to uninstall the module.

As for the error - it is displayed in the browser's console (click right mouse button, select "Inspect" and then "Console" tab). You can report that error in that module issues.

Ah, and you can re-enable the JS aggregation.

I have reproduced your configuration with Ckeditor5 Inline Styles
If your console output is same as on the screenshot, then it is a Ckeditor5 Inline Styles issue. After update to Drupal 10.5 (which comes with CKEditor 5 v45.2.0) some of modules may have an incompatibility issues.

Hi @fred_k

This is some error on editor initialization. I'll need more info to determine what is going wrong.
Please disable js aggregation at /admin/config/development/performance then enter node edit page opten the browser's console and provide content of the console.

Hi Jen

We're integrating only the official CKEditor 5 plugins and for now Link Decorators are only non-contrib way to add attributes to links in CKEditor 5.
I agree that it would be great to have such functionality, but for now the Editor Advanced link will remain as the solution for your needs.
I'm marking this ticket as works as designed, but if there will be an official CKEditor 5 plugin that allows manual attribute editing, we will for sure add it.

We have released new versions of our modules in which required third party dependencies were changed to suggestions.

We have released CKEditor 5 Plugin Pack v1.4.0 with an official CKEditor 5 Fullscreen plugin. We have tested it with Layout Builder and reported issue does not occur there.

Fullscreen mode module which is part of Premium Features module is now deprecated. That plugin was created specifically for Drupal after we introduced two sidebars in the Premium Features, making editing almost impossible in Drupal (due to limited space). The new plugin is available for all CKEditor 5 implementations, now including Drupal.

The new CKEditor 5 Fullscreen module requires Drupal 10.5+ or 11.2+ due to requirement of CKEditor 5 v45.0.0 or higher.

Hi @sirclickalot
We have released CKEditor 5 Plugin Pack 1.4.0 and CKEditor 5 Premium Features 1.5.0
In the Premium Features module we have changed dependency requirements to suggestions, so it sould now install without conflicts with AI suite.

We have released CKEditor 5 Plugin Pack 1.4.0 and CKEditor 5 Premium Features 1.5.0
In the Premium Features module we have changed dependency requirements to suggestions, so it installs without problem on Drupal CMS
The WProofreader fix is also released with that version.

We have released CKEditor 5 Plugin Pack → v1.4.0 with an official CKEditor 5 Fullscreen plugin. We have tested it with Layout Builder and reported issue does not occur there.
Fullscreen mode module which is part of Premium Features module is now deprecated.

The new CKEditor 5 Fullscreen module requires Drupal 10.5+ or 11.2+ due to requirement of CKEditor 5 v45.0.0 or higher.

We have released CKEditor 5 Plugin Pack → v1.4.0 with an official CKEditor 5 Fullscreen plugin which comes with automatically translated labels.
Fullscreen mode module which is part of Premium Features module is now deprecated.

The new CKEditor 5 Fullscreen module requires Drupal 10.5+ or 11.2+ due to requirement of CKEditor 5 v45.0.0 or higher.

Version 1.5.0 has been released. All third party dependencies are now optional.

Fix has been released in version 1.5.0

In case you use some of premium plugins other than WProofreader please note that we changed our third party composer requirements to suggestions. Depending on used features some packages may need to be manually installed after update to version 1.5.0.
More info here →

Code was merged and released in version 1.5.0

In case you use some of premium plugins other than WProofreader please note that we changed our third party composer requirements to suggestions. Depending on used features some packages may need to be manually installed after update to version 1.5.0.
More info here →

CKEditor 5 Premium Features 1.5.0 and CKEditor Plugin Pack 1.4.0 are released.
We advise all Drupal 10.5+ and 11.2+ users to switch to the new plugin.

Added the optional composer depenencies section

Pushed:

• build without console.log
• sources form https://github.com/WebSpellChecker/wproofreader-ckeditor5 (we use that one, not wscbundle)
• old build for compatibility with CKEditor 5 older than v41.0.0
• hook_library_info_alter implementation to change to old build file reference in case it is needed

Not sure how this log ended there. It's not in the sources and I do not remember adding it manually (however this seems most probable).

We're planning to release it tomorrow.

salmonek → created an issue.

@aitala
Please try updated patch (cache rebuild required)

@carolpettirossi
Exactly as @chike said premium_features is a dependency for a plugin_pack. In case of Plugin Pack WProofreader installation also PF WProofreader is being enabled and the script is there, thus the patch is for Premium Features module.

The patch for WProofreader has ben posted here 🐛 WProofreader Plugin Issue Active

Hi,
The error is a result of WProofreader plugin incompatibility with latest CKEditor 5 version (v45).
Attaching a patch with an updated WProofreader version. The patch has to be applied on drupal/ckeditor5_premium_features

Hi Ferdinand
The installation issue will be fixed in the next release (targeting next week). The WProofreader issue is not related to the installation issue, it's a incompatibility issue of WProofreader script and new CKEditor 5 (v45.x.x). I'll post a patch with updated WProofreader script later today.

Hi Lorenzo

That is right. That's because Bookmarks were introduced to CKEditor without linking support at first. The feature is available since CKEditor 5 v45 which will be available in Drupal 10.5/11.2
Additionally v45 is incompatible with Image and Media upload plugins, so we didn't add that version in the Version Override module.

Moving to RTBC, will be released in next version.

Released in 1.3.2

Released in 1.3.2

The related issue which fixes that one too was released in 1.4.2

Released in 1.4.2

Tested by our QA team. Released in 1.4.2

Tested by our QA team. Released in version 1.4.2

@revathidinesh

Please try updated patch. I have updated js adapter file, so cache rebuild is required in case JS aggregation is enabled.

Reviewed, to be released in next version.

salmonek → made their first commit to this issue’s fork.

Added MR that removes required attribute on license key and cloud credentials fields.

salmonek → made their first commit to this issue’s fork.

Pushed few updates:

• a valid service id confirmation message
• service id validation on submit is always omitted in case on premise type is selected

The submit button will be always enabled. There is a service id validation on submit anyway so it was not that necessary.
Required state for service id is conditional.

Hi Revathi

Thank you for bringing this issue to our attention.
I've posted a patch that makes Service ID not required when on-premises is selected and prevents validation error on submit.
This should work for you already. We'll take a deeper look at the settings form before merging the fix.

salmonek → made their first commit to this issue’s fork.

Hi David

I tried to reproduce and result was same for Full and Basic HTML.
Can you share HTML source (using browser Dev tools on node view page) for both formats? Checking HTML using source plugin in the editor itself is also worth a try.

Additionally please list filters used in both text formats.

I don't think we'll be adding it to the Plugin Pack.
We're focusing on the CKEditor functionalities. HTML filter is editor agnostic so it seems out of scope of the module.
It looks like there is already a module that provides a HTML filter with style support: https://www.drupal.org/project/extended_html_filter →

Hi Daniel, thank you for feedback.

There is mention about that incompatibility in the font family section - https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →
That may be indeed a bit unfortunate in case someone is not interested with font family. We'll move that higher in the font section.

If you would like to use font colors with HTML filter please check out highlight plugin. The "pen" type changes the font color using classes.

Looks like a result of breaking change in CKEditor 5 v45.0.0:

All CKEditor 5 icons are now available in the @ckeditor/ckeditor5-icons package.

https://ckeditor.com/docs/ckeditor5/latest/updating/guides/changelog.htm...

That's an issue of a position: absolute; element inside a overflow: hidden; container. Similar to this https://front-back.com/how-to-make-absolute-positioned-elements-overlap-... but much more complicated. For the dropdown bar a relative element is a hamburger button in primary bar and the overflow: hidden; elements are much higher in the DOM tree.

The sticky toolbar is on the other hand a position: fixed; element so it is not contrained by parents with overflow: hidden;

There is a related issue on CKEditor's github, but unfortunately "Open". There is a workaround, but works only with chromium browsers: https://developer.mozilla.org/en-US/docs/Web/CSS/anchor-name

I wonder if there is a possibility to write a custom plugin that will make the toolbar fixed by default and calculate the proper position relative to the hamburger.

BTW there is same issue for layout builder: https://www.drupal.org/project/drupal/issues/3328095 🐛 CKEditor 5 toolbar overflow can become unusable in Off canvas Needs review