🇵🇱Poland @salmonek

The fix has been released in previous (1.2.2) release.
Thank you for the contribution.

@damienmckenna
We're using company repositories for tickets requested by management and bugs reported by QA since people across organization have access there and are familiar with it. In this module we will operate more on Drupal repositories as the internally induced work is mostly done.

The configuration guide has been updated. There is information about all plugins having their sub-modules at the beginning plus each section contains info which module (with it's machine name) to enable.
https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →

Removed the duplicate Link Attributes section

Added information about necessity of sub-module enabling and provided module name for each functionality including machine name as users that are enabling with drush may not be aware that there are plenty of sub-modules.

I took a look at this issue and as dolszewski mentioned currently in core the styles config option which enables list styles is set statically to false, this is same in 11.0.x and 11.1.x

There is a ticket related to this functionality: https://www.drupal.org/project/drupal/issues/3274635 ✨ [upstream] Use CKEditor 5's native and UX Needs work
I've tested patch from https://www.drupal.org/project/drupal/issues/3274635#comment-15670807 ✨ [upstream] Use CKEditor 5's native and UX Needs work on Drupal 10.3.1 and it worked fine with all Plugin Pack plugins:

Please provide info how are you setting list styles in Drupal and optionally which of Plugin Pack's modules breaks it.

Marking as postponed until upstream ticket is done.
After that we'll check if there will be something required to implement in Plugin Pack.

Merged and released in version 1.2.3
Thank you for the contribution.

Merged and released in version 1.2.3
Thank you for the contribution.

Fix released in 1.2.3 version

Since the code for full screen is within the CKEditor 5 Premium Features module (it was created before we have released Plugin Pack) the fix was released in it's 1.3.3 version (it is a dependency for Plugin Pack).

Fix released in version 1.3.3

Released in version 1.3.3
Thank you for the contribuition.

Merged and relased in version 1.3.3

@nilesh.nitsan
We tested the fix with our QA team and released in the 1.3.3 version.

salmonek → made their first commit to this issue’s fork.

salmonek → made their first commit to this issue’s fork.

Thank you @todea for reporting and fix.
I tested the fix and it will be added in next relase planned for tomorrow.

Hi @jkamizato
I wanted to take a look at this issue and I cannot reproduce it so far. However looking at the process() function code I presume that $dom->nodeValue is null when $text is empty - is that correct?
In such case we could simply add if statement at the beginning and return empty text without any processing if it is empty.

Hi @nilesh.nitsan

The issue was due to Symfony's ParameterBag->getInt() throws an exception for null value instead returning 0.
I have created merge requests which will be published with next release (probably next week). For now you can apply patch which is available by clicking "plain diff" in the merge request info box.

salmonek → made their first commit to this issue’s fork.

See Screenshot: "CKE5 Font Families configuration one line for each family"

Indeed there was a bug. I pushed fix to the issue's fork. You can download a patch by clicking "plain diff" in the branch info box.

Where can I configure the field as "Multi value field" or ...?

Structure -> Content Types -> {your conten type} -> Manage fields -> Edit (operations column related to Body field)
In the form there will be a "Allowed number of values" option where you chan select Unlimited and Limited (with specific limit number)
Please be aware that this setting will affect field across all content types where it's being used (it's possible tha you set unlimited values for other content type). And if you already have a node with multiple values for given field you won't be able to set lower limit than maximal current number of values (in a single node) stored in the database. It will be communicated with an error message similar to this "There is 1 entity with 2 or more values in this field, so the allowed number of values cannot be set to 1."

In case if you're referring to the Body field that you showed on screenshot in your previous message then it looks like you have Body set as multi value field (there is a "Add another item" button, so you can add even more field items). In that case yes - you can safely remove the empty one. If you use both there won't be conflicts as content for both items will be saved in a different rows in the database.

As for #10 issue if you configured all families in a single row separated by commas then this will be a single rule - all those values will be added as a single font-family attribute, and fonts will be prioritized to use the first one or next in order in case if previous are for some reason unavailable.
To have fonts as separate options they should be entered in new lines of the configuration field.

Hi @viniciusrp
Indeed there is a bug - we didn't add check whether permissions are enabled on access token generation.
I'm attaching a quickfix to ignore permissions on token generation, so it's only meant for applications that don't want to use them in RTC. This won't go into official release. Instead this patch I'll implement proper configuration check later.

Hi @scott_euser
Thank you for posting the solution here. We'll test this also internally and publish to the main branch eventually.

I just would like to add that after applying this patch a token endpoint is added for IfW authorization istead using license key.
This is the same authorization method as used in export modules and realtime collaboration. If you're already using any of those features then probably you won't need to configure anything.
In case you don't use exports nor realtime collaboration then probably you'll need to update license configuration → :
Authorization type: Access key
Environment ID and Access key have to be filled.
Additionally "Use premium features access token" permission has to be granted to each role that will be able to use Import from Word plugin.

Attaching updated patch.
Previous one didn't change library version, so besides cache rebuild a browser's cache flush was required.
This one requires only cache rebuild.

Hi @scott_euser
We're aware of this warning. It is being kept for backwards compatibility and as for now besides displaying warning it doesn't produce errors.
DocumentList plugin is used in Comments and Collaboration (as suggestions can be commented), it allows to add list in comment (using autoformat functionality).
In Drupal up to 10.2 with CKEditor 5 versions prior to 41.0.0 there were available plugins DocumentList and List (incompatible with Drupal's core CKEditor 5 build).
CKEditor 5 v41.0.0 (v41.3.1 is in Drupal 10.3) changed the plugin names:
DocumentList -> List
List -> LegacyList
DocumentList became obsolete, but sill an alias for List

The problem with changing plugin used in the module to List would be that for sites using Drupal prior to 10.3 it would mean to change to unsupported plugin.
So up until DocumentList is kept as alias (or we'll gain info that it causes some error), we'll be willing to not put that change into official release.
In case you would like to get rid of that warning I'm posting a patch that is compatible with Premium Features v1.3.2 which chnages the plugin.

I'll set the status to postponed. We can close after chnage will land in official release.

Hi @leeksoup
All CKEditor 5 plugins within Plugin Pack are organized with sub-modules. ckeditor5_plugin_pack itself only provides some common functionalities without any actual plugin.
Enable the ckeditor5_plugin_pack_auto_image and you should get the tab in text format settings.

We'll think about making config guide more clear about that a sub-module should be installed.

I agree that this is important. Yet the problem doesn't seem to be within Plugin Pack.
/modules/contrib/ckeditor_font/js/ckeditor5_plugins/ckeditor5-font/build/font.js - font.js file is loaded from CKEditor Font module, which has reported issue of being incompatible with Drupal 10.3 - https://www.drupal.org/project/ckeditor_font/issues/3456088 🐛 Incompatibilidad con Drupal 10.3.0 Postponed: needs info

Please try to uninstall "CKEditor Font" module and use "CKEditor 5 Font Plugins".
In CKEditor 5 Font Plugins all plugin files are by default downloaded from CDN with version that matches main CKEditor 5 library in the Drupal Core.

Hi @kopeboy
Thank you for bringing this oversight to our attention.
Posted patch adds tags required by todo list to the "Allowed HTML tags" list.

salmonek → made their first commit to this issue’s fork.

@andreas-dvorak
Sorry for long response. I was convinced that I already did.
The font.js file which you're using comes from ckeditor_font module. It was built using older CKEditor 5 version and is incompatible with CKEditor in Drupal 10.3.
You can use Fonts sub-module of CKEditor 5 Plugin Pack instead (You'll need to configure colors again). With Plugin pack you'll get always font plugin in version that matches version of CKEditor 5 in the Drupal Core you're using.

Glad to be of help.
I'm marking this as working as designed since CKEditor 5 currently doesn't have dedicated plugin for editing div's.
Once this functionality will be available (and won't go into core), we'll most probably will add the integration.

Hi @christopheklein
Thank you for the info and patch.
I didn't reproduce the issue on my dev env, however the patch is straightforward.
I extended it with EntityTypeManager to EntityTypeManagerInterface change.

salmonek → made their first commit to this issue’s fork.

Hi @bkosborne
Thank you for noticing and patch. Merged and will be released in next version.

salmonek → changed the visibility of the branch 3478384 to hidden.

salmonek → made their first commit to this issue’s fork.

Tested and applied @daspeter suggestion then merged.

If plugins is always an array if set the following probably could work too:

Yes, $editorSettings["plugins"] is passed to the editor constructor and has to be an array (or undefined).

salmonek → made their first commit to this issue’s fork.

Realtime permissions have been released in version 1.3.2
Here → is a configuration guide for the functionality.

salmonek → made their first commit to this issue’s fork.

In version 1.2.2 we have added a new submodule - Link Attributes. Could you test it's form - it works also with AJAX I wonder if there will be same issue occuring on your dev environment.

@robbt

I have added a PR with small change that will prevent those two warnings in dblog - it's woth fixing anyway.
Ok, I just noticed that you mentioned other ticket where same issue was fixed and it didn't help, so no need to test this fork.

As of PHP version - I tested code before fixing on 8.1.29 and 8.3.11 (no FastCGI) and hadn't an AJAX error on both

I just realised that there is some kind of workaround available with "CKEditor 5 Templates" module (part of Plugin Pack).
You can define a template with code:

<div class="ck-inline-remote">
{placeholder}
</div>

Then in the editor first add that template and replace {placeholder} text with the image.
You will still need the source plugin active in order to have General HTML support plugin active.

Short configuration info for the Templates sub-module is available at: https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →
And feature guide at: https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →

Hi @senzaesclusiva

I confirm that this is a limitation of the editor. We would need a plugin allowing a div elements manipulation. for now there is only General HTML Support plugin which allows to recognize them as valid elements, but adding and editing divs is only available through source mode.

There is a issue in Drupal core related to that functionality:
https://www.drupal.org/project/drupal/issues/3418322 ✨ [upstream] [GHS] Allow CKEditor 5 support for containers: div, article, section, aside, etc. Postponed
Which depends on the CKEditor's issue:
https://github.com/ckeditor/ckeditor5/issues/6462

@juc1
In the version 1.2.2 of CKEditor 5 Plugin Pack we have added a "Link attributes" submodule.
It provides possibility to set link calsses similar way https://www.drupal.org/project/ckeditor_link_styles → module does, but with addition of possibility to set other link attributes.
You can find configuration guide at https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →

Hi Mateusz
This is unfortunately an editor behavior and we cannot do much within the module.
There is a related issue on CKEditor's github. Leaving a comment and/or upvote may help a little bringing this issue to active works https://github.com/ckeditor/ckeditor5/issues/5752

The TypeError: r.Model is not a constructor seems to be key issue here. Drupal 10.3 came with CKEditor 5 version that introduced some backwards incompatibilities. This error may occur when incompatible (older) version of some plugin is used. In your situation it is font.js file.

By default Plugin Pack is dwnloading compatible versions of required plugins from CDN, but we allow to set plugins directory manually at /admin/config/ckeditor5-plugin-pack. Do you by any chance have set some local directory for CKEditor plugins?

If not then please tell what is the source of font.js file (full url should show when you hover over the file name in the developer console).

Added RTC permissions section

Added link attributes configuration

Hi @robbt
On clean install we haven't spottend this issue so far.
Are there any errors apearing in the dblog after the AJAX error has been shown? Those (if present) should me more informative on what is the actual cause.

Hi @andreas-dvorak
Is there anything in the browser's developer console?
Can you tell what are the other contrib (or custom) plugins that you use in Full HTML?

Hi @kwfinken
Thank you for reporting this issue.
We decided that apart from testers trying to break things, a negative value will be mostly a result of misclick and got with solution that an absolute value will be used in such case. Fix was released in version 1.2.2

@vipul-tulse

The option to change UI type for Find and Replace has been released in 1.2.2 The option is available withtin text format settings.
Now with dropdown option active the F&R dialog will be autmatically closed when switching tabs, which will help to avoid confusion.

The fix has beeen released in version 1.3.2
Thank you @alexj12 for the contribution.

The fix has beeen released in version 1.3.2
Thank you @alexj12 for the contribution.

salmonek → made their first commit to this issue’s fork.

Hi @kc-tang

Sorry for long response, I was on vacation last week.
The kopeboy's rules should work also when placed in layout.css file

Font colour uses "style" property which is filtered out by "Limit allowed HTML tags and correct faulty HTML" filter in the text format settings. It will work only without that one.

Hi @kc-tang

Thank you for your feedback, having more requests here will encourage us to reconsider possibility of adding highlight styles automatically.
In the meantime you can display various marker colors in the frontend theme by adding css rules to your theme's styles:

If you would like to use only default CKEditor 5 markers then simply add:

.marker-yellow { background-color: #fdfd77; }
.marker-green { background-color: #62f962; }
.marker-pink { background-color: #fc7899; }
.marker-blue { background-color: #72ccfd; }
.pen-red { background-color: transparent; color: #e71313; }
.pen-green { background-color: transparent; color: #128a00; }

Or since the CKEditor variables are added to frontend themes globally then you can use css rules which @kopeboy posted in the issue's description.

In case you would like to use custom colors please check our guide at https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →

Hi alexj12
Cool, thank you for another catch.

salmonek → made their first commit to this issue’s fork.

Hi @alexj12
Thank you for cathing this. Indeed it is an oversight, not design.

Hi @dadderley
Please ensure you do not have Premium Features 1.2.9 installed.
We have released version 1.2.1 of Plugin pack which has dependency on Premium Features ^1.3 which comes with the issue fixed.
In case your problem persists then it is rather not related to issue mentioned in this ticket. In such case please share your browser's developer console output - that should help us finding out reason of the problem.

Released in 1.3.1
Thank you for contribution.

Released in version 1.3.1
Thank you @nixou for contribution.

Update released in version 1.3.1

salmonek → made their first commit to this issue’s fork.

Hi @jkamizato

Sorry for long response time.
The media elements support was added in 1.2.9 release.

Thank you for the update on situation.

Cheers,
Wojtek

Hi @aitala
Did it happen just after update to 1.2.0?
We have added second argument to the constructor of SettingsConfigHandler and that argument is also added in the service definition, so the DI should pass that new argument.
Quick thought is that maybe caches weren't rebuilt after update - that would result indeed with passing only one argument through dependency injector.

@noonoos
We have released 1.2.0 version of Plugin Pack which provides ability to set local path for plugin libraries.
The guide for the configuration is available at https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →

Updated WProofreader section

@ericdsd
The configuration guide is updated:
https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →
We'd be very happy for a feedback if instructions are clear there.

line break fix

Images alignment fix

Added general configuration section

@ericdsd
I'm working on extending the installation guide. I'll try to explain the structure there, which is in Drupal for now different to the one in citation. Right now drupal uses older installation method where there is a base ckeditor.js build which contains base plugins available in Drupal core, plus every plugin we're adding in plugin pack and premium features has it's own dll .js file and have to be downloaded separately (also translations are distributed separately for each plugin).

Ultimately we're planning to extend description of the config field with information which files should be downloaded for current configuration of all CKeditor 5 text formats.

The status is indeed not appropriate for the situation, changing to fixed.
The credit for radheymkumar has been already given for this ticket.

Version 1.3.0 has been released with library version update.

Fix released in 1.3.0

Fix released in 1.3.0

@scott_euser We have released 1.3.0 with your patch. Thank you for the contribution.

@xamount today we have released 1.3.0 with updated permissions configuration for WProofreader
We had additional feedback from WebSpellChecker LLC mostly about spelling, but also about which quick actions (available bottom part of spellcheck in window) should depend on permissions.

Hi, fix has been released today in 1.3.0

Hi @josh-waihi
We're planning a release this week (Wed most probably) and the range will be changed to ^0.10.0