Hi,
There is a AutoLink plugin for CKEditor 5 and it looks like it's missing in Drupal.
Please check out the demo page: https://ckeditor.com/docs/ckeditor5/latest/features/link.html#autolink-f... - does it meet your needs?
How would I use Composer to uninstall CKEditor 5 Full-screen Mode (legacy) specifically and not the entire module?
That is not possible. The legacy module is a submodule of Premium Features, while the new one is within a Plugin Pack.
Updating both our modules should result with "CKEditor 5 Fullscreen" in a "CKEditor 5 Plugin Pack" package and "CKEditor 5 Full-screen Mode (legacy)" in a "CKEditor 5 Premium Features" package in the Extend page.
I'll try to check the process again, the error message would be helpful anyway.
Which Drupal version did you have before and after rhe update?
Hi Josh
Thank you for the feedback.
The problem with automatic text formats update is that it would need to work only in case when Drupal is also updated to 10.5/11.2 (Official Fullscreen plugin requires CKEditor 5 v45.0.0)
Run update -W and cry
By -W flag I assume it is about Composer, can you share the command output? I didn't thought that composer update may fail due to change of Fullscreen module. I've made a test update with composer after the release and didn't had any issue.
We're marking as postponed for now. Form is compatible with
Key →
module which allows to store config values outside the database at all. There is also possiblity to enter the values in settings.php file.
Closing as works as designed as there seems nothing to do on our side.
The following reason prevents Ckeditor 5 Inline Styles from being uninstalled:
Go to the Full HTML text format configuration, remove Inline Styles form the Active Toolbar, and in Filers section disable the inline styles checkbox. Save the text format and then you'll be able to uninstall the module.
As for the error - it is displayed in the browser's console (click right mouse button, select "Inspect" and then "Console" tab). You can report that error in that module issues.
Ah, and you can re-enable the JS aggregation.
I have reproduced your configuration with Ckeditor5 Inline Styles
If your console output is same as on the screenshot, then it is a Ckeditor5 Inline Styles issue. After update to Drupal 10.5 (which comes with CKEditor 5 v45.2.0) some of modules may have an incompatibility issues.
Hi @fred_k
This is some error on editor initialization. I'll need more info to determine what is going wrong.
Please disable js aggregation at /admin/config/development/performance then enter node edit page opten the browser's console and provide content of the console.
Hi Jen
We're integrating only the official CKEditor 5 plugins and for now Link Decorators are only non-contrib way to add attributes to links in CKEditor 5.
I agree that it would be great to have such functionality, but for now the Editor Advanced link will remain as the solution for your needs.
I'm marking this ticket as works as designed, but if there will be an official CKEditor 5 plugin that allows manual attribute editing, we will for sure add it.
We have released new versions of our modules in which required third party dependencies were changed to suggestions.
We have released CKEditor 5 Plugin Pack v1.4.0 with an official CKEditor 5 Fullscreen plugin. We have tested it with Layout Builder and reported issue does not occur there.
Fullscreen mode module which is part of Premium Features module is now deprecated. That plugin was created specifically for Drupal after we introduced two sidebars in the Premium Features, making editing almost impossible in Drupal (due to limited space). The new plugin is available for all CKEditor 5 implementations, now including Drupal.
The new CKEditor 5 Fullscreen module requires Drupal 10.5+ or 11.2+ due to requirement of CKEditor 5 v45.0.0 or higher.
Hi @sirclickalot
We have released CKEditor 5 Plugin Pack 1.4.0 and CKEditor 5 Premium Features 1.5.0
In the Premium Features module we have changed dependency requirements to suggestions, so it sould now install without conflicts with AI suite.
We have released CKEditor 5 Plugin Pack 1.4.0 and CKEditor 5 Premium Features 1.5.0
In the Premium Features module we have changed dependency requirements to suggestions, so it installs without problem on Drupal CMS
The WProofreader fix is also released with that version.
We have released
CKEditor 5 Plugin Pack →
v1.4.0 with an official CKEditor 5 Fullscreen plugin. We have tested it with Layout Builder and reported issue does not occur there.
Fullscreen mode module which is part of Premium Features module is now deprecated.
The new CKEditor 5 Fullscreen module requires Drupal 10.5+ or 11.2+ due to requirement of CKEditor 5 v45.0.0 or higher.
We have released
CKEditor 5 Plugin Pack →
v1.4.0 with an official CKEditor 5 Fullscreen plugin which comes with automatically translated labels.
Fullscreen mode module which is part of Premium Features module is now deprecated.
The new CKEditor 5 Fullscreen module requires Drupal 10.5+ or 11.2+ due to requirement of CKEditor 5 v45.0.0 or higher.
Version 1.5.0 has been released. All third party dependencies are now optional.
Fix has been released in version 1.5.0
In case you use some of premium plugins other than WProofreader please note that we changed our third party composer requirements to suggestions. Depending on used features some packages may need to be manually installed after update to version 1.5.0.
More info
here →
Code was merged and released in version 1.5.0
In case you use some of premium plugins other than WProofreader please note that we changed our third party composer requirements to suggestions. Depending on used features some packages may need to be manually installed after update to version 1.5.0.
More info
here →
CKEditor 5 Premium Features 1.5.0 and CKEditor Plugin Pack 1.4.0 are released.
We advise all Drupal 10.5+ and 11.2+ users to switch to the new plugin.
Pushed:
- build without console.log
- sources form https://github.com/WebSpellChecker/wproofreader-ckeditor5 (we use that one, not wscbundle)
- old build for compatibility with CKEditor 5 older than v41.0.0
hook_library_info_alterimplementation to change to old build file reference in case it is needed
Not sure how this log ended there. It's not in the sources and I do not remember adding it manually (however this seems most probable).
We're planning to release it tomorrow.
salmonek → created an issue.
@aitala
Please try updated patch (cache rebuild required)
@carolpettirossi
Exactly as @chike said premium_features is a dependency for a plugin_pack. In case of Plugin Pack WProofreader installation also PF WProofreader is being enabled and the script is there, thus the patch is for Premium Features module.
The patch for WProofreader has ben posted here 🐛 WProofreader Plugin Issue Active
Hi,
The error is a result of WProofreader plugin incompatibility with latest CKEditor 5 version (v45).
Attaching a patch with an updated WProofreader version. The patch has to be applied on drupal/ckeditor5_premium_features
Hi Ferdinand
The installation issue will be fixed in the next release (targeting next week). The WProofreader issue is not related to the installation issue, it's a incompatibility issue of WProofreader script and new CKEditor 5 (v45.x.x). I'll post a patch with updated WProofreader script later today.
Hi Lorenzo
That is right. That's because Bookmarks were introduced to CKEditor without linking support at first. The feature is available since CKEditor 5 v45 which will be available in Drupal 10.5/11.2
Additionally v45 is incompatible with Image and Media upload plugins, so we didn't add that version in the Version Override module.
Moving to RTBC, will be released in next version.
Released in 1.3.2
Released in 1.3.2
The related issue which fixes that one too was released in 1.4.2
Released in 1.4.2
Tested by our QA team. Released in 1.4.2
Tested by our QA team. Released in version 1.4.2
@revathidinesh
Please try updated patch. I have updated js adapter file, so cache rebuild is required in case JS aggregation is enabled.
Reviewed, to be released in next version.
salmonek → made their first commit to this issue’s fork.
Added MR that removes required attribute on license key and cloud credentials fields.
salmonek → made their first commit to this issue’s fork.
Pushed few updates:
- a valid service id confirmation message
- service id validation on submit is always omitted in case on premise type is selected
The submit button will be always enabled. There is a service id validation on submit anyway so it was not that necessary.
Required state for service id is conditional.
Hi Revathi
Thank you for bringing this issue to our attention.
I've posted a patch that makes Service ID not required when on-premises is selected and prevents validation error on submit.
This should work for you already. We'll take a deeper look at the settings form before merging the fix.
salmonek → made their first commit to this issue’s fork.
Hi David
I tried to reproduce and result was same for Full and Basic HTML.
Can you share HTML source (using browser Dev tools on node view page) for both formats? Checking HTML using source plugin in the editor itself is also worth a try.
Additionally please list filters used in both text formats.
I don't think we'll be adding it to the Plugin Pack.
We're focusing on the CKEditor functionalities. HTML filter is editor agnostic so it seems out of scope of the module.
It looks like there is already a module that provides a HTML filter with style support:
https://www.drupal.org/project/extended_html_filter →
Hi Daniel, thank you for feedback.
There is mention about that incompatibility in the font family section -
https://www.drupal.org/docs/extending-drupal/contributed-modules/contrib... →
That may be indeed a bit unfortunate in case someone is not interested with font family. We'll move that higher in the font section.
If you would like to use font colors with HTML filter please check out highlight plugin. The "pen" type changes the font color using classes.
Looks like a result of breaking change in CKEditor 5 v45.0.0:
All CKEditor 5 icons are now available in the
@ckeditor/ckeditor5-iconspackage.
https://ckeditor.com/docs/ckeditor5/latest/updating/guides/changelog.htm...
That's an issue of a position: absolute; element inside a overflow: hidden; container. Similar to this https://front-back.com/how-to-make-absolute-positioned-elements-overlap-... but much more complicated. For the dropdown bar a relative element is a hamburger button in primary bar and the overflow: hidden; elements are much higher in the DOM tree.
The sticky toolbar is on the other hand a position: fixed; element so it is not contrained by parents with overflow: hidden;
There is a related issue on CKEditor's github, but unfortunately "Open". There is a workaround, but works only with chromium browsers: https://developer.mozilla.org/en-US/docs/Web/CSS/anchor-name
I wonder if there is a possibility to write a custom plugin that will make the toolbar fixed by default and calculate the proper position relative to the hamburger.
BTW there is same issue for layout builder: https://www.drupal.org/project/drupal/issues/3328095 🐛 CKEditor 5 toolbar overflow can become unusable in Off canvas Needs review
Hi Daniel
I'll need nore info as we didn't had such issue before.
First please tell which plugins out od Plugin Pack selection do you use.
Second - there will be most probably a js error, so please share content of the browser developer console from after issue happens. As it is occuring on content save, please enable "Preserve log" first. This may provide enough info for us, so that will be what we need first. (Important mention - please disable JS aggregation, before collecting info from JS console)
The more detailed info, however possibly not needed at least at first - try to find out which exactly plugin causes that i.e. try to disable one after one and see after disabling which plugin the issue stops to occur. Also if you find that one please disable rest of Plugin Pack modules and check it that is solely one plugin causing problems. After that sharing your editor configuration will be helpful (editor.editor.full_html.yml in case the problems are with full html text format). If you don't use config sync folder, you can export single configuration in the admin UI.
Emoji plugin requires CKEditor 5 v44.3.0 or higher which is not yet avaialbe in Drupal Core. There is a submodule in our Premium Features called CKEditor 5 Version Override (does not require commercial license) which allows to update CKEditor 5 to v44.3.0. I've updated configuration guide with this information.
Add info about CKEditor 5 v44.3.0 requirement for Emoji plugin.
Hi Marvin
Unfortunately as for now we cannot create separate permissions for resolving own and any comment threads. Within CKEditor a permission to write comments grants also possibility to resolve all threads: https://ckeditor.com/docs/ckeditor5/latest/api/module_collaboration-core...
Hi Stephen
Right now our priorities are to bring what is available in the official plugins. With CKEditor 5 Word Count it is possible to add custom metrics, so this request should be achieveable. I suppose we will think about this once we'll be closer to clear our internal backlog.
Hi Mateusz
I've posted a fix. 403 on translation attempt was due to missing schema.
Assitionally I've altered translation routes since config translation edit forms are by default opened in modal window which was a bit too small fo HTML code field. Modal attributes are removed and edit form is opened as a regular page.
On the add/edit translation page I changed original HTML code output as it was rendering the content, while having the code to copy seems much more convenient.
salmonek → made their first commit to this issue’s fork.
I have pushed a proposed solution.
I went with solution 3 - on collaboration plugin init (content at this stage is still in the textarea) submit buttons are disabled.
Once all editors (in case multiple CKEditor fields) are ready - disabled state is removed.
The patch works wirh version 1.4.1.
Hi Diego
Thank you for reporting the issue.
It happened that there is another report for issue caused by the same function call:
https://www.drupal.org/project/ckeditor5_premium_features/issues/3512343
🐛
TypeError: Drupal\ckeditor5_premium_features\Plugin\Filter\FilterCollaboration::processWithTrackChangesData(): Argument #2 ($trackChangesData) must be of type array, null given
Active
We'll go with Marvin's patch as $trackChangesData was meant to be second argument here.
Hi Marvin
Thank you for reporting the issue. The fix is working fine.
When testing I immediatelty spotted another issue - when there is an insertion or deletion suggestion in the node, there is a Warning: Trying to access array offset on null in Drupal\ckeditor5_premium_features\Plugin\Filter\FilterCollaboration->processAttributeSuggestions() on node form submit.
I've added a fix here in issue's branch.
salmonek → made their first commit to this issue’s fork.
wim leers → credited salmonek → .
Hi @eme I'm not sure if I understood reproduction steps correctly. What I did was:
- Create a node
- Add some text without track changes
- Commented something
- Added suggestion in the comment scope
- Saved node
- Accept/refuse suggestion
Screen:
In that scenario both approve and reject worked ok.
Additionally could you please share a console log errow with JS aggregation disabled? This would help to identify one of files in trace.
Also is that happening in Realtime collaboration or Non-realtime mode?
@Wim IIRC you asked for my view on this:
⚠️Big caveat: IIRC there are problems/limitations around CKEditor 5's ability to be configured to use only inline elements — IIRC
and
are fundamentally assumed to be allowed.
Yes, by default everything must be wrapped with <p> (or <hX> or maybe some other element).
That is an implication of CKEditor 5 internal model's schema:
As per CKEditor 5 documentation:
You cannot put anything you want inside the document model. At least not until you update the schema. The schema defines what is allowed and where, what attributes are allowed for certain nodes, what is not allowed, and so on.
Schema determines things like whether the given element can be enclosed in a block quote, or whether the bold button is enabled on selected content.
https://ckeditor.com/docs/ckeditor5/latest/framework/tutorials/crash-cou...
As metioned schema can be updated. I tried this in a custom CKEditor 5 plugin:
editor.model.schema.extend( '$text', {
allowIn: '$root'
} );
$text is a any text input $root is an root of the document
By default $text is allowed among others in paragraph and that one is allowed in $root
After the schema update I think I got the result you want to implement:
Additionally I was unable to insert a new paragraph with enter key also use some plugins (lists mostly) as they most probably aren't allowed in $root:
<br> is allowed in $root and apparently there is no way to remove allowIn entry in element definition. I'll consult that with core team.
Feature has been released in 1.4.1
Fix has been released in 1.4.1
Fix has been released in version 1.3.1
Feature has been released in 1.3.1
Attaching styles has been released in version 1.3.1
Our QA team tested company dictionaries option. I have moved form element outside default settings as those are meant for Wproofreader widget settings available for editors.
Merged to 1.4.x and will be added in the next release.
salmonek → changed the visibility of the branch 1.4.x to hidden.
salmonek → made their first commit to this issue’s fork.
Attaching styles has been tested by our QA team, changes are merged and will be added to the next release.
Tested by our QA team, merged and will be added to the next release.
@francismak
No worries, despite I wasn't able to reproduce, the previous code didn't make sense, so the update is going to be released. Thank you for review.
@phjou
Since it looks like your issue is not related to the one francismak reported, please move conversation
here
🐛
Editor doesn't load with Word Count enabled and in scope of Layout Builder
Active
I added few questions there. Hopefully they will help with reproduction.
salmonek → created an issue.
Hi @dakwamine
Your request seems doable, however ther is I think easier way to remove submit than removing form wrapper. You can remove the submit button itself. For example:
function MYMODULE_form_alter(&$form, \Drupal\Core\Form\FormStateInterface $form_state, $form_id) {
if ($form_id === 'node_page_form') {
unset($form['actions']['submit']);
unset($form['actions']['preview']);
}
}
@francismak
I've created a MR with slightly updated your patch - added license info and changed library ckeditor5.basic to just
ckeditor5
Removing 'preprocess' => FALSE seems to have no effect - libraries dowloaded form external source are still in their respective files, but I've also added that change for case when libraries are loaded locally.
We would appreciate a feedback if that still fixes your issue.
@dakwamine
Are you able to share some example multi entity form for reproduction? Can be for any entity type (I'll adjust entities or form).
Hi Arnaud
Thank you for reporting this issue. As for suggested resolutions we'll probably go will 1/3.
There is some chance that someone will want to deliberately delete content, so I guess we would also need to add some checkbox "I really want to delete content"
Hi Yaroslav
Thank you for contribution. I created a branch mergeable to 1.4.x and cherry picked your commit. It'll be published in 1.4.1
salmonek → changed the visibility of the branch 1.4.x to hidden.
salmonek → made their first commit to this issue’s fork.
MR added. Patch adds an option to attach styles to all pages. It is located in text format settings in same place where custom colors are defined. On form submit if checkbox is checked there will be created a file in public:/ckeditor5/ directory.
Then when libraries are assembled for each text format having attach styling selected there will be created a dynamic css library which will be attached to every page.
A cache rebuild will be required after saving a text format, however I suppose I could add a css librsries flush in code.
@kc_tang
Sorry for long response. It's not a matter of configuration, but attaching a styles to theme. If you use bartik then indeed it is not as easy as adding styles in custom theme. It would require to add a custom css library in custom module and attach it in a preprocess function.
I'll push a MR soon which will add such option in the text format configuration.