- Issue created by @Revathidinesh
- First commit to issue fork.
- @salmonek opened merge request.
- 🇵🇱Poland salmonek
Hi Revathi
Thank you for bringing this issue to our attention.
I've posted a patch that makes Service ID not required when on-premises is selected and prevents validation error on submit.
This should work for you already. We'll take a deeper look at the settings form before merging the fix. - 🇵🇱Poland salmonek
Pushed few updates:
- a valid service id confirmation message
- service id validation on submit is always omitted in case on premise type is selected
The submit button will be always enabled. There is a service id validation on submit anyway so it was not that necessary.
Required state for service id is conditional. - 🇮🇳India Revathidinesh
@salmonek
I have used trial service id for my project with on-premise account setup for my project. Service Id I have created for cloud version using another email account
Though I use on-premise version, as it reached the trail period, now I am getting invalid service id errors in the node edit pages.
Can you please fix that as well?
- 🇵🇱Poland salmonek
@revathidinesh
Please try updated patch. I have updated js adapter file, so cache rebuild is required in case JS aggregation is enabled.
- 🇮🇳India Revathidinesh
@salmonek
I get the following error when I save the configuration form
The website encountered an unexpected error. Try again later.
ArgumentCountError: Too few arguments to function Drupal\ckeditor5_premium_features\Utility\PermissionHelper::__construct(), 1 passed in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 2 expected in Drupal\ckeditor5_premium_features\Utility\PermissionHelper->__construct() (line 32 of modules/contrib/ckeditor5_premium_features/src/Utility/PermissionHelper.php).
- 🇮🇳India Revathidinesh
@salmonek
I did what you have advised.
- I uninstalled the modules CKEditor 5 Premium Features and CKEditor 5 Premium Features WProofreader
- cleared the caches.
- Reinstalled them
- Saved the wproof reader config form with self hosted values.
Now no issues.
Thanks a lot!
- 🇵🇱Poland salmonek
Fix has been released in version 1.5.0
In case you use some of premium plugins other than WProofreader please note that we changed our third party composer requirements to suggestions. Depending on used features some packages may need to be manually installed after update to version 1.5.0.
More info here →