Unable to use Use self-hosted version endpoint with empty Service ID

Created on 27 May 2025, 7 days ago

Problem/Motivation

Unable to use Use self-hosted version endpoint with empty Service ID.
Service ID is not required for self hosted endpoint, but as the Service ID is a required field, it does't allow to save the form.

Steps to reproduce

  1. Go to WProofreader spelling and grammar checker config page
  2. Click on Advanced Settings
  3. Click on Use self-hosted version endpoint
  4. Try to save the form by keeping Service ID as empty.

Proposed resolution

When we Use self-hosted version endpoint option, hide the service ID field and allow to save the once all values are entered.

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

1.4

Component

Plugin: WProofreader

Created by

🇮🇳India Revathidinesh

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Revathidinesh
  • First commit to issue fork.
  • @salmonek opened merge request.
  • 🇵🇱Poland salmonek

    Hi Revathi

    Thank you for bringing this issue to our attention.
    I've posted a patch that makes Service ID not required when on-premises is selected and prevents validation error on submit.
    This should work for you already. We'll take a deeper look at the settings form before merging the fix.

  • 🇵🇱Poland salmonek

    Pushed few updates:

    • a valid service id confirmation message
    • service id validation on submit is always omitted in case on premise type is selected

    The submit button will be always enabled. There is a service id validation on submit anyway so it was not that necessary.
    Required state for service id is conditional.

Production build 0.71.5 2024