Hello. We are using the comments feature provided by this module. We have a page with multiple entity forms loaded. The comments work only for the first form. The other ones don't have them loaded neither saved.
The gist is to fix the commentsAdapter.js to support multiple form structure.
The problem lies mainly here (taken from the /build minified version because I have tested with this file):
const e = this.editor.plugins.get("CommentsRepository"),
t = this.editor.plugins.has("RealTimeCollaborativeComments"),
o = document.querySelector(this.storage.getSourceDataSelector("comments"));
By using document.querySelector, the script gets the first instance of the comments-data textarea.
As the forms share the same field ID, they share the same elementId. The querySelector is then not enough accurate.
I propose this change:
const e = this.editor.plugins.get("CommentsRepository"),
t = this.editor.plugins.has("RealTimeCollaborativeComments"),
o = this.editor.sourceElement.closest(".js-form-wrapper").querySelector(this.storage.getSourceDataSelector("comments"));Other places in this module could be updated in a similar approach (revisionHistory, trackChanges, etc.) to support multiple forms in the same page.
Active
1.3
Plugin: Comments
Hi @dakwamine
Thank you for bringing this to our attention.
Indeed we didn't take multiple entities on a single form into consideartion before. We'll review the solution.
@dakwamine
Are you able to share some example multi entity form for reproduction? Can be for any entity type (I'll adjust entities or form).
Closing this issue for the time being as we were not able to reproduce it.