Fullscreen button label is not translated

Created on 3 September 2024, 4 months ago

Problem/Motivation

When the Full Screen Mode is enabled and attached to a CKEditor, the label shown when hovering over the button is always "Maximize" and is not translated into the user's language.

Steps to reproduce

Assuming a standard Drupal installation, with a (interface) language that is not English and having this CKEditor 5 Premium Features available (of course):

At /admin/modules enable the CKEditor 5 Full-screen Mode module.
Edit a text format that uses the CKEditor, e.g., /admin/config/content/formats/manage/basic_html.
Add the Full Screen Mode to the active toolbar and save the configuration form.
Create a node that has a text field with support for the CKEditor, e.g., /node/add/page.
Hover over the button to enter Full Screen Mode and notice that regarding the language of the user interface, "Maximize" is shown.

Proposed resolution

If not mistaken, the Full Screen Mode plugin is solely used by Drupal, i.e., not provided via the CKEditor CDN, and therefore cannot rely on → . Therefore, we could opt to use the Drupal.t functionality (similar to the solution used by the contributed CKEditor Abbreviation module: #3439422-8: CKEditor 5: Toolbar button not translated → ).

Remaining tasks

Review merge request.

User interface changes

When a translation of the word "Maximize" is available in Drupal in the user's language, the label shown when hovering over the Full Screen Mode button is displayed in the user's language.

🐛 Bug report

Status

Needs review

Version

1.3

Component

Plugin: Full Screen Mode

Created by

🇳🇱Netherlands watergate

Live updates comments and jobs are added and updated live.

Merge Requests

!13Fullscreen button label is not translated
Open
🇳🇱Netherlands watergate
updated 4 months ago

Comments & Activities

Issue created by @watergate
Merge request !13Applied Drupal translation functionality to the full screen mode button label. → (Open) created by watergate
Issue was unassigned.
Status changed to Needs review 4 months ago7:34pm 3 September 2024
Comment 4 months ago →
🇳🇱Netherlands watergate
The proposed change has been implemented. If this merge request is approved (and included in a release), translations can be added for the word "Maximize" at https://localize.drupal.org/.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024