🇳🇱Netherlands @idebr

Update the merge request, so drupal/video_embed_field can now be installed with ^2.5 or ^3

Before

Time: 00:28.525, Memory: 12.00 MB

After

Time: 00:09.647, Memory: 12.00 MB

idebr → created an issue.

Postponed on 📌 Test with drupal/video_embed_field 3.x for Drupal 11 compatibility Active to conform tests are green on both D10 and D11

idebr → created an issue.

The merge request updates the composer package for drupal/video_embed_field to 3.x for Drupal 11 compatibility

idebr → created an issue.

I think this according to the RSS specs? See https://www.rssboard.org/rss-profile#element-channel-image

<image>
  <link>http://dallas.example.com</link>
  <title>Dallas Times-Herald</title>
  <url>http://dallas.example.com/masthead.gif</url>
  <description>Read the Dallas Times-Herald</description>
  <height>32</height>
  <width>96</width>
</image>

📌 Implement js- prefix for linkit textfields to separate JavaScript behavior from styling Needs review essentially does the same, but without duplicating Claro CSS

This issue was fixed in Drupal Core, see 📌 Add aria-current attribute to navigation items RTBC

There is an earlier issue for concurrent tests available at 📌 Enable concurrent phpunit Active that needs work.

I'll close this issue as a duplicate, so we can focus our efforts in the related issue.

MR 10182 implements an alternative solution where the code ends up as follows:

        $form['parent']['akey']['asubkey'] = [
          '#type' => 'text_format',
          '#title' => $this->t('Subkey title'),
          '#format' => $this->config('mymodule.settings')->get('akey.asubkey.format'),
          '#config_target' => "mymodule.settings:akey.asubkey",
        ];
  

I'm not sure ConfigTarget was intended to control any element property other than #default_value when reading the change record at https://www.drupal.org/node/3373502 →

Another interesting follow-up where a config value has to be mapping to multiple element properties: 🐛 Two #config_targets error when used on a text_format form element Active

idebr → made their first commit to this issue’s fork.

Postponed on ✨ Add a status/published field in a consumer Needs review

The 6.x branch is not currently under development.

phpcs fails in the MR

The merge request updates thephpleague/oauth2-server to 9.0.x

Breaking changes are listed at the release page https://github.com/thephpleague/oauth2-server/releases/tag/9.0.0, but most notably:

1. New: Strict typing and return types
2. Changed: some exceptions return a different status code and the error message data structure has changed
3. Refresh token scopes are now finalized again, so any invalid scopes are removed (this was the last test failure in #4)

Seems fine to include in the module's beta phase, but this is up to the module's maintainer

One test failure remaining

idebr → made their first commit to this issue’s fork.

This was fixed in 📌 Switch GitLab CI configuration to the template developed by the DA Fixed

The phpstan pipeline is now fixed, but one test is now failing. Oddly enough it doesn't fail on my local machine.

The merge request fixes the check added in 🐛 Duplication for Empty Fields Active , so text extractions are correctly added to files index

idebr → created an issue.

The merge request removes the legacy ckeditor from the codebase

The eslint stage still needs work to match Drupal Core's JavaScript code style

idebr → made their first commit to this issue’s fork.

idebr → made their first commit to this issue’s fork.

This issue was fixed as part of ✨ Drupal 11 compatibility fixes for webform Needs work

It can probably be closed as a duplicate

The merge request implements a Drupal.theme function that themes can use to override the View password toggle element markup.

Documentation JavaScript theming is available at https://www.drupal.org/docs/drupal-apis/javascript-api/theming-in-javasc... →

idebr → made their first commit to this issue’s fork.

I'll close this issue as a duplicate, so we can focus our efforts in the related issue

idebr → changed the visibility of the branch 2881776-consider-implementing-per-bundle_8x-14 to hidden.

The new MR34 did not merge all 8.x-1.x changes correctly. I updated the original MR10. The automated tests are green again.

idebr → made their first commit to this issue’s fork.

Drupal 9 is no longer supported. Can you reproduce this error on a supported Drupal version? See 📌 Raise minimum Drupal version to 10.2 Active

Updated the merge request:

1. Modernized the drush command with attributes
2. Removed the drush.services.yml as this is longer used in Drush 12+
3. Fixed compatibility with Drupal 11 so PHPUnit runs correctly
4. General code cleanup

idebr → made their first commit to this issue’s fork.

@chesn0k The code is tested automatically with lcobucci/jwt (5.4.0), see https://git.drupalcode.org/project/simple_oauth/-/jobs/3144336
Can you post the exact error message?

Since this issue is already available in the latest release, I suggest creating a new issue.

#1988968: Drupal.ajax does not guarantee that "add new JS file to page" commands have finished before calling said JS → has been fixed in Drupal core, so this issue is no longer postponed.

Note the module might become incompatible with Drupal 9 just by implementing D10+ coding standards, for example see the Domain module: 🐛 The website encountered an unexpected error. Please try again later. Active

If you want to explicitly support Drupal 9 (and thus PHP7), better test for it.

I'd argue explicitly supporting the lowest supported Core version according to https://endoflife.date/drupal ends up a much smoother experiences for developers as you don't get incompatible updates through composer.

The minimum core_version_requirement was never formally raised, I opened a new issue at 📌 Raise minimum Drupal version to 10.2 Active to update the info files

The merge request implements a minimum Drupal version of 10.2, as this is the lowest version still receiving security support. See https://endoflife.date/drupal

idebr → created an issue.

Drupal 9 is end of life as of November 1st 2023, see https://www.drupal.org/about/announcements/blog/drupal-9-is-end-of-life →

No need for modules to support a Drupal version that is end of life.

1. Drush 12 is the lowest supported version as the module currently supports Drupal ^10.2, see https://www.drush.org/13.x/install/#drupal-compatibility
2. Removed the drush.services.yml as it is no longer used in Drush 12
3. Updated SimpleOauthCommands to use CLI attributes and autowiring

idebr → made their first commit to this issue’s fork.

Added a merge request with the change suggested in #2. The change is in line with the change record at https://www.drupal.org/node/3375748 →

The minimum Drupal version is already at ^10.2, so no backwards compatibility addition required.

Confirmed the issue on a Standard Drupal 11.0.x install at /admin/structure/types/manage/article/fields/add-field

Related change record: https://www.drupal.org/node/3375748 →

idebr → made their first commit to this issue’s fork.

idebr → made their first commit to this issue’s fork.

The merge request adds a Gitlab CI setup based on the default template, see https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c...

idebr → created an issue.

The 'Role delegation' module recently removed access to user/*/roles, see 📌 Roles tab is redundant for users who can administer users Fixed

The merge request fixes the phpstan issues reported in the Gitlab CI pipeline

I have tagged a new beta release with Drupal 11 support. The roadmap for a stable release is available at #3303859: [META] Roadmap for AJAX Comments 8.x-1.0 →

idebr → created an issue.

This issue was reported earlier in 🐛 Cannot output domain source in content view - buildUrl() on null Active . I'll close this issue as a duplicate.

The merge request adds a function return type for DomainTestBase::drupalUserIsLoggedIn and fixes the PHPUnit tests for the next major Drupal version

The changes in the merge request fix the newly reported phpcs issues

idebr → created an issue.

idebr → created an issue.

Removed references to drush services files from composer.json

• Moved the patch to a merge request
• Fixed the remaining phpcs issues, most done automatically though phpcbf

idebr → created an issue.

Updated the MR with the latest changes in 8.x-1.x

idebr → changed the visibility of the branch 3300631-cache-metadata to hidden.

idebr → created an issue.

idebr → created an issue.

Linking the related issue in the Gin theme

Added a test for the happy path for a request with a scope 'openid'

idebr → made their first commit to this issue’s fork.

📌 Configure use-statement sniff to be case sensitive Active is done

idebr → made their first commit to this issue’s fork.

1. Branch is again up-to-date with 11.x
2. Fixed new test failures / cspell reports / coding standards
3. Fixed merge conflict in system.install

idebr → made their first commit to this issue’s fork.

This was fixed in 📌 Configure and fix PHPStan issues Fixed

This was fixed in 📌 Configure and fix PHPStan issues Fixed

Fixed the autowring for the lock service. For reference see 📌 Automated Drupal 11 compatibility fixes for content_lock Fixed

idebr → made their first commit to this issue’s fork.

greggles → credited idebr → .

The TempStore implementation of "view mode" is problematic: it is saved per entity type, but fields may be configured differently per bundle / field.

The approach in ✨ Don't rebuild the entire comment field/thread when posting a comment Needs work is to add / update / delete only the changed parts of the comment thread using deterministic HTML ids similar to how the module worked in D7. This approach should make the module a lot less complicated and allow it to work for different view modes and in Views listings.

Feel free to continue this issue, but it is unlikely to be committed with the current approach.

Similar to 🐛 Ajax not working when using non-default view mode. Needs work the TempStore implementation of "view mode" is problematic: it is saved per entity type, but fields may be configured differently per bundle / field.

Actionable points:

1. Using sufficiently unique html ids removes the need for using the TempStore, see 🐛 Having the same type of entity on one page with comments enabled breaks the HTML ID uniqueness of the wrapper RTBC . This essentially reverts #2743739: Allow multiple comment fields on the same page →
2. All code in ajax_comments_form_comment_form_alter should be moved to the \Drupal\ajax_comments\Form\AjaxCommentsForm, since Ajax Comments takes direct control of the form.
3. Attaching the ajax_comments library should be implemented through hook_preprocess_field instead of ajax_comments_entity_view_alter(), see https://www.drupal.org/node/2130757 →
4. Replacing the pager should preferable be done in a follow-up to reduce the cognitive load of this issue

Test coverage is available, see https://git.drupalcode.org/project/drupal/-/blob/d7b77f1cb94fa938ab984e2...

Considering the Ajax dialog is already active for many sites (see Problem/Motivation), the disruption is minimal.

Conceptually this approach is better than the current indeed. However, it does not solve 🐛 Ajax not working when using non-default view mode. Needs work where multiple comments threads are active on the same page.

I'll start working on some test coverage for 🐛 Ajax not working when using non-default view mode. Needs work first.

@KlemenDEV The broken styling is probably caused by the timing of attaching assets. Claro experienced a similar issue, see 🐛 Claro low contrast for buttons in dialog Fixed

As a workaround, I have included the core/drupal.dialog.ajax in ajax comments library as part of 📌 Fix failing PHPUnit test Fixed . Any custom styling should now take precedence again. Let me know if you any further help bugfixing this issue.