Account created on 29 March 2012, over 13 years ago
#

Merge Requests

More

Recent comments

🇳🇱Netherlands idebr

The merge request removes code duplication from DomainListBuilder

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

The merge request is updated with a sort by SORT_KEY for Drupal versions before 10.4.

The call to version_compare is a reminder the statement can be removed once 10.4 is no longer supported by Domain

🇳🇱Netherlands idebr

The merge request implements autowiring for services

🇳🇱Netherlands idebr

The merge request implements EntityListBuilder::getEntityListQuery to alter ListBuilder queries

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

The merge request removes ControllerBase for complex use cases

🇳🇱Netherlands idebr

A follow-up to remove ControllerBase for complex use cases is available at #3554044: Remove ControllerBase for complex use cases

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

It does, the Drush commands for the Domain module were updated in a similar way in 📌 Fix phpstan issues in DomainCommands Active

See Drush compatibility table: https://www.drush.org/13.x/install/

🇳🇱Netherlands idebr

Controllers that extend ControllerBase cannot promote the properties defined in ControllerBase.

The documentation for ControllerBase suggests it is used for simple cases only, so it might be worth dropping the base class to improve maintainability. Maybe in a follow-up issue?

🇳🇱Netherlands idebr

Turns out a route alias is Drupal 11.x only

The cancel URL is restored in the delete form, so no route changes are required.

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr
🇳🇱Netherlands idebr

This issue is available in release 8.x-1.0-beta7, see https://www.drupal.org/project/ajax_comments/releases/8.x-1.0-beta7

🇳🇱Netherlands idebr

I believe it is intentionally that file entities don't have canonical route.

As @berdir mentioned in comment https://www.drupal.org/project/drupal/issues/2345761#comment-13180034

files will IMHO remain second-class citizens and we will not introduce an actual canonical route in core, and we decided against having one that points to the physical file.

See also 🐛 File delete form throws UndefinedLinkTemplateException without destination parameter Active

🇳🇱Netherlands idebr
🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

Committed, thanks!

🇳🇱Netherlands idebr

The test assertion with the successful deletion message has been updated in the merge request

🇳🇱Netherlands idebr

The merge request implements the following changes:

  1. The domain delete form is now generated through \Drupal\Core\Entity\EntityDeleteForm
  2. The entity.domain.collection route is added as an alias of domain.admin to match the expectations of \Drupal\Core\Entity\EntityDeleteForm

Before

After

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

The merge request implements the following changes:

  1. DomainAliasCommands is moved to the Drush\Commands namespace
  2. Its construction parameter are now autowired, removing the need for drush.services.yml
  3. Fixed a missing parent::construct() call
🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

The merge request implements constructor property promotion to reduce boilerplate

🇳🇱Netherlands idebr

Strictly speaking the phpcs violation is out of scope, since it fails due to a recent change in Drupal Core, see 🐛 Typo in WidgetInterface.php Active

However, since the change is trivial enough, I'll include it here

🇳🇱Netherlands idebr

The merge request implements the following changes:

  1. .travis.yml is removed
  2. Obsolete define_subdomains.sh script for drupal CI is removed
  3. References to these files are removed
🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

Babel Webform Install (Drupal\Tests\babel_webform\Kernel\BabelWebformInstall)
✘ Install

├ LogicException: The hook update_dependencies on class Drupal\webform\Hook\WebformInstallUpdateHooks does not support attributes and must remain procedural.

│ /builds/project/babel/web/core/lib/Drupal/Core/Hook/HookCollectorPass.php:671
│ /builds/project/babel/web/core/lib/Drupal/Core/Hook/HookCollectorPass.php:476
│ /builds/project/babel/web/core/lib/Drupal/Core/Hook/HookCollectorPass.php:402
│ /builds/project/babel/web/core/lib/Drupal/Core/Hook/HookCollectorPass.php:138
│ /builds/project/babel/vendor/symfony/dependency-injection/Compiler/Compiler.php:73
│ /builds/project/babel/vendor/symfony/dependency-injection/ContainerBuilder.php:826
│ /builds/project/babel/web/core/lib/Drupal/Core/DrupalKernel.php:1397
│ /builds/project/babel/web/core/lib/Drupal/Core/DrupalKernel.php:916
│ /builds/project/babel/web/core/lib/Drupal/Core/DrupalKernel.php:829
│ /builds/project/babel/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:729
│ /builds/project/babel/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:320
│ /builds/project/babel/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:229
│ /builds/project/babel/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
│ /builds/project/babel/modules/babel_webform/tests/src/Kernel/BabelWebformInstallTest.php:37

ERRORS!
Tests: 1, Assertions: 0, Errors: 1, PHPUnit Deprecations: 2.

This was fixed in 📌 LogicException: The hook update_dependencies does not support attributes Active

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

The merge request reports a finding in phpcs

🇳🇱Netherlands idebr

There is an older issue available to fix phpcs, see 📌 Coding standard issues Active .

I'll close this issue so we can focus our efforts in the related issue

🇳🇱Netherlands idebr

MR19 branch target is 9.x and builds on the pipeline added in 📌 Introduce tests for module and configure pipelines Active

The file changes in src/Feeds/Target/YearOnly.php are due to the line endings switching from CRLF to LF

🇳🇱Netherlands idebr

idebr changed the visibility of the branch 3473443-coding-standard-issues to hidden.

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr
🇳🇱Netherlands idebr

What composer command are you running? drupal/commerce_autosku does not require any specific version

🇳🇱Netherlands idebr

Changes for Drupal 11 are available in the 3.0 beta, but no stable release yet. I don't see any blocking issues, so this might just be an administrative task?

🇳🇱Netherlands idebr

The change works as expected, thanks!

The CountryPathDomainListBuilder is no longer used and can be removed

🇳🇱Netherlands idebr
🇳🇱Netherlands idebr

Thanks, composer.json is sufficient to manage the domain package version

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

The cspell job reports a number of unrecognized words, one of them is "certinaly". Let's fix the other words as well.

🇳🇱Netherlands idebr

Why would you add max-age 0 when expires is expired? It will not update until the config is changed.

🇳🇱Netherlands idebr

Two things are currently missing:

  1. The development branch is not listed on the project page, compare https://www.drupal.org/project/webform_iban_field vs https://www.drupal.org/project/role_test_accounts
  2. Version 2.x cannot be selected in the issue queue

Both things can be fixed with the instructions in #4

🇳🇱Netherlands idebr

Looks good now, thanks!

🇳🇱Netherlands idebr

https://www.drupal.org/project/webform_iban_field has a link 'Add new release'. Here you can select 2.x as a development branch

2.x-dev is not necessary and can be removed

🇳🇱Netherlands idebr

The test is fixed now

🇳🇱Netherlands idebr

The merge request implements the following changes:

  1. Added a gitlab-ci.yml template, see https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c...
  2. The test is placed in the tests directory, so it is picked up by gitlab CI
  3. Added the webform dependency to composer.json
  4. Fixed the order of arguments for assertEquals()
  5. Added a void return type to the test method
🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

The eslint pipeline job still reports lint errors, see https://git.drupalcode.org/issue/paragraphs-3138762/-/jobs/6543959

🇳🇱Netherlands idebr

This issue was fixed in 🐛 Export single simple configuration name has no empty value, resulting in confusing UI RTBC . I'll close this issue as a duplicate

🇳🇱Netherlands idebr

The indentation change for composer.json is incorrect: composer.json uses indent_size 4. See for reference https://git.drupalcode.org/project/drupal/-/blob/11.x/.editorconfig?ref_...

🇳🇱Netherlands idebr

Functionally this is working great! I'll open a 2.x branch so this module can implement breaking changes for existing installations.

Some remarks:

  1. Do we still need the TempStore for saving selectors? Since these are now determined through the commented entity and the field name
  2. Let's use the native Element scrollIntoView for the ajaxCommentsScrollToElement command, see for reference https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView and https://git.drupalcode.org/project/drupal/-/commit/e1c818c662f8c0c6a1dc8...
  3. Can the highlight part of ajaxCommentsScrollToElement be called with ajaxCommentsHighlight so each command has a unique responsibility?

Further cleanup can be done in followups.

🇳🇱Netherlands idebr

@jsacksick can you tag a patch release with this fix to prevent updated sites from displaying this error on the status page?

🇳🇱Netherlands idebr

Inline Entity Form uses the RenderArrayTool Library for this, see https://www.drupal.org/project/rat

Specifically, see https://git.drupalcode.org/project/rat/-/blob/1.0.x/README.md?ref_type=h...

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

This is being fixed in 🐛 Country path not managed in domain navigation block Needs work

I'll close this issue as a duplicate, so we can focus our efforts in the related issue

🇳🇱Netherlands idebr

The merge request updates the ContentTranslationController to add the new translation to a clone of the entity in the route, so access checks for the language switch links pass.

🇳🇱Netherlands idebr
🇳🇱Netherlands idebr
🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

MR updated after 📌 Fix LongLineDeclaration in Functional tests Active was commited

🇳🇱Netherlands idebr

@catch I assume this issue can be marked as fixed? Its status is currently still 'RTBC'

🇳🇱Netherlands idebr

The merge request implements the following changes:

  1. The configuration is now saved through the #config target property, see https://www.drupal.org/node/3373502
  2. Validation is now done through config schema instead of form validation
  3. Cache invalidation is now done through a config listener instead of form submit
🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

@loze thanks for continuing to work on this. I'll do an in-depth review later this week.

🇳🇱Netherlands idebr

Not sure Drupal can actually do anything to prevent the double header being emitted.

It can, and it does (for X-Content-Type-Options), see https://git.drupalcode.org/project/drupal/-/blob/11.x/.htaccess?ref_type...

🇳🇱Netherlands idebr

This option is available through Search API's query option 'Skip item access checks', see #2470914: Add Views support for individual fields

🇳🇱Netherlands idebr

#62 is now available as a merge request

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

🐛 Submitting a comment in the non default language redirects you to the default language Needs work is now postponed on this issue.

Updated the issue summary from a question to a statement

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

idebr changed the visibility of the branch 10.2.x to hidden.

🇳🇱Netherlands idebr
  1. Follow-up is no longer applicable since the changed code was removed earlier.
  2. Removed remaining tasks from the issue summary as they are no longer applicable
  3. Added assertion to check the comment is visible on the page to prevent a regression in UX (see #69). This assertion will keep failing until 🐛 Comments created in translation are displayed only for admin role Needs work is fixed

As a result, this issue is now postponed on 🐛 Comments created in translation are displayed only for admin role Needs work

🇳🇱Netherlands idebr

This was suggested before #2908899: Wrong configuration schema for block_settings.label_display property and subsequently closed because it would be counter-productive for Add option for visually-hidden block titles Needs work

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

The merge request ensures the translator is set when translating documents, similar to translating text.

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

The merge request implements the life cycle for translated documents

I'll look into the phpstan findings when 📌 Fix code quality issues Active is fixed

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

Based on the issue summary, comments and related issues the immediate problem is limited to single select elements and client side validation. If I missed something, let me know and I can update the issue accordingly

Refactoring the _none value itself is being worked on in 📌 Convert '_none' option to a constant and deprecate form_select_options() Needs work

🇳🇱Netherlands idebr

idebr changed the visibility of the branch 1585930-options-module-uses to hidden.

🇳🇱Netherlands idebr

To minimize the BC break, I suggest we map the _none option to the Select #empty_option and set #empty_value to an empty string in a process callback.

This implementation allows existing options to remain unchanged; only client side logic is impacted (eg. JavaScript)

🇳🇱Netherlands idebr

DeeplTranslatorBatch:: getTranslationOptions() is a bit messy right now since the settings priority is currently not implemented (Job settings > Translator settings -> Translator plugin defaults). I filed a follow-up issue to start smoothing this out, see 📌 Provide sensible default settings Active

🇳🇱Netherlands idebr

The merge request adds default settings by implementing \Drupal\tmgmt\TranslatorPluginInterface::defaultSettings

🇳🇱Netherlands idebr

In the merge request additional values in the 'Translate content' form are saved in the Job entity.

🇳🇱Netherlands idebr

TMGMT supports translation of files on a conceptual level, see https://www.drupal.org/node/3392215

The mimetypes that should be translated can be selected at /admin/tmgmt/settings under 'File translation'

Assuming you have a working setup with nodes, you can add a 'File upload' field to the content type and check the option 'Users may translate this field' in the field settings.

Production build 0.71.5 2024