Account created on 29 March 2012, over 13 years ago
#

Merge Requests

More

Recent comments

🇳🇱Netherlands idebr

Test coverage shows the issue is fixed. Contrib tests in 🐛 Fix tests (next minor) Active are fixed as well with this change. Thanks!

🇳🇱Netherlands idebr

I filed an issue for Drupal Core: 🐛 A reverted revision is not listed on the version history Active

🇳🇱Netherlands idebr

\Drupal\node\Form\NodeRevisionRevertForm does not call \Drupal\Core\Entity\ContentEntityStorageBase::createRevision that sets the revision_translation_affected.

See \Drupal\Core\Entity\Form\RevisionRevertForm::prepareRevision for reference

🇳🇱Netherlands idebr

These test failures now affect the regular 'phpunit' pipeline step

🇳🇱Netherlands idebr

Closed as a duplicate of 🐛 Fix tests (next minor) Active

🇳🇱Netherlands idebr

Patch file for 8.x-1.x for projects running the final version of 8.x-1.x

🇳🇱Netherlands idebr

The merge request removes the outdated \Drupal\Tests\diff\Functional\CoreVersionUiTestTrait

🇳🇱Netherlands idebr

The merge request updates 'assertEquals()' arguments in tests to expected, actual

🇳🇱Netherlands idebr

The merge request adds support for Datetime Range field type and adds test coverage for the daterange field type

🇳🇱Netherlands idebr

8.x-2.4 was released 7 April 2025

🇳🇱Netherlands idebr

@rang501 can you create a merge request instead of uploading a patch? Working with merge requests is the preferred workflow

🇳🇱Netherlands idebr

Let's close this issue as a duplicate of Missing schema tags for courses Active , so we can focus our efforts in the related issue.

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

Settings to 'Needs work' to fix the test failures

🇳🇱Netherlands idebr

The merge request now include a custom Content Lock phpcs ruleset that excludes Drupal.Arrays.Array.LongLineDeclaration

Changes for Drupal.Arrays.Array.LongLineDeclaration were reverted.

🇳🇱Netherlands idebr

Gitlab CI will pick up a custom phpcs configuration, as do IDEs like PHPStorm. Is Drupal.Arrays.Array.LongLineDeclaration the only rule that should not be enforced?

See webform for reference: https://git.drupalcode.org/project/webform/-/blob/6.3.x/phpcs.xml?ref_ty...

🇳🇱Netherlands idebr

The merge request applies gitlab CI defaults for phpcs

🇳🇱Netherlands idebr

Domain source uses the base_url option for its output. There is no need to add the Country path prefix anymore, as it is already available in the base url.

The 'external' option is not a supported key for outbound processing, so that can be removed.

🇳🇱Netherlands idebr

Linkit for Link field Fixed introduced the link-widget-title--auto class that indicates the title was set manually and should not be overwritten

🇳🇱Netherlands idebr

The regression was introduced in 10.4.x, but the fix is only available in 11.x. Any chance of a backport to 10.x?

🇳🇱Netherlands idebr

The merge requests updates the Domain Source OutboundPathProcessor to not rewrite the outbound URL if the source domain is the active domain

🇳🇱Netherlands idebr

Nice to fix an issue by removing code, thanks!

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

Nice to see the CSRF token in place

What is the use for the destination query parameter in content_lock_js_url? This URL is only called in the background and not something a user actually visits?

🇳🇱Netherlands idebr

I expected a CSRF token instead of a custom hash. Can you elaborate why the custom hash is preferred in this case?

🇳🇱Netherlands idebr

The phpstan pipeline job findings are fixed in the merge request

🇳🇱Netherlands idebr

The merge request implements compatibility with both Commerce 2.x and 3.x

🇳🇱Netherlands idebr

This issue was reported earlier in 🐛 RuntimeException: Adding non-existent permissions to a role is not allowed. Needs review . See the related issue for a patch and possible workarounds.

🇳🇱Netherlands idebr

I should have clarified the issue occurs when using the 'Lock form using JS' option.

I moved the test coverage to \Drupal\Tests\content_lock\FunctionalJavascript\ContentLockNodeTest::testContentLockWithTranslations with this option enabled so the issue is triggered correctly.

🇳🇱Netherlands idebr

The stylelint pipeline job findings are fixed in the merge request

🇳🇱Netherlands idebr

This was reported (and fixed) earlier in 📌 Nullable types must be explicit Active

I'll close this issue as a duplicate

🇳🇱Netherlands idebr

This issue is being fixed in 📌 Fix phpstan pipeline job findings Active with a class alias

🇳🇱Netherlands idebr

The phpstan pipeline job findings are fixed in the merge request

🇳🇱Netherlands idebr

The merge request fixes the phpcs pipeline job findings

🇳🇱Netherlands idebr

The merge request updates Claro's jQuery autocomplete enhancements to use (only) css

🇳🇱Netherlands idebr

The merge request

  1. Removes outdated warning: Relying on a CDN for external libraries can cause unexpected issues with Ajax and BigPipe support
  2. Lowers the severity from error to warning as it was before 📌 Change the Webform libraries CDN warning to an error in the Status report (/admin/reports/status). Fixed
🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

The merge request fixes the phpcs pipeline job findings

🇳🇱Netherlands idebr

The merge request converts ExtraField plugin discovery to attributes

🇳🇱Netherlands idebr

The merge request fixes the phpcs pipeline job

🇳🇱Netherlands idebr

The merge request updates the project to consistently use LF line endings

🇳🇱Netherlands idebr

This was fixed in 📌 Commerce 3.0 campatibility Active

A follow-up is available for the change in line endings, see 📌 Use LF line endings consistently Active

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

#12 Return a boolean is now still valid, but triggers a deprecation

Production build 0.71.5 2024