Account created on 29 March 2012, about 13 years ago
#

Merge Requests

More

Recent comments

🇳🇱Netherlands idebr

Nice to see the CSRF token in place

What is the use for the destination query parameter in content_lock_js_url? This URL is only called in the background and not something a user actually visits?

🇳🇱Netherlands idebr

I expected a CSRF token instead of a custom hash. Can you elaborate why the custom hash is preferred in this case?

🇳🇱Netherlands idebr

The phpstan pipeline job findings are fixed in the merge request

🇳🇱Netherlands idebr

The merge request implements compatibility with both Commerce 2.x and 3.x

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

This issue was reported earlier in 🐛 RuntimeException: Adding non-existent permissions to a role is not allowed. Needs review . See the related issue for a patch and possible workarounds.

🇳🇱Netherlands idebr

I should have clarified the issue occurs when using the 'Lock form using JS' option.

I moved the test coverage to \Drupal\Tests\content_lock\FunctionalJavascript\ContentLockNodeTest::testContentLockWithTranslations with this option enabled so the issue is triggered correctly.

🇳🇱Netherlands idebr

The stylelint pipeline job findings are fixed in the merge request

🇳🇱Netherlands idebr

This was reported (and fixed) earlier in 📌 Nullable types must be explicit Active

I'll close this issue as a duplicate

🇳🇱Netherlands idebr

This issue is being fixed in 📌 Fix phpstan pipeline job findings Active with a class alias

🇳🇱Netherlands idebr

The phpstan pipeline job findings are fixed in the merge request

🇳🇱Netherlands idebr

The merge request fixes the phpcs pipeline job findings

🇳🇱Netherlands idebr

The merge request updates Claro's jQuery autocomplete enhancements to use (only) css

🇳🇱Netherlands idebr

The merge request

  1. Removes outdated warning: Relying on a CDN for external libraries can cause unexpected issues with Ajax and BigPipe support
  2. Lowers the severity from error to warning as it was before 📌 Change the Webform libraries CDN warning to an error in the Status report (/admin/reports/status). Fixed
🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

idebr created an issue.

🇳🇱Netherlands idebr

The merge request fixes the phpcs pipeline job findings

🇳🇱Netherlands idebr

The merge request converts ExtraField plugin discovery to attributes

🇳🇱Netherlands idebr

The merge request fixes the phpcs pipeline job

🇳🇱Netherlands idebr

The merge request updates the project to consistently use LF line endings

🇳🇱Netherlands idebr

This was fixed in 📌 Commerce 3.0 campatibility Active

A follow-up is available for the change in line endings, see 📌 Use LF line endings consistently Active

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

#12 Return a boolean is now still valid, but triggers a deprecation

🇳🇱Netherlands idebr

The merge requests fixes the phpunit tests

🇳🇱Netherlands idebr

In the merge request, the module claims it is compatible with Drupal Commerce 3. This means the changes from 📌 Commerce 3.0 campatibility Active are required for compatibility.

In addition the MollieApiMock determines the payment status from the paid amount using incorrect comparisons, eg. 29.99 === 29.9900000. I updated MollieApiMock to compare Prices instead.

The functional tests are now green.

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

My project requirement is pretty basic:
- Upload a file in a node
- Automatically translate the file when translating the node using Deepl

This is supported by tmgmt, see Translate files / attachments Fixed

The priority for automatic translations for documents in my project has been lowered, so I don't expect to do any development on this feature in the short term

🇳🇱Netherlands idebr

\Drupal:state() is now replaced with \Drupal::keyvalue('user_form_test') in the test coverage

🇳🇱Netherlands idebr

The merge request fixes the remaining phpstan issue

🇳🇱Netherlands idebr

The patch in #2 is now available as a merge request

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

The merge request does not lock the entity when adding a content translation

🇳🇱Netherlands idebr

The merge request removes the obsolete drupalci.yml file from the project.

🇳🇱Netherlands idebr

Fixed the last test failure.

🇳🇱Netherlands idebr

This is being fixed in 🐛 Undefined function field_ui_entity_operation Active . I'll close this issue as a duplicate, so we can focus our efforts in the related issue.

🇳🇱Netherlands idebr

This is being fixed in 🐛 Undefined function field_ui_entity_operation Active . I'll close this issue as a duplicate, so we can focus our efforts in the related issue.

🇳🇱Netherlands idebr

The item category contains additional logic to add a URL attribute when it uses a term reference field.

Using a field that is not a term reference will now no longer trigger a PHP exception

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

The merge request fixes the phpcs pipeline job

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

I filed an issue to fix 1.x as well while it is still supported, see 🐛 [1.x] Fix phpstan and commerce plugin contructors Active

🇳🇱Netherlands idebr

.ck-editor includes the toolbar. Let's use .ck-content so the css only applies to the editable content.

🇳🇱Netherlands idebr

The issue summary is updated with the issue summary template heading.

🇳🇱Netherlands idebr

Can you check the Grant type 'Refresh Token' is enable on your Consumer edit form?

🇳🇱Netherlands idebr

The merge request adds 'roles' to AccountForm getEditedFieldNames() and flagViolations(), so Constraint violations are properly displayed as form errors.

🇳🇱Netherlands idebr

Yes, we should be explicit about ^9.0 of league/oauth2-server due to PHP compatibility of method signatures

Production build 0.71.5 2024