Account created on 29 March 2012, almost 13 years ago
#

Merge Requests

More

Recent comments

🇳🇱Netherlands idebr

The test checks for the aria-describedby attribute. This attribute is only available when the field has a description.

🇳🇱Netherlands idebr

The remaining deprecations are now fixed in the merge request

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

The merge request updates configuration forms to use #config_target

🇳🇱Netherlands idebr

The merge request raises the minimum supported Drupal version to 10.3: https://endoflife.date/drupal

The logger can now be autoconfigured, see https://www.drupal.org/node/3395436

🇳🇱Netherlands idebr

I have created a merge request to either fix or disable cspell. Only one should be merged.

PHPUnit failures are caused upstream, see 📌 PHP 8.4: Implicitly nullable parameter declarations deprecated Active

🇳🇱Netherlands idebr

Considering Drupal 11 has been released a while ago, this issue can now be marked as fixed?

🇳🇱Netherlands idebr

This issue also happens to be caught by phpcs, so I fixed these issues in a single go

🇳🇱Netherlands idebr

The merge request removes lingering 'priority' keys from node access records

🇳🇱Netherlands idebr

🌱 Move to thephpleague/oauth2-server 9.0 Active has been committed. However, there is no upstream support yet for introspection

🇳🇱Netherlands idebr

The merge request adds the following changes:

  1. The configuration form now uses #config_target
  2. The default configuration syntax now matches the config when first pressing 'Submit configuration'
🇳🇱Netherlands idebr

In the merge request ctools is no longer installed when testing pathauto

🇳🇱Netherlands idebr

Sure, that makes sense. Can completing the test coverage be done in a follow-up issue in 2.3.x?

🇳🇱Netherlands idebr

@steffenr The merge request seems pretty complete. Is there anything that needs to be changed before a merge? The official PHP client would be very welcome when working on Support translation of documents Active

🇳🇱Netherlands idebr

The conversion exposes a bug in the config schema where tfa.settings:mail is defined as a config object:
Symfony\Component\Validator\Exception\LogicException: The LangcodeRequiredIfTranslatableValues constraint is applied to 'tfa.settings::mail'.

This should be fixed in this issue to make the tests pass

🇳🇱Netherlands idebr

The merge request adds the following changes:

  1. All configuration forms now use #config_target
  2. All configuration forms have a Configure link on the Modules list
  3. The default configuration syntax now matches the config when first pressing 'Submit configuration'
🇳🇱Netherlands idebr

The reroll in #80 is missing the SimplesitemapMetatagTest from #79

🇳🇱Netherlands idebr

The merge request removes mpyw/phpunit-patch-serializable-comparison as a dev dependency

🇳🇱Netherlands idebr

Update the merge request, so drupal/video_embed_field can now be installed with ^2.5 or ^3

🇳🇱Netherlands idebr

Before

Time: 00:28.525, Memory: 12.00 MB

After

Time: 00:09.647, Memory: 12.00 MB

🇳🇱Netherlands idebr

The merge request updates the composer package for drupal/video_embed_field to 3.x for Drupal 11 compatibility

🇳🇱Netherlands idebr

I think this according to the RSS specs? See https://www.rssboard.org/rss-profile#element-channel-image

<image>
  <link>http://dallas.example.com</link>
  <title>Dallas Times-Herald</title>
  <url>http://dallas.example.com/masthead.gif</url>
  <description>Read the Dallas Times-Herald</description>
  <height>32</height>
  <width>96</width>
</image>
🇳🇱Netherlands idebr

📌 Implement js- prefix for linkit textfields to separate JavaScript behavior from styling Needs review essentially does the same, but without duplicating Claro CSS

🇳🇱Netherlands idebr

There is an earlier issue for concurrent tests available at 📌 Enable concurrent phpunit Active that needs work.

I'll close this issue as a duplicate, so we can focus our efforts in the related issue.

🇳🇱Netherlands idebr

MR 10182 implements an alternative solution where the code ends up as follows:

        $form['parent']['akey']['asubkey'] = [
          '#type' => 'text_format',
          '#title' => $this->t('Subkey title'),
          '#format' => $this->config('mymodule.settings')->get('akey.asubkey.format'),
          '#config_target' => "mymodule.settings:akey.asubkey",
        ];
  

I'm not sure ConfigTarget was intended to control any element property other than #default_value when reading the change record at https://www.drupal.org/node/3373502

🇳🇱Netherlands idebr

Another interesting follow-up where a config value has to be mapping to multiple element properties: 🐛 Two #config_targets error when used on a text_format form element Active

🇳🇱Netherlands idebr

The 6.x branch is not currently under development.

🇳🇱Netherlands idebr

The merge request updates thephpleague/oauth2-server to 9.0.x

Breaking changes are listed at the release page https://github.com/thephpleague/oauth2-server/releases/tag/9.0.0, but most notably:

  1. New: Strict typing and return types
  2. Changed: some exceptions return a different status code and the error message data structure has changed
  3. Refresh token scopes are now finalized again, so any invalid scopes are removed (this was the last test failure in #4)

Seems fine to include in the module's beta phase, but this is up to the module's maintainer

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

The phpstan pipeline is now fixed, but one test is now failing. Oddly enough it doesn't fail on my local machine.

🇳🇱Netherlands idebr

The merge request fixes the check added in 🐛 Duplication for Empty Fields Active , so text extractions are correctly added to files index

🇳🇱Netherlands idebr

The merge request removes the legacy ckeditor from the codebase

🇳🇱Netherlands idebr

The eslint stage still needs work to match Drupal Core's JavaScript code style

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

This issue was fixed as part of Drupal 11 compatibility fixes for webform Active

It can probably be closed as a duplicate

🇳🇱Netherlands idebr

The merge request implements a Drupal.theme function that themes can use to override the View password toggle element markup.

Documentation JavaScript theming is available at https://www.drupal.org/docs/drupal-apis/javascript-api/theming-in-javasc...

🇳🇱Netherlands idebr

I'll close this issue as a duplicate, so we can focus our efforts in the related issue

🇳🇱Netherlands idebr

idebr changed the visibility of the branch 2881776-consider-implementing-per-bundle_8x-14 to hidden.

🇳🇱Netherlands idebr

The new MR34 did not merge all 8.x-1.x changes correctly. I updated the original MR10. The automated tests are green again.

🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

Drupal 9 is no longer supported. Can you reproduce this error on a supported Drupal version? See 📌 Raise minimum Drupal version to 10.2 Active

🇳🇱Netherlands idebr

Updated the merge request:

  1. Modernized the drush command with attributes
  2. Removed the drush.services.yml as this is longer used in Drush 12+
  3. Fixed compatibility with Drupal 11 so PHPUnit runs correctly
  4. General code cleanup
🇳🇱Netherlands idebr

idebr made their first commit to this issue’s fork.

🇳🇱Netherlands idebr

@chesn0k The code is tested automatically with lcobucci/jwt (5.4.0), see https://git.drupalcode.org/project/simple_oauth/-/jobs/3144336
Can you post the exact error message?

Since this issue is already available in the latest release, I suggest creating a new issue.

🇳🇱Netherlands idebr

Note the module might become incompatible with Drupal 9 just by implementing D10+ coding standards, for example see the Domain module: 🐛 The website encountered an unexpected error. Please try again later. Active

If you want to explicitly support Drupal 9 (and thus PHP7), better test for it.

I'd argue explicitly supporting the lowest supported Core version according to https://endoflife.date/drupal ends up a much smoother experiences for developers as you don't get incompatible updates through composer.

🇳🇱Netherlands idebr

The minimum core_version_requirement was never formally raised, I opened a new issue at 📌 Raise minimum Drupal version to 10.2 Active to update the info files

🇳🇱Netherlands idebr

The merge request implements a minimum Drupal version of 10.2, as this is the lowest version still receiving security support. See https://endoflife.date/drupal

Production build 0.71.5 2024