The merge request updates the special handling for the Country path module: the canonical URL now includes the country path
The Simple Sitemap module has run into similar problems in the past. Its generator clears the entity static cache to prevent running out of memory. I have not found a similar implementation for Entity Usage?
The merge request suggests the __construct docblocks for removal
The merge request replaces DomainListCheck with permissions in domain.routing.yml
As a bonus, the access result now has cache metadata so it can be cached
The merge requests implements autoconfigure for services, so event subscribers no longer need to have the 'event_subscriber' tag
The merge request removes the outdated information from the DomainServiceProvider docblock.
The relevant code has moved to \Drupal\domain\EventSubscriber\DomainSubscriber::onKernelRequestDomain, but it doesn't seem worth mentioning in this particular docblock.
ServiceModifierInterface is already announced in ServiceProviderBase, so it can be removed.
MR shows a failure in the pipeline (probably unrelated, but I don't have the permission to re-run it), see https://git.drupalcode.org/issue/drupal-3202329/-/pipelines/644390/test_...
I pushed a test to https://git.drupalcode.org/project/drupal/-/merge_requests/10182/commits but it is not showing up in Gitlab? Attached 3463868-21-test-only.patch contains the code
#config_target is available from Drupal 10.2.0, see https://www.drupal.org/node/3373502 →
Currently ConfigManager is responsible for both loading and saving the module's configuration, so it needs the getEditable version from the configFactory. getEditable is loaded without overrides, so any overrides are not saved to the original configuration.
📌 Use #config_target for the settings form Needs review solves this issue by moving the 'save' part to the RemoveHttpHeadersSettings form. ConfigManager now only has to load configuration and can use configFactory->get() that includes config overrides
As a result, this issue can be closed once 📌 Use #config_target for the settings form Needs review is committed.
Updating to 'Needs work':
- Patch should be converted to a merge request, so the code change is tested
- Need tests to make sure the bug is fixed
The merge request removes code duplication from DomainListBuilder
Test assertions need to be updated as well, see https://git.drupalcode.org/issue/drupal-3554801/-/pipelines/642260/test_...
The merge request is updated with a sort by SORT_KEY for Drupal versions before 10.4.
The call to version_compare is a reminder the statement can be removed once 10.4 is no longer supported by Domain
The merge request implements EntityListBuilder::getEntityListQuery to alter ListBuilder queries
The merge request removes ControllerBase for complex use cases
A follow-up to remove ControllerBase for complex use cases is available at #3554044: Remove ControllerBase for complex use cases →
It does, the Drush commands for the Domain module were updated in a similar way in 📌 Fix phpstan issues in DomainCommands Active
See Drush compatibility table: https://www.drush.org/13.x/install/
Controllers that extend ControllerBase cannot promote the properties defined in ControllerBase.
The documentation for ControllerBase suggests it is used for simple cases only, so it might be worth dropping the base class to improve maintainability. Maybe in a follow-up issue?
Turns out a route alias is Drupal 11.x only
The cancel URL is restored in the delete form, so no route changes are required.
This issue is available in release 8.x-1.0-beta7, see https://www.drupal.org/project/ajax_comments/releases/8.x-1.0-beta7 →
I believe it is intentionally that file entities don't have canonical route.
As @berdir mentioned in comment https://www.drupal.org/project/drupal/issues/2345761#comment-13180034 →
files will IMHO remain second-class citizens and we will not introduce an actual canonical route in core, and we decided against having one that points to the physical file.
See also 🐛 File delete form throws UndefinedLinkTemplateException without destination parameter Active
The test assertion with the successful deletion message has been updated in the merge request
The merge request implements the following changes:
- DomainAliasCommands is moved to the Drush\Commands namespace
- Its construction parameter are now autowired, removing the need for drush.services.yml
- Fixed a missing parent::construct() call
The merge request implements constructor property promotion to reduce boilerplate
Strictly speaking the phpcs violation is out of scope, since it fails due to a recent change in Drupal Core, see 🐛 Typo in WidgetInterface.php Active
However, since the change is trivial enough, I'll include it here
The merge request implements the following changes:
- .travis.yml is removed
- Obsolete define_subdomains.sh script for drupal CI is removed
- References to these files are removed
Babel Webform Install (Drupal\Tests\babel_webform\Kernel\BabelWebformInstall)
✘ Install
┐
├ LogicException: The hook update_dependencies on class Drupal\webform\Hook\WebformInstallUpdateHooks does not support attributes and must remain procedural.
│
│ /builds/project/babel/web/core/lib/Drupal/Core/Hook/HookCollectorPass.php:671
│ /builds/project/babel/web/core/lib/Drupal/Core/Hook/HookCollectorPass.php:476
│ /builds/project/babel/web/core/lib/Drupal/Core/Hook/HookCollectorPass.php:402
│ /builds/project/babel/web/core/lib/Drupal/Core/Hook/HookCollectorPass.php:138
│ /builds/project/babel/vendor/symfony/dependency-injection/Compiler/Compiler.php:73
│ /builds/project/babel/vendor/symfony/dependency-injection/ContainerBuilder.php:826
│ /builds/project/babel/web/core/lib/Drupal/Core/DrupalKernel.php:1397
│ /builds/project/babel/web/core/lib/Drupal/Core/DrupalKernel.php:916
│ /builds/project/babel/web/core/lib/Drupal/Core/DrupalKernel.php:829
│ /builds/project/babel/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:729
│ /builds/project/babel/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:320
│ /builds/project/babel/web/core/lib/Drupal/Core/Extension/ModuleInstaller.php:229
│ /builds/project/babel/web/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
│ /builds/project/babel/modules/babel_webform/tests/src/Kernel/BabelWebformInstallTest.php:37
┴ERRORS!
Tests: 1, Assertions: 0, Errors: 1, PHPUnit Deprecations: 2.
This was fixed in 📌 LogicException: The hook update_dependencies does not support attributes Active
There is an older issue available to fix phpcs, see 📌 Coding standard issues Active .
I'll close this issue so we can focus our efforts in the related issue
MR19 branch target is 9.x and builds on the pipeline added in 📌 Introduce tests for module and configure pipelines Active
The file changes in src/Feeds/Target/YearOnly.php are due to the line endings switching from CRLF to LF
idebr → changed the visibility of the branch 3473443-coding-standard-issues to hidden.
What composer command are you running? drupal/commerce_autosku does not require any specific version
Changes for Drupal 11 are available in the 3.0 beta, but no stable release yet. I don't see any blocking issues, so this might just be an administrative task?
The change works as expected, thanks!
The CountryPathDomainListBuilder is no longer used and can be removed
Thanks, composer.json is sufficient to manage the domain package version
The cspell job reports a number of unrecognized words, one of them is "certinaly". Let's fix the other words as well.
Why would you add max-age 0 when expires is expired? It will not update until the config is changed.
Two things are currently missing:
- The development branch is not listed on the project page, compare https://www.drupal.org/project/webform_iban_field → vs https://www.drupal.org/project/role_test_accounts →
- Version 2.x cannot be selected in the issue queue
Both things can be fixed with the instructions in #4
https://www.drupal.org/project/webform_iban_field → has a link 'Add new release'. Here you can select 2.x as a development branch
2.x-dev is not necessary and can be removed
The merge request implements the following changes:
- Added a gitlab-ci.yml template, see https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c...
- The test is placed in the tests directory, so it is picked up by gitlab CI
- Added the webform dependency to composer.json
- Fixed the order of arguments for assertEquals()
- Added a void return type to the test method
The eslint pipeline job still reports lint errors, see https://git.drupalcode.org/issue/paragraphs-3138762/-/jobs/6543959
This issue was fixed in 🐛 Export single simple configuration name has no empty value, resulting in confusing UI RTBC . I'll close this issue as a duplicate
The indentation change for composer.json is incorrect: composer.json uses indent_size 4. See for reference https://git.drupalcode.org/project/drupal/-/blob/11.x/.editorconfig?ref_...
Functionally this is working great! I'll open a 2.x branch so this module can implement breaking changes for existing installations.
Some remarks:
- Do we still need the TempStore for saving selectors? Since these are now determined through the commented entity and the field name
- Let's use the native Element scrollIntoView for the ajaxCommentsScrollToElement command, see for reference https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView and https://git.drupalcode.org/project/drupal/-/commit/e1c818c662f8c0c6a1dc8...
- Can the highlight part of ajaxCommentsScrollToElement be called with ajaxCommentsHighlight so each command has a unique responsibility?
Further cleanup can be done in followups.
@jsacksick can you tag a patch release with this fix to prevent updated sites from displaying this error on the status page?
Inline Entity Form uses the RenderArrayTool Library for this, see https://www.drupal.org/project/rat →
Specifically, see https://git.drupalcode.org/project/rat/-/blob/1.0.x/README.md?ref_type=h...
This is being fixed in 🐛 Country path not managed in domain navigation block Needs work
I'll close this issue as a duplicate, so we can focus our efforts in the related issue
The merge request updates the ContentTranslationController to add the new translation to a clone of the entity in the route, so access checks for the language switch links pass.
MR updated after 📌 Fix LongLineDeclaration in Functional tests Active was commited
@catch I assume this issue can be marked as fixed? Its status is currently still 'RTBC'
The merge request implements the following changes:
- The configuration is now saved through the #config target property, see https://www.drupal.org/node/3373502 →
- Validation is now done through config schema instead of form validation
- Cache invalidation is now done through a config listener instead of form submit
@loze thanks for continuing to work on this. I'll do an in-depth review later this week.
Not sure Drupal can actually do anything to prevent the double header being emitted.
It can, and it does (for X-Content-Type-Options), see https://git.drupalcode.org/project/drupal/-/blob/11.x/.htaccess?ref_type...
This option is available through Search API's query option 'Skip item access checks', see #2470914: Add Views support for individual fields →
Thanks for reporting, https://www.drupal.org/project/role_test_accounts/releases/8.x-1.7 → is now available