- Issue created by @mmenavas
- 🇺🇸United States mmenavas
Uploading a patch that implements the proposed solution on the issue description (add vertical tabs library as a dependency of collapse).
- 🇺🇸United States mmenavas
Alternatively, to prevent vertical-tabs.js from loading on every page that has Details elements, we can modify the logic on "core/misc/vertical-tabs.js" (line 89 as of v10.4.1) to extract only the text from the first child (text node) in the element as opposed to getting all of the text using the .textContent property which grabs the text from all children (including the element already added by detailsSummarizedContentText()).
- 🇳🇿New Zealand quietone
@mmenavas, thanks for the report and the fix.
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies → .
In Drupal core we prefer that people add a comment stating they are working on an issue. See Assigning ownership of a Drupal core issue → for the details.
This should have before and after screenshots available in the Issue Summary so they can be found by reviewers and committers.
- 🇺🇸United States mmenavas
@quietone: Thank you for the feedback. I added the before and after screenshots. Please let me know how else I can help move this ticket forward. Would it help if I make an MR and write some tests?
- 🇬🇧United Kingdom catch
An MR with test coverage would be good.
The solution in #5 sounds preferable if that works.
- 🇺🇸United States mmenavas
Thank you @catch! I'll create an MR as soon as I have the solution on #5 implemented, unless someone else beats me to it =)
I can confirm that the patch on #2 fixes the problem for 10.4.x
- 🇳🇿New Zealand luke.stewart
Removing needs screenshots tag as they are now included.
- Merge request !11249Resolve #3498100 "Duplicate summary on vertical tabs" → (Open) created by mmenavas
- 🇺🇸United States mmenavas
@catch, I created an MR and implemented the changes mentioned in #5. I also added test coverage for vertical tabs with dynamic summaries. Let me know if there's anything else I can help with.
- 🇺🇸United States dww
Thanks for working to smash this bug!
Latest pipeline failed in phpstan. We need to see green testbot results before this is ready for review. In this case, hopefully a failing test-only run, too.
Thanks,
-Derek - 🇺🇸United States mmenavas
Thank you for pointing out the failing PHPStan check, @dww. That should be fixed now. Unfortunately, I don't have permission to run the test-only CI job.
- 🇸🇰Slovakia poker10
I run the test-only job. Tests are green and test-only run failed - https://git.drupalcode.org/issue/drupal-3498100/-/jobs/4539840 . Moving back to NR.
- Issue was unassigned.
- Status changed to Needs review
24 days ago 6:15am 10 March 2025 - 🇮🇳India shivam_tiwari
I found this issue, checked MR also. It is working fine. I am adding SS also before and after that applying MR. There is no test issue also.
Moving this to RTBC. - 🇫🇷France nod_ Lille
if we had the before/after thing for library this would be a 2 lines diff :)
always useful to harden the code, small code improvement needed
- 🇺🇸United States mmenavas
Thank you @_nod! I just rebased my fork branch and pushed the code changes you suggested. I agree the before/after feature is much needed.
Note: I'm currently in the contributing session at DrupalCon Atlanta, and I'd like to thank Igor for being such a great mentor.
- 🇺🇸United States mmenavas
I just marked the issue as "Needs Review". I'm currently at DrupalCon Atlanta if any core contributors have questions regarding this issue.
- 🇧🇷Brazil igorgoncalves
Worked with @mmenavas at #Atlanta2025
Issue still needs review.
I just updated my fork branch with the latest updates and I can confirm that it is working! +1
- 🇺🇸United States mradcliffe USA
The test runner seems to have failed on a bunch of kernel tests, but it was not clear if it is related to the changes.
- 🇺🇸United States mmenavas
@brunoalmeida: Thank you for reviewing!
@mradcliffe I reran the failing CI check. Checks are green now.
Confirmed that I'm seeing the corrected version like in the screenshots when adding content blocks, media items and taxonomy terms.