- Issue created by @mmenavas
- πΊπΈUnited States mmenavas
Uploading a patch that implements the proposed solution on the issue description (add vertical tabs library as a dependency of collapse).
- πΊπΈUnited States mmenavas
Alternatively, to prevent vertical-tabs.js from loading on every page that has Details elements, we can modify the logic on "core/misc/vertical-tabs.js" (line 89 as of v10.4.1) to extract only the text from the first child (text node) in the element as opposed to getting all of the text using the .textContent property which grabs the text from all children (including the element already added by detailsSummarizedContentText()).
- π³πΏNew Zealand quietone
@mmenavas, thanks for the report and the fix.
Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies β .
In Drupal core we prefer that people add a comment stating they are working on an issue. See Assigning ownership of a Drupal core issue β for the details.
This should have before and after screenshots available in the Issue Summary so they can be found by reviewers and committers.
- πΊπΈUnited States mmenavas
@quietone: Thank you for the feedback. I added the before and after screenshots. Please let me know how else I can help move this ticket forward. Would it help if I make an MR and write some tests?
- π¬π§United Kingdom catch
An MR with test coverage would be good.
The solution in #5 sounds preferable if that works.
- πΊπΈUnited States mmenavas
Thank you @catch! I'll create an MR as soon as I have the solution on #5 implemented, unless someone else beats me to it =)