I created MR 20 for the latest development branch. Need to close old MR 4. Please review MR 20 so we can get these changes on the project repo.
shivam_tiwari → made their first commit to this issue’s fork.
Please verify MR 59.
shivam_tiwari → made their first commit to this issue’s fork.
I checked it from my side also, and it is working as expected. This is basic thing: if there is no menu item for any user, then icons should not be visible for that user. As there is no pipeline failure and test cases issue with MR, moving it to RTBC.
I am adding some screenshots here related to my unit testing.
I checked the MR and applied it as a patch. Patch is applied successfully without any error, and it resolves issue as mentioned in description.
Moving this to RTBC
I checked it from my side it is working as expected according to the issue requirement. As there is not any pipeline failure and test cases issue with MR so moving it to RTBC.
I checked MR and applied it as a patch. Now we can see module's human readable name in place of module's machine name on the module uninstall page. There is not any pipeline failure and test cases issue with MR so moving it to RTBC,
Adding screenshots of uninstall page related to my testing here.
I faced same issue after updating taxonomy_menu_ui module to the latest version. I checked patches added here. #8 patch fixed issue for me. I created MR so we can run test and merge this update to the latest versions.
Thanks
shivam_tiwari → made their first commit to this issue’s fork.
@nginex I created MR and updated it according to your comment #9. Need to fix here for test coverage issue because pipeline is failing.
shivam_tiwari → made their first commit to this issue’s fork.
Ohh, Current MR is not applied for Olivero theme. Moving this to Needs Review.
@saschaeggi, @smustgrave, Please check and provide your feedback.
@divyansh.gupta Thanks for creating PR. Needs to work here for pipeline test failure issue.
I checked this issue and MR. Faced same problem on Drupal fresh set up. After applying MR as a patch it resolves problem. Moving this issue to RTBC as it looks fine.
Adding some screenshots related to my testing.
Need to work here as pipeline is failing related to test coverage.
I checked this issue and MR. I got same problem, if user don't have email address then I am getting 500 error page with same error message as given here. I applied MR as a patch and it is working fine. It gives an information also to the admin user that updated user don't have email address so email could not be sent.
I am adding some screenshots also related to it and moving this to RTBC
@manish.upadhyay I checked this but could not understand the issue. Can you please provide here steps to reproduce the issue and error.
shivam_tiwari → made their first commit to this issue’s fork.
shivam_tiwari → made their first commit to this issue’s fork.
shivam_tiwari → made their first commit to this issue’s fork.
I faced this issue at the time of adding password protection handler. I got mentioned warning message on Drupal logs. Checked this issue and applied MR as a patch. This is worked for me without any error and warning.
Moving this issue to RTBC.
I checked MR and its looks fine for me. I applied this as a patch and now scroller is shifted to 200px respect to block height.
Adding screenshots related to this and moving this issue to RTBC.
I worked here and checked module functionality according to the description provided of this issue. I checked patch #8, and it is working fine but I was not getting custom color palette created by user on the field settings. Actually, this default colors field is a required field and we added a condition for overriding it if this filed value is empty. When I am going to clear this value for setting custom color palettes it is not working. It is giving me required field error. So I removed required attribute from this.
Now if we clear existing default values we will get custom color palettes added on the settings page.
Second, I updated the info file also of the module to visit user to settings page directly.
For now pipeline is failing so changing issue status to Needs work for fixing pipeline failure.
@kul.pratap Thanks for quick reaction. I checked MR now it is working fine.
I checked it by creating and updating files on the node form. Modules is working fine on D11 setup. Moving it to RTBC.
I found this issue on Drupal 11 with php 8.4. I applied MR as a patch it works fine for me. Moving it to RTBC.
@kul.pratap Thanks for quick changes. Moving this to RTBC.
This issue was found for me on Drupal 10.3.10 with PHP 8.4
After installing modules, I am getting 500 error page with a white screen. MR 225 is working fine for me so moving it to RTBC.
Adding some testing evidence related to it.
I am working here.
I am getting same issue on D11 setup after installing module it gives giving error at the time of adding a new field. MR 4 fixes this issue for me. Moving issue to RTBC.
I checked MR 89 from my side. Changes look fine for me and there is no pipeline failure issue so moving it to RTBC.
@koustav_mondal I checked issue from my side. Error is resolved as given on the issue for PHP 8.2
But I am getting white screen after installing the module and getting this error
Twig\Error\RuntimeError: The "Drupal\Core\Template\TwigExtension" extension is not enabled in "core/themes/claro/templates/form/input.html.twig". in Twig\ExtensionSet->getExtension() (line 80 of /app/vendor/twig/twig/src/ExtensionSet.php).
Can you please check this and let me know if I missed something here?
kul.pratap I verified this for D11. Module is working fine on D11 but I am getting this error after saving node.
Error: Call to undefined method Drupal\file\FileStorage::getTempDirectory() in upload_replace_file_update() (line 66 of /app/web/modules/custom/upload_replace/upload_replace.module).
shivam_tiwari → made their first commit to this issue’s fork.
This issue found for me also after adding controller as described on #9. Created MR 11629 to resolve this issue. After adding this MR as a patch issue is resolved but pipeline is failing for PHP static analysis, so need to work on this.
I am working here.
I checked MR 3. Looks good and no error on pipeline. So moving it to RTBC.
@saschaeggi Please verify now. I updated MR according to your suggestions.
shivam_tiwari → made their first commit to this issue’s fork.
I checked MR 8585 from my side, It works fine for me on Drupal 10.3 and 11 versions.
My testing steps:
- Enabled the Settings Tray and Layout builder module
- Enabled the layout builder for page content type
- Added the two different inline blocks in the layout settings
- Checked in the console.
- On drupal 10 and 11 version both I got error on console.
- After applied MR as a patch it worked fine.
Adding my testing SS and moving it to RTBC.
I checked this issue on specified drupal version. I am using latest version of icon_select module (3.0.1) but not getting this issue.
Please correct me if I am skipping any step here.
@julien tekrane Can you please inform here your drupal core version and other details? Because it is working fine for me. I am checking on drupal 11.
I missed SS. Sorry for noise.
@ashish-deynap I checked patch here, it is applying successfully on the latest version but after applying patch, I am not getting icon image for selecting taxonomy term.
My testing steps:
- Created terms on Icons taxonomy terms.
- Added icons in terms.
- Created a reference field on article content type and added an entity reference field.
- This field is a terms reference field.
- On Manage form display setting set Icon Select widget for this field.
- On node add/edit form, I am not getting icon image.
I am not getting any functionality-wise change after adding patch. Can you please also provide a proper issue description?
shivam_tiwari → made their first commit to this issue’s fork.
shivam_tiwari → made their first commit to this issue’s fork.
I checked this, but not getting any issue like this. Can you please provide here steps to reproduce of this issue?
I found this issue, checked MR also. It is working fine. I am adding SS also before and after that applying MR. There is no test issue also.
Moving this to RTBC.
shivam_tiwari → made their first commit to this issue’s fork.
@rohitsharma401 I am going to review this issue and change, but can't replicate. Can you please give me more details? I am on drupal 11 and using claro as an admin theme. Which admin theme are you using?
Moving issue to the latest branch and creating MR for it.
According to @webmestre, now this issue is not available. So closing it.
I am working here.
@j_s I checked following issue but I am not getting this. I checked on Drupal 11.0.12 and Clientside Validation 4.1.2.
I checked 49. Following steps are applied to check issue.
Created a custom 404 page and set it as a 404 destination page from configurations.
Checked by malformed URL, it is showing the desired page.
Installed quiz module.
But after this, not getting same page on the malformed URL, because of the issue as mentioned in description.
Applied MR as a patch and got correct specified 404 page.
Moving it to RTBC now.
I checked MR 75, and It resolves errors mentioned in issue. Moving this to RTBC.
I checked MR and doc mentioned on
https://www.drupal.org/node/3498345 →
Looks good so moving it to RTBC.
@tirupati_singh @thomas kaisuka Thanks for review.
I updated twig template. Please check when you are available!
@esha_kundu Thanks for updating MR. I checked from my end it looks fine now.
Moving it to RTBC.
I checked MR 3 changes. Looks fine so moving it to RTBC.
shivam_tiwari → made their first commit to this issue’s fork.
I am working here.
I am working here.
shivam_tiwari → made their first commit to this issue’s fork.
shivam_tiwari → made their first commit to this issue’s fork.
shivam_tiwari → made their first commit to this issue’s fork.
I think this is duplicated issue.
I checked MR 9 changes on drupal 11.1.1 and PHP 8.3.14
Before applying MR it was giving me error at the time of bulk node editing.
After I applied MR as a patch from composer and it is working fine. I am not getting any error or warning also on log detail page. So moving it to RTBC.
Adding 2 videos also for reference.
I checked MR 28 and looks fine to me. Moving it to RTBC.
I checked MR 19 changes from my side. It worked for me.
Applied following steps.
- Created a telephone field
- Added mask settings from the form render display setting.
- Set (000) 000-0000 on Mask field in widget.
- After submitting the node, got field output: (999) 999-9999
- Enabled unmask on submit option from setting
- After submitting the node, getting field output: 9999999999
Moving it to RTBC
I checked MR 7, it looks fine to me. Moving it to RTBC.
I checked MR 569. Looks fine so moving it to RTBC.
shivam_tiwari → made their first commit to this issue’s fork.
Moving it to latest development version.
shivam_tiwari → made their first commit to this issue’s fork.
Applied changes on MR and moving its to Needs Review.
shivam_tiwari → made their first commit to this issue’s fork.
shivam_tiwari → made their first commit to this issue’s fork.