Account created on 28 January 2019, about 6 years ago
#

Merge Requests

More

Recent comments

🇮🇳India shivam_tiwari

I checked MR 8585 from my side, It works fine for me on Drupal 10.3 and 11 versions.
My testing steps:

  1. Enabled the Settings Tray and Layout builder module
  2. Enabled the layout builder for page content type
  3. Added the two different inline blocks in the layout settings
  4. Checked in the console.
  5. On drupal 10 and 11 version both I got error on console.
  6. After applied MR as a patch it worked fine.

Adding my testing SS and moving it to RTBC.

🇮🇳India shivam_tiwari

I checked this issue on specified drupal version. I am using latest version of icon_select module (3.0.1) but not getting this issue.
Please correct me if I am skipping any step here.

🇮🇳India shivam_tiwari

@julien tekrane Can you please inform here your drupal core version and other details? Because it is working fine for me. I am checking on drupal 11.

🇮🇳India shivam_tiwari

@ashish-deynap I checked patch here, it is applying successfully on the latest version but after applying patch, I am not getting icon image for selecting taxonomy term.
My testing steps:

  1. Created terms on Icons taxonomy terms.
  2. Added icons in terms.
  3. Created a reference field on article content type and added an entity reference field.
  4. This field is a terms reference field.
  5. On Manage form display setting set Icon Select widget for this field.
  6. On node add/edit form, I am not getting icon image.

I am not getting any functionality-wise change after adding patch. Can you please also provide a proper issue description?

🇮🇳India shivam_tiwari

shivam_tiwari made their first commit to this issue’s fork.

🇮🇳India shivam_tiwari

I checked this, but not getting any issue like this. Can you please provide here steps to reproduce of this issue?

🇮🇳India shivam_tiwari

I found this issue, checked MR also. It is working fine. I am adding SS also before and after that applying MR. There is no test issue also.
Moving this to RTBC.

🇮🇳India shivam_tiwari

@rohitsharma401 I am going to review this issue and change, but can't replicate. Can you please give me more details? I am on drupal 11 and using claro as an admin theme. Which admin theme are you using?

🇮🇳India shivam_tiwari

Moving issue to the latest branch and creating MR for it.

🇮🇳India shivam_tiwari

According to @webmestre, now this issue is not available. So closing it.

🇮🇳India shivam_tiwari

@j_s I checked following issue but I am not getting this. I checked on Drupal 11.0.12 and Clientside Validation 4.1.2.

🇮🇳India shivam_tiwari

I checked 49. Following steps are applied to check issue.
Created a custom 404 page and set it as a 404 destination page from configurations.
Checked by malformed URL, it is showing the desired page.
Installed quiz module.
But after this, not getting same page on the malformed URL, because of the issue as mentioned in description.
Applied MR as a patch and got correct specified 404 page.
Moving it to RTBC now.

🇮🇳India shivam_tiwari

I checked MR 75, and It resolves errors mentioned in issue. Moving this to RTBC.

🇮🇳India shivam_tiwari

@tirupati_singh @thomas kaisuka Thanks for review.
I updated twig template. Please check when you are available!

🇮🇳India shivam_tiwari

@esha_kundu Thanks for updating MR. I checked from my end it looks fine now.
Moving it to RTBC.

🇮🇳India shivam_tiwari

shivam_tiwari made their first commit to this issue’s fork.

🇮🇳India shivam_tiwari

I checked MR 9 changes on drupal 11.1.1 and PHP 8.3.14
Before applying MR it was giving me error at the time of bulk node editing.
After I applied MR as a patch from composer and it is working fine. I am not getting any error or warning also on log detail page. So moving it to RTBC.
Adding 2 videos also for reference.

🇮🇳India shivam_tiwari

I checked MR 28 and looks fine to me. Moving it to RTBC.

🇮🇳India shivam_tiwari

I checked MR 19 changes from my side. It worked for me.
Applied following steps.

  • Created a telephone field
  • Added mask settings from the form render display setting.
  • Set (000) 000-0000 on Mask field in widget.
  • After submitting the node, got field output: (999) 999-9999
  • Enabled unmask on submit option from setting
  • After submitting the node, getting field output: 9999999999

Moving it to RTBC

🇮🇳India shivam_tiwari

I checked MR 7, it looks fine to me. Moving it to RTBC.

🇮🇳India shivam_tiwari

I checked MR 569. Looks fine so moving it to RTBC.

🇮🇳India shivam_tiwari

Applied changes on MR and moving its to Needs Review.

🇮🇳India shivam_tiwari

shivam_tiwari made their first commit to this issue’s fork.

🇮🇳India shivam_tiwari

I created MR according to suggestions, but it gets failed. So need to work here.

🇮🇳India shivam_tiwari

I got issue as mentioned here. Created MR 107. It is working for me. Adding screenshots of before and after applying changes. Moving this to Needs review state as pipeline is green.

🇮🇳India shivam_tiwari

Created MR 106 for the latest development version. Pipeline is green so moving it to Needs Review.

🇮🇳India shivam_tiwari

@rudi teschner Thanks for informing. I updated MR also related to it.

🇮🇳India shivam_tiwari

I checked 3.0.3 and 3,0.1 versions, but I am not getting this issue. Can anyone inform me of reproducing steps related to the latest versions?

🇮🇳India shivam_tiwari

@kristen pol I added description here and created MR 5 related to this. In this MR I added menu item. Moving this issue to Needs Review state.

🇮🇳India shivam_tiwari

Created MR for the latest development version. Moving it to Needs Review

🇮🇳India shivam_tiwari

I checked MR 86 related changes from my end, and it looks fine so moving it to RTBC.

🇮🇳India shivam_tiwari

I checked MR 8. Every this looks to me so moving it to RTBC.

🇮🇳India shivam_tiwari

@kalaiyarasithangavel Please provide steps to reproduce this issue.

🇮🇳India shivam_tiwari

@dhavalpanchal Can you please provide steps to reproduce of this issue?

🇮🇳India shivam_tiwari

@lionseaCan you please provide more details here? I checked it and not getting this issue.

🇮🇳India shivam_tiwari

@markie can you please check again? On patch related to comment #12 there are changes related to formatting. I ignored them and only created MR pertaining to changes.

🇮🇳India shivam_tiwari

I checked MR 8. Changes are working fine. Moving this to RTBC.

🇮🇳India shivam_tiwari

Thanks @debrup for review. I pushed changes on 3434353-automated-drupal-11 branch and created MR 2.

🇮🇳India shivam_tiwari

According to the right way, we are using MRs. So I created MR 110. Need to work here for resolve test failure issue.

🇮🇳India shivam_tiwari

I updated MR and created it for 3.0.x. Need to work here for resolving test failure issue.

🇮🇳India shivam_tiwari

I resolved conflict from the MR. Need to work on MR's test failure.

🇮🇳India shivam_tiwari

@esha_kundu I checked MR 10, according to issue there are 2 footer sections here as mentioned in comment #4. We should render footer section with the black background. According to the MR, we are going with the above one. This looks odd here. Looks like content section is going to the end of the page. Can you please update it?

🇮🇳India shivam_tiwari

I worked on it. At the time of creating an user by admin account, got error related to this issue: https://www.drupal.org/project/user_registrationpassword/issues/3467248 🐛 TypeError: Return value must be of type array, bool returned Active
After fixing that, checked here and it worked fine. Added my changes on MR 13, because previous MR code is outdated. Moving this issue to Needs Review

🇮🇳India shivam_tiwari

I worked on .module file and tested it. Resolved last comment also, updated code is working fine only phpunit test is failing so need to work on this only.

🇮🇳India shivam_tiwari

@oily Sorry for that, Firstly I updated MR according to the comments on the MR. Now I reverted the code according to you. Thanks for your quick response.

🇮🇳India shivam_tiwari

I applied MR related to this issue because now we are using MRs. Applied patch code on the MR.

🇮🇳India shivam_tiwari

shivam_tiwari made their first commit to this issue’s fork.

Production build 0.71.5 2024