- Issue created by @Dubs
- 🇯🇵Japan ptmkenny
Thanks for reporting this. Could you please create an MR instead of a patch so that the CI tests can be run?
- First commit to issue fork.
- Merge request !55Issue #3505848 by grevil, shivam_tiwari, dubs, lrwebks: Anonymous account generates deprecation warning → (Merged) created by shivam_tiwari
- 🇩🇪Germany Grevil
Thanks for finding this! Although, the current change would introduce a breaking change, as we would never enter the switch case. Currently, only the "default" case is problematic the other two are fine.
Although, I am starting to wonder where these settings are even coming from and if we really need them? There isn't even a settings page to set any of these. The code is from me, but I don't remember what this is for. I'll need to have a deeper look in a separate issue.
For now, we can temporarily move the early anonymous return inside the default case to avoid any breaking changes, in cases where someone set the "username_display_override_mode" manually via config. NW until adjusted.
- 🇩🇪Germany lrwebks Porta Westfalica
LGTM as a temporary solution, simple and effective.
-
grevil →
committed 01f1e3bd on 2.x authored by
shivam_tiwari →
Issue #3505848 by grevil, shivam_tiwari, dubs, lrwebks: Anonymous...
-
grevil →
committed 01f1e3bd on 2.x authored by
shivam_tiwari →
Automatically closed - issue fixed for 2 weeks with no activity.