- Issue created by @shweta__sharma
- Assigned to Jitender vaidh
- Status changed to Needs review
over 1 year ago 1:43pm 10 October 2023 - 🇮🇳India Jitender vaidh New Delhi
I have fixed the issue and summited patch.
- Issue was unassigned.
- 🇮🇳India jeetmail72 Noida
To make the code more readable, I removed the extra if conditions and format the code.
- 🇮🇳India Kanchan Bhogade
Hi,
I have checked for a patch 3392873-3 on the Drupal 10.2 version with Simple Classic Corporate Theme
The patch was applied successfully...Testing steps
- Install Drupal version
- Install the theme and set it as a default
- Add footer menus and check for the issue
- Apply patch and check for the same
Result:
The issue of "Footer menus are rendered multiple times" is fixed, and now the menu listing looks fine to me.
RTBC++
Attaching screenshot for referenceKeeping in "needs review" for code verification
- First commit to issue fork.
esha_kundu → changed the visibility of the branch 8.x-1.x to hidden.
- Merge request !10Issue #3392873 by jeetmail72, Jitender vaidh, esha_kundu: Footer region... → (Open) created by Esha_Kundu
Hello,
I've converted the patch ( 3392873-3.patch ) mentioned in #3 🐛 Footer region rendering multiples time in a page. Active into MR !10 as per Drupal standards. The issue was getting resolved with the provided patch also I agree with @jeetmail72 that the extra if conditions should be removed. I found the indentation was incorrect after applying the patch also I encountered an issue, when the four footer regions had content a horizontal scrolled appeared in the page which seems to be unnecessary in respect to users perspective. Thus I have resolve all this problems. The issue persisted in 2.0.1 version, hence updating the version. I've included ss for the overflow issue.
Please have a look.
Thanks- 🇮🇳India shivam_tiwari
@esha_kundu I checked MR 10, according to issue there are 2 footer sections here as mentioned in comment #4. We should render footer section with the black background. According to the MR, we are going with the above one. This looks odd here. Looks like content section is going to the end of the page. Can you please update it?