- 🇺🇸United States smustgrave
Won't this go against 🐛 Modules uninstall filter does not filter by machine name Needs work
- 🇬🇧United Kingdom jonathan1055
Yes 🐛 Modules uninstall filter does not filter by machine name Needs work would clash with this. Though that change will help this situation. To take the example in the issue summary - uninstalling Language
With the change in that other issue we can now search for 'locale' to find the module Interface Translation
So we could add the readable name into the "required by" as that might be useful for those whose interface is not English (particularly appropriate in this example). But we should definitely not remove the machine name.
- Status changed to Active
6 months ago 3:43am 28 September 2024 - 🇳🇿New Zealand quietone
Reading through this issue and 🐛 Modules uninstall filter does not filter by machine name Needs work I think this can be worked on.
- First commit to issue fork.
- 🇺🇸United States nicxvan
This seems pretty straightforward and seems helpful also for CMS.
I converted the patch to an MR.
- 🇺🇸United States smustgrave
Before
After
Attaching before/after screenshots to show this is working. Seems like a small enough tweak I don't know if tests are fully needed so going to move it forward.
- 🇬🇧United Kingdom jonathan1055
In #12 I said
... add the readable name into the "required by" as that might be useful ... but we should definitely not remove the machine name.
I think this needs to be discussed. I did something like this elsewhere, and the the solution we came to was to always show the readable name, but then add the machine name in parenthesis only if it was different. By 'different' I mean, ignore case, ignore word breaks and _ and if the string is still different the show it. That would mean we see "Interface Translation (locale)" but for things like Block Content you would not add (block_content). If I recall, there was only a few where the name differed, but for thos few it was very useful to see both.
- 🇳🇿New Zealand quietone
This is changing the UI so tagging for Usability and, as such, screenshots should be available to reviewers and committers from the Issue Summary.
The comment in #12/#19 still needs to be addressed but adding more details is expanding the scope of this issue. I think that should be in another issue. And while #8 is right that the machine name is removed, it is overall, an improvement for users of the uninstall page. This is a acceptable incremental step to improving the page for the user.
I do think this should be tested so there is no regression. There are many sibling issues which will be changing the text on the uninstall page so we should test as we go along. There is an existing test for the uninstall page, so hopefully, this will be straightforward,
\Drupal\Tests\system\Functional\Module\UninstallTest::testUninstallPage