Uninstall page shows module machine names as requirements

Won't this go against 🐛 Modules uninstall filter does not filter by machine name Needs work

Yes 🐛 Modules uninstall filter does not filter by machine name Needs work would clash with this. Though that change will help this situation. To take the example in the issue summary - uninstalling Language

With the change in that other issue we can now search for 'locale' to find the module Interface Translation

So we could add the readable name into the "required by" as that might be useful for those whose interface is not English (particularly appropriate in this example). But we should definitely not remove the machine name.

Reading through this issue and 🐛 Modules uninstall filter does not filter by machine name Needs work I think this can be worked on.

This seems pretty straightforward and seems helpful also for CMS.

I converted the patch to an MR.

Before

After

Attaching before/after screenshots to show this is working. Seems like a small enough tweak I don't know if tests are fully needed so going to move it forward.

In #12 I said

... add the readable name into the "required by" as that might be useful ... but we should definitely not remove the machine name.

I think this needs to be discussed. I did something like this elsewhere, and the the solution we came to was to always show the readable name, but then add the machine name in parenthesis only if it was different. By 'different' I mean, ignore case, ignore word breaks and _ and if the string is still different the show it. That would mean we see "Interface Translation (locale)" but for things like Block Content you would not add (block_content). If I recall, there was only a few where the name differed, but for thos few it was very useful to see both.

This is changing the UI so tagging for Usability and, as such, screenshots should be available to reviewers and committers from the Issue Summary.

The comment in #12/#19 still needs to be addressed but adding more details is expanding the scope of this issue. I think that should be in another issue. And while #8 is right that the machine name is removed, it is overall, an improvement for users of the uninstall page. This is a acceptable incremental step to improving the page for the user.

I do think this should be tested so there is no regression. There are many sibling issues which will be changing the text on the uninstall page so we should test as we go along. There is an existing test for the uninstall page, so hopefully, this will be straightforward,
\Drupal\Tests\system\Functional\Module\UninstallTest::testUninstallPage

I added an assertion.

FWIW, as a site builder and admin my preference is to see both. If I want or need to switch to Drush, then I don't want to have to go hunting for a module's machine name.

I checked MR and applied it as a patch. Now we can see module's human readable name in place of module's machine name on the module uninstall page. There is not any pipeline failure and test cases issue with MR so moving it to RTBC,
Adding screenshots of uninstall page related to my testing here.

There is a 'test-only changes' job which needs to be run and it should fail.

12 and 19 still haven't been addressed, I'm working on this now so assigning myself since there have been a few contributors recently.

12 and 19 still haven't been addressed...

Yeah, I wasn't sure if action should be taken to display both or not. It isn't clear. If we're displaying both, then the issue summary needs to be updated.

Ok I've pushed it up, I've attached a screenshot of the before and after

I have struggled with this a lot while uninstalling a module from the UI, it confuses when the name of the module is totally different from its machine name; you mostly go back and double-check it.

Having this added to the core would be very helpful to the site builders.