🇮🇳India @prashant.c

prashant.c → created an issue.

Codewise we can use Dependency injection in the defined Action plugins, that is the only thing I found and then you may move it to RTBC.

@bigbabert

A few observations while testing:

• Bulk translated "unpublished" node, it created translations for all the defined languages, can we somehow have these languages configured so that it bulk translates to selected languages only
• The translated nodes are getting published which is correct as per the configuration but the main node is still unpublished by selecting which I triggered the bulk translation, Should we consider publishing that one also?

prashant.c → created an issue.

prashant.c → created an issue.

I am thinking of the perspective, if we have multiple nodes to be translated, we can bulk translate and may be provide actions, something like "Translate & publish", "Translate & keep current state".

Thanks for the fix @vivek panicker I faced the same issue and applying the changes fixed it for me on Drupal 11.x.

However getting $url always empty https://git.drupalcode.org/project/ai_seo/-/merge_requests/3/diffs#529cdd96345bf7dcbbce6cbd38ccb30984c74ed4_232_229, maybe we could create another issue to address the URL not generating part.

prashant.c → created an issue.

We can close this issue in favor of #3504027 ✨ Add a Generate Alt text VBO plugin to generate alt text for selected medias Active , where it is already being addressed.

It would also be good to get some reviews from other community members. Changing status to NR.

It would also be good to get some reviews from other community members. Changing status to NR.

Somehow not able to see this new VBO action as an administrator:

1. Downloaded and installed VBO module
2. On the 3504027-add-a-vbo-pluginbranch
3. Visited Media listing page admin/content/media
4. Able to see other bulk operation actions like "Delete media", "Publish media" etc but "Generate Alt text" not listed

Not sure if i am missing something here.

IMO, the integration with VBO could be added as a submodule since we already have the submodule ai_image_bulk_alt_text for this purpose.
Including the VBO action integration within the main module would introduce a dependency on the contributed VBO module, requiring users to install it even if they do not always need it while using the default features of ai_image_bulk_alt_text

Tagging for steps to reproduce as well.

I agree with #7 🐛 Automators: "Edit when changed" ignored in "Advanced Mode (Token)" Active .

Since multiple tokens might be used, checking each token for changes would be challenging. Some tokens, like date/time tokens, will always have a different value, making validation even harder.

Instead, we could refine the checkbox label and description to better communicate its function. Additionally, we can include a note explaining the implications of enabling this option. By default, the checkbox should remain disabled, allowing site builders to enable it based on their specific needs.

I suggest something like:

Checkbox label: "Auto-Update on Change"

Description for checkbox: "By default, the initial value or manually set value remains unchanged, even if the base text field is updated. Check this option to automatically update the value whenever the base text field changes.
Note: Enabling this may trigger multiple calls to the LLM, potentially increasing API usage and costs."

Thankyou

Let a few other community members review it.

Thanks

prashant.c → created an issue.

I stumbled upon this issue and learned about the moderation process in AI calls. I also tried it in the explorer and read more about it in modules/contrib/ai/docs/developers/call_moderation.md.

While reviewing the code in the MR to understand the moderation workflow better, I noticed that since skip_moderation is a Boolean field, we can simplify this code

  if (!empty($configuration['skip_moderation']) && is_numeric($configuration['skip_moderation'])) {
      $this->skipModeration = (bool) $configuration['skip_moderation'];
    }
    else {
      $this->skipModeration = FALSE;
    }

to:

$this->skipModeration = !empty($configuration['skip_moderation']);

Thank you.

I am trying to replicate, but it seems to be working fine:

• Tried on Vanilla Drupal 11 instance
• Database server with search index already configured
• Configured the Milvus DB provider, which was connected successfully
• Added a new server with "AI server" and in that "Milvus DB" was available
• I have caching enabled, and while doing the above steps, I did not clear cache

Steps to reproduce: "Go back to search API index and expect to see VDB provider, but have to clear cache to see it." Are we expecting some new option in the Search index, in addition to the Search API server?

Am I missing something to reproduce this?

Thanks

prashant.c → created an issue.

Closing as duplicate.

prashant.c → created an issue.

prashant.c → created an issue.

If I understand correctly, we are discussing implementing functionality similar to the Filter Permissions module, which allows filtering permissions by role or provider (module).

Having this feature in Core would be highly beneficial, as it can be challenging to locate permissions related to a specific module. While the route "/admin/people/permissions/module/[module_name]" already exists for filtering by module, adding a select list at the top of the permissions page would improve usability.

prashant.c → created an issue.

Would like to know about the same we are also utilising the JSON API with nesting involved with includes and nesting has entity reference paragraph types which is taking average 2-3 seconds to give response for the first time.

It seems to me that with the existing collection, it is trying to check if it's compatible and checking the vector field's size and therefore not allowing it to be used.
Will try to dig further.

Sure Scott,

I will work on this and post it for review.

Thanks

prashant.c → created an issue.

prashant.c → created an issue.

Change the status to NW after adding a comment to the PR.

prashant.c → created an issue.

Faced this issue during the implementation of search autocomplete feature ( https://www.drupal.org/project/search_api_autocomplete → ).

We are also returning the search excerpt in the autocomplete responses, so we found that the excerpt is not being returned for anonymous users. Luckily found this issue and thanks to the patch #23 → .

Applied on our site which is on Drupal 10.3.11 and seems to be working fine so far.

Thanks

larowlan → credited prashant.c → .

Thanks a lot, @rolfo85, I was in the same boat, your https://www.drupal.org/project/smtp/issues/2823575#comment-11761199 💬 SMTP not working with goDaddy Closed: works as designed saved me after spending hours of debugging and chatting with he Godaddy support team.

It is not fixed yet, we are still getting the error and this code needs refactoring otherwise hardcoded path could create issues and additionally could be included by using namespaces.

Yes, this change will fix the issue ../vendor/phpmailer/phpmailer/src/SMTP.phpbut this path we need to fix like in my case the path is

require_once 'vendor/phpmailer/phpmailer/src/SMTP.php';

notice the "../" part in the fix.

Tried sending the email by making this change and it worked.

This is not the correct way to fix this. Because this is a library downloaded by the composer mailjet/mailjet-apiv3-php

We need to add the following to the composer.json file

"MailjetTools\\": "docroot/modules/contrib/mailjet/lib/mailjet-api-php/"

in the section

 "autoload-dev": {
        "psr-4": {
            "Drupal\\Tests\\PHPUnit\\": "tests/phpunit/src/",
            "MailjetTools\\": "docroot/modules/contrib/mailjet/lib/mailjet-api-php/"
        }
    },

Then refresh the autoload path by executing the command

composer dump-autoload

This should fix the error.

The change in the patch is correct but we should use Dependency Injection to load the service.

This fix needs to be pushed to the latest release of the module, got the same error as the method name specified in the routing file does not match the one in the controller.

tonypaulbarker → credited prashant.c → .

I was facing this issue when adding Select list field as a Facet.

Found an issue inside paragraphs it is working for user-defined fields but not working for entity reference fields, I tried with the Taxonomy terms reference field and it did not work be it is not handled currently in patch #159.

But it would be extremely beneficial to have support for entity reference fields also.

We are on Drupal core10.3.3, I initially thought that there might be something wrong with the way I am setting the condition but with paragraphs embedded on the Content types the patch submitted by #159 🐛 Controlled-by fields inside a Paragraph don't work Needs work worked great. Thanks a lot.

I have not tested thoroughly but at least the basic show/hide working.

Tested on:
Drupal 10.3.3
Conditional fields version: 4.0.0-alpha5

Patch worked with:

Single select
Multiselect
Even tested with widgets like (Chosen for select lists)

Hopefully, this can get tested and committed soon as every other site uses Paragraphs these days.

Thank you.

@saurav-drupal-dev because #9 and #13 were also able to replicate this so this issue is present, which Drupal version are you using to replicate this, and are you on fresh Drupal installation?

Thanks #21 and #22 for testing this. Kindly do not attach before/after files multiple times on any issues, if you see these were already attached above.

I tested it with the gin theme also, this issue is not theme-specific or Paragraphs module specific, this issue is generic, Whenever the fields have very long text which increases the width of the fields and hence the overlap.

The error says to run yarn build before push. Did you try that?

@amitrawat056
You can raise an MR with these changes and then the frontend experts can review these.

@atul_ghate

Thanks for working on this, let us wait for review(s) from someone else as well. Meanwhile, you may want to check why some Functional tests are failing.

• @f0ns Assigning no regions, do you mean from the themes info file or removing the content assigned to the regions?
• Because I replicated this by removing/disabling the blocks and content to all the regions and not by removing regions.
• The Submitted path does solve the issue, creating MR using the same.

However, I think appropriate conditions could also be added for the remaining part as well for the {{ page.pre_content }}{{ page.highlighted }}<code> and {{ page.content }}:

<div class="layout-container">
      {{ page.pre_content }}
      <div class="page-content clearfix">
        {{ page.highlighted }}
        {% if page.help %}
          <div class="help">
            {{ page.help }}
          </div>
        {% endif %}
        {{ page.content }}
      </div>
  </div>

prashant.c → made their first commit to this issue’s fork.

You may want to post the snippet here or push the changes so that someone can help or guide you through this.

I’ve been reflecting on the points in #10 📌 Rename the drupal.org (json:api) source type Active and wanted to share a few thoughts.

It might be beneficial to have distinct tabs for "Modules," "Themes," and "Recipes." Additionally, the "Browse" option could be placed in the "Appearance" menu or made accessible globally. I recall seeing an issue related to the placement of the "Browse" menu item, although I can’t seem to locate it at the moment.

If we decide to have a "Browse" option under "Appearance," it would make sense for it to take users to the "Themes" tab on the Browse page, while the existing "Browse" menu under "Extend" should take them to the "Modules" tab.

Lastly, it may be worth considering renaming the current "Drupal.org (JSON
)" tab to "Modules," as it lists and searches for modules only.

@chrisfromredfin I have also experienced this bug sometimes while working with PB but I think this is not related to the current issue and for this, we can create a separate issue.

Thank you!

Pipelines were failing for some unrelated reason, rebased the MR.

prashant.c → created an issue.

prashant.c → created an issue.

prashant.c → created an issue.

prashant.c → made their first commit to this issue’s fork.

prashant.c → changed the visibility of the branch 3456978-cursor-pointer-for to hidden.

I would say we can have a new option in field formatted settings in the "Display" list something like "Show start date and end date time only". Currently, we have these 3 options:

1. Display both start and end dates
2. Display start date only
3. Display both start and end dates

In this way, we do not need to introduce this new setting with a checkbox.

@maitri_2112 I have created new MR for 11.x and added changes from the patch #5 ✨ Add option to hide end date if the start date and end date are the same day but different times Needs work . Previews MRs had a lot of unnecessary files therefore made those hidden.

prashant.c → changed the visibility of the branch hide-day-if-same-date to hidden.

prashant.c → changed the visibility of the branch fixed-hide-day-issue-3458101-1 to hidden.

prashant.c → made their first commit to this issue’s fork.

Tried to test the logo on the Project Browser but the logo not appearing currently, It is because I do not see logo.pngin the source code of the Scheduler module https://git.drupalcode.org/project/scheduler/-/tree/2.x?ref_type=heads.

In the core/modules/navigation/src/Form/SettingsForm.phpthe code to add/delete records uses the "logo" as the entity name
$this->fileUsage->add($new_logo_managed, 'navigation', 'logo', 1);
$this->fileUsage->delete($previous_logo_managed, 'navigation', 'logo', 1);

The file usage is a view that requires it to be an entity type /admin/structure/views/view/files/edit/page_2 which is throwing an error.

Now I am not sure whether this is a bug in the Navigation module or core itself that allows an entity name in File usage that does not even exist.

Yes, there is an issue with this because the entity type that is being used for this file is logowhich does not exist hence the error.

I added MR for the 11.x, change the condition to check whether the JSON is valid or not. Changes need to be reviewed.

Thanks, @pameeela for the rebase, pipelines passed, moving to NR.

Is this issue still valid? Because now the value is being returned in the following way:

 public function getValue(ResultRow $values, $field = NULL) {
    // Note:  1 is subtracted from the counter start value below because the
    // counter value is incremented by 1 at the end of this function.
    $count = is_numeric($this->options['counter_start']) ? $this->options['counter_start'] - 1 : 0;
    $pager = $this->view->pager;
    // Get the base count of the pager.
    if ($pager->usePager()) {
      $count += ($pager->getItemsPerPage() * $pager->getCurrentPage() + $pager->getOffset());
    }
    // Add the counter for the current site.
    $count += $this->view->row_index + 1;

    return $count;
  }

prashant.c → made their first commit to this issue’s fork.

prashant.c → created an issue.

@andrew.farquharson I tried it on branch 11.x but could not reproduce. Will try on the Drupal 10 and on https://www.drupal.org/project/drupal/releases/11.0.1

@jan kellermann

Not sure about the files you mentioned in #80 🐛 Do not prepopulate the user register form with the email address and username of the last person who registered using the same web browser Needs work because the other methods from the library could have been used on these forms.

I also do think that sorting would be tricky as the terms already have weights which might create confusion and for the scope of this issue Filtering feature only we should go with I guess.

Seems there are related or may be similar: https://www.drupal.org/project/drupal/issues/3397718 🐛 "To log in to this site, your browser must accept cookies from the domain" error message displayed when user goes back and reload the page Needs work

PR is failing it is showing the test core/modules/block/tests/src/Functional/BlockCacheTest.phpfailing but locally when I executed all the tests passed. Not sure what is causing these test to fail in the pipelines.

Tested the MR with i think originally the changes from taken from patch submitted in #55 🐛 Do not prepopulate the user register form with the email address and username of the last person who registered using the same web browser Needs work .

It is fixing the issue of this autocomplete and the username and email address are no longer auto-filled during user registration and browser no longer has values stored in localstorage for Drupal.visitor.mail and Drupal.visitor.name.

Steps to reproduce

1. Login as admin and go to /admin/config/people/accounts
2. Select "Visitors" in "Who can register accounts?" and save
3. Now visit the site as anonymous user and register as a user from "/user/register"
4. Logout with the currently logged in user and try to register another user, you will see that "Email address" and "Username" fields are autofilled with the values you filled to register your previous user
5. Also in the browser's local storage there are 2 propertiesDrupal.visitor.mail and Drupal.visitor.name where these values are also stored.

Rebase the branch 2409107-11x with latest code from 11.x. Need to see if any tests are failing.

prashant.c → made their first commit to this issue’s fork.