Merge Requests

More

Recent comments

🇮🇳India prashant.c Dharamshala

Thanks a lot, @rolfo85, I was in the same boat, your https://www.drupal.org/project/smtp/issues/2823575#comment-11761199 💬 SMTP not working with goDaddy Closed: works as designed saved me after spending hours of debugging and chatting with he Godaddy support team.

🇮🇳India prashant.c Dharamshala

It is not fixed yet, we are still getting the error and this code needs refactoring otherwise hardcoded path could create issues and additionally could be included by using namespaces.

🇮🇳India prashant.c Dharamshala

Yes, this change will fix the issue ../vendor/phpmailer/phpmailer/src/SMTP.phpbut this path we need to fix like in my case the path is

require_once 'vendor/phpmailer/phpmailer/src/SMTP.php';

notice the "../" part in the fix.

Tried sending the email by making this change and it worked.

🇮🇳India prashant.c Dharamshala

This is not the correct way to fix this. Because this is a library downloaded by the composer mailjet/mailjet-apiv3-php

We need to add the following to the composer.json file

"MailjetTools\\": "docroot/modules/contrib/mailjet/lib/mailjet-api-php/"

in the section

 "autoload-dev": {
        "psr-4": {
            "Drupal\\Tests\\PHPUnit\\": "tests/phpunit/src/",
            "MailjetTools\\": "docroot/modules/contrib/mailjet/lib/mailjet-api-php/"
        }
    },

Then refresh the autoload path by executing the command

composer dump-autoload

This should fix the error.

🇮🇳India prashant.c Dharamshala

The change in the patch is correct but we should use Dependency Injection to load the service.

🇮🇳India prashant.c Dharamshala

This fix needs to be pushed to the latest release of the module, got the same error as the method name specified in the routing file does not match the one in the controller.

🇮🇳India prashant.c Dharamshala

I was facing this issue when adding Select list field as a Facet.

🇮🇳India prashant.c Dharamshala

Found an issue inside paragraphs it is working for user-defined fields but not working for entity reference fields, I tried with the Taxonomy terms reference field and it did not work be it is not handled currently in patch #159.

But it would be extremely beneficial to have support for entity reference fields also.

🇮🇳India prashant.c Dharamshala

We are on Drupal core10.3.3, I initially thought that there might be something wrong with the way I am setting the condition but with paragraphs embedded on the Content types the patch submitted by #159 🐛 Controlled-by fields inside a Paragraph don't work Needs work worked great. Thanks a lot.

I have not tested thoroughly but at least the basic show/hide working.

Tested on:
Drupal 10.3.3
Conditional fields version: 4.0.0-alpha5

Patch worked with:

Single select
Multiselect
Even tested with widgets like (Chosen for select lists)

Hopefully, this can get tested and committed soon as every other site uses Paragraphs these days.

Thank you.

🇮🇳India prashant.c Dharamshala

@saurav-drupal-dev because #9 and #13 were also able to replicate this so this issue is present, which Drupal version are you using to replicate this, and are you on fresh Drupal installation?

🇮🇳India prashant.c Dharamshala

Thanks #21 and #22 for testing this. Kindly do not attach before/after files multiple times on any issues, if you see these were already attached above.

🇮🇳India prashant.c Dharamshala

I tested it with the gin theme also, this issue is not theme-specific or Paragraphs module specific, this issue is generic, Whenever the fields have very long text which increases the width of the fields and hence the overlap.

🇮🇳India prashant.c Dharamshala

The error says to run yarn build before push. Did you try that?

🇮🇳India prashant.c Dharamshala

@amitrawat056
You can raise an MR with these changes and then the frontend experts can review these.

🇮🇳India prashant.c Dharamshala

@atul_ghate

Thanks for working on this, let us wait for review(s) from someone else as well. Meanwhile, you may want to check why some Functional tests are failing.

🇮🇳India prashant.c Dharamshala
  • @f0ns Assigning no regions, do you mean from the themes info file or removing the content assigned to the regions?
  • Because I replicated this by removing/disabling the blocks and content to all the regions and not by removing regions.
  • The Submitted path does solve the issue, creating MR using the same.


However, I think appropriate conditions could also be added for the remaining part as well for the {{ page.pre_content }}{{ page.highlighted }}<code> and {{ page.content }}:

<div class="layout-container">
      {{ page.pre_content }}
      <div class="page-content clearfix">
        {{ page.highlighted }}
        {% if page.help %}
          <div class="help">
            {{ page.help }}
          </div>
        {% endif %}
        {{ page.content }}
      </div>
  </div>
🇮🇳India prashant.c Dharamshala

prashant.c made their first commit to this issue’s fork.

🇮🇳India prashant.c Dharamshala

You may want to post the snippet here or push the changes so that someone can help or guide you through this.

🇮🇳India prashant.c Dharamshala

I’ve been reflecting on the points in #10 📌 Rename the drupal.org (json:api) source type Active and wanted to share a few thoughts.

It might be beneficial to have distinct tabs for "Modules," "Themes," and "Recipes." Additionally, the "Browse" option could be placed in the "Appearance" menu or made accessible globally. I recall seeing an issue related to the placement of the "Browse" menu item, although I can’t seem to locate it at the moment.

If we decide to have a "Browse" option under "Appearance," it would make sense for it to take users to the "Themes" tab on the Browse page, while the existing "Browse" menu under "Extend" should take them to the "Modules" tab.

Lastly, it may be worth considering renaming the current "Drupal.org (JSON
)" tab to "Modules," as it lists and searches for modules only.

🇮🇳India prashant.c Dharamshala

@chrisfromredfin I have also experienced this bug sometimes while working with PB but I think this is not related to the current issue and for this, we can create a separate issue.

Thank you!

🇮🇳India prashant.c Dharamshala

Pipelines were failing for some unrelated reason, rebased the MR.

🇮🇳India prashant.c Dharamshala

prashant.c changed the visibility of the branch 3456978-cursor-pointer-for to hidden.

🇮🇳India prashant.c Dharamshala

I would say we can have a new option in field formatted settings in the "Display" list something like "Show start date and end date time only". Currently, we have these 3 options:

  1. Display both start and end dates
  2. Display start date only
  3. Display both start and end dates

In this way, we do not need to introduce this new setting with a checkbox.

🇮🇳India prashant.c Dharamshala

@maitri_2112 I have created new MR for 11.x and added changes from the patch #5 Add option to hide end date if the start date and end date are the same day but different times Needs work . Previews MRs had a lot of unnecessary files therefore made those hidden.

🇮🇳India prashant.c Dharamshala

prashant.c changed the visibility of the branch hide-day-if-same-date to hidden.

🇮🇳India prashant.c Dharamshala

prashant.c changed the visibility of the branch fixed-hide-day-issue-3458101-1 to hidden.

🇮🇳India prashant.c Dharamshala

Tried to test the logo on the Project Browser but the logo not appearing currently, It is because I do not see logo.pngin the source code of the Scheduler module https://git.drupalcode.org/project/scheduler/-/tree/2.x?ref_type=heads.

🇮🇳India prashant.c Dharamshala

In the core/modules/navigation/src/Form/SettingsForm.phpthe code to add/delete records uses the "logo" as the entity name
$this->fileUsage->add($new_logo_managed, 'navigation', 'logo', 1);
$this->fileUsage->delete($previous_logo_managed, 'navigation', 'logo', 1);

The file usage is a view that requires it to be an entity type /admin/structure/views/view/files/edit/page_2 which is throwing an error.

Now I am not sure whether this is a bug in the Navigation module or core itself that allows an entity name in File usage that does not even exist.

🇮🇳India prashant.c Dharamshala

Yes, there is an issue with this because the entity type that is being used for this file is logowhich does not exist hence the error.

🇮🇳India prashant.c Dharamshala

I added MR for the 11.x, change the condition to check whether the JSON is valid or not. Changes need to be reviewed.

🇮🇳India prashant.c Dharamshala

Thanks, @pameeela for the rebase, pipelines passed, moving to NR.

🇮🇳India prashant.c Dharamshala

Is this issue still valid? Because now the value is being returned in the following way:

 public function getValue(ResultRow $values, $field = NULL) {
    // Note:  1 is subtracted from the counter start value below because the
    // counter value is incremented by 1 at the end of this function.
    $count = is_numeric($this->options['counter_start']) ? $this->options['counter_start'] - 1 : 0;
    $pager = $this->view->pager;
    // Get the base count of the pager.
    if ($pager->usePager()) {
      $count += ($pager->getItemsPerPage() * $pager->getCurrentPage() + $pager->getOffset());
    }
    // Add the counter for the current site.
    $count += $this->view->row_index + 1;

    return $count;
  }
🇮🇳India prashant.c Dharamshala

prashant.c made their first commit to this issue’s fork.

🇮🇳India prashant.c Dharamshala

@andrew.farquharson I tried it on branch 11.x but could not reproduce. Will try on the Drupal 10 and on https://www.drupal.org/project/drupal/releases/11.0.1

🇮🇳India prashant.c Dharamshala

I also do think that sorting would be tricky as the terms already have weights which might create confusion and for the scope of this issue Filtering feature only we should go with I guess.

🇮🇳India prashant.c Dharamshala

PR is failing it is showing the test core/modules/block/tests/src/Functional/BlockCacheTest.phpfailing but locally when I executed all the tests passed. Not sure what is causing these test to fail in the pipelines.

🇮🇳India prashant.c Dharamshala

Tested the MR with i think originally the changes from taken from patch submitted in #55 🐛 Do not prepopulate the user register form with the email address and username of the last person who registered using the same web browser Needs work .

It is fixing the issue of this autocomplete and the username and email address are no longer auto-filled during user registration and browser no longer has values stored in localstorage for Drupal.visitor.mail and Drupal.visitor.name.

Steps to reproduce

  1. Login as admin and go to /admin/config/people/accounts
  2. Select "Visitors" in "Who can register accounts?" and save
  3. Now visit the site as anonymous user and register as a user from "/user/register"
  4. Logout with the currently logged in user and try to register another user, you will see that "Email address" and "Username" fields are autofilled with the values you filled to register your previous user
  5. Also in the browser's local storage there are 2 propertiesDrupal.visitor.mail and Drupal.visitor.name where these values are also stored.
🇮🇳India prashant.c Dharamshala

Rebase the branch 2409107-11x with latest code from 11.x. Need to see if any tests are failing.

🇮🇳India prashant.c Dharamshala

Thanks @vidorado for addressing this, if the margin one is present on other forms as well then it is out of scope for this. IMO it is good to go for RTBC.

🇮🇳India prashant.c Dharamshala

I think this is specific to the Claro theme because in Olivero this works fine (it might be due to Olivero having a different layout for this).

🇮🇳India prashant.c Dharamshala

Added the check to test the existence of the description and that should be sufficient I guess.

🇮🇳India prashant.c Dharamshala

Overall, it looks great, however, I have a few points:

  1. Input is too close to the "Filter" button, on focus the focus highlight overlaps, checked with multiple themes.
  2. It would be good to have a placeholder as well to clarify what can be searched in it.
🇮🇳India prashant.c Dharamshala

The path submitted in #3 Media Library widget does not render svg images Needs work resolves the issue only for the Point 1 (Media library) mentioned in #25 Media Library widget does not render svg images Needs work

🇮🇳India prashant.c Dharamshala

This is a major issue while using SVG images, I faced this while working with SVG images in one of the projects which is using Drupal 10.3.2, but this exists in later versions also. SVG images do not at all appear on the following:

  1. Media library
  2. Media field
  3. Media entity listing page
  4. Media render (this in on node page)
🇮🇳India prashant.c Dharamshala

@nikit

I tried to replicate this on Drupal 10.3.1 but could not.

  1. Did you download the libraries to your Drupal root folder -> libraries -> tempus-dominus?
  2. Did you try enabling the "Use CDN for Tempus dominas" on the module's settings page admin/config/content/bootstrap_datetime_picker

Thanks

🇮🇳India prashant.c Dharamshala

Currently other than adding the version number in the module info I do not see any other changes required to make it compatible with D11. Tested it locally with 11.x, worked properly.

For any specific issues related to D11, feel free to create a new issue in the issue queue.

Thanks.

🇮🇳India prashant.c Dharamshala

prashant.c changed the visibility of the branch project-update-bot-only to hidden.

🇮🇳India prashant.c Dharamshala

Trying to give credit to all the contributors but during branch renaming some mess happened and I was unable to provide credits even by changing the commit message, hope you will understand. Thanks and apologies.

🇮🇳India prashant.c Dharamshala

Thanks to all the contributors.

🇮🇳India prashant.c Dharamshala

prashant.c changed the visibility of the branch 3663404-cannot-select-sunday-as-date to hidden.

🇮🇳India prashant.c Dharamshala

prashant.c changed the visibility of the branch 4.x to hidden.

🇮🇳India prashant.c Dharamshala

Thanks @umekikazuya for raising and providing the fix.

🇮🇳India prashant.c Dharamshala

Closing this in favour of https://www.drupal.org/project/bootstrap_datetime_picker/issues/3459565 📌 Automated Drupal 11 compatibility fixes for bootstrap_datetime_picker Needs review

🇮🇳India prashant.c Dharamshala

Rebased the branch with 2.0.x not sure why it is showing multiple changes. It is taking this commit also https://git.drupalcode.org/project/project_browser/-/merge_requests/568/....

Can someone review if working fine, we can move it to RTBC.

🇮🇳India prashant.c Dharamshala

Looks good to me. In my opinion, we can move it to RTBC.

🇮🇳India prashant.c Dharamshala

@paraderojether

Thanks somehow mov files are not working, not sure it is for me only. Could you please attach some gif or png/jpgs.

🇮🇳India prashant.c Dharamshala

@pameeela wrong screenshot attached :). Without description is good but see #8 🐛 New User Logout confirm Form is misleading Needs work , we have to provide the description.

🇮🇳India prashant.c Dharamshala

I also face the same issue on 10.3.x. I will also try to review this MR. Thanks!

🇮🇳India prashant.c Dharamshala

Should we cover the bug in this issue itself or create a new one?

🇮🇳India prashant.c Dharamshala

Should this be "Modules & Themes"?

From the site builder's point of view, if we put "Modules & Themes" under one tab, he/she will have to apply some additional filter to filter out the Modules or Themes only.

But because the tabs are for sources and from D.O. if both are being pulled then it makes sense to display both and further filtering of (modules/themes only) needs to be considered.

🇮🇳India prashant.c Dharamshala

It would be helpful if someone could post screenshots of the issue before (by reproducing the problem) and after (after applying the changes in the MR).

🇮🇳India prashant.c Dharamshala

I do not think "Show all items"/"Show all widgets" will make sense because we are not showing all the items at one go, we are providing a way to add another/more item (which is one at a time). So in my opinion "Add another item" is concise and clear to every type of user (technical/non-technical).

Regarding the default enabling option, we may wait for feedback. :)

🇮🇳India prashant.c Dharamshala

@lostcarpark Yes, the "Drupal Core" source also needs discussion because I agree with you for a non-technical user it does matter whether it's core or contributed, for them, it's a Module.

🇮🇳India prashant.c Dharamshala

Tested with all the 3 sources and seems working as expected, only those filters are displayed per source that is available or relevant.

The branch needs a rebase.

🇮🇳India prashant.c Dharamshala

I am wondering if this issue will go into the Claro theme. Because on the Olivero theme, it is displaying properly. So looks like a theme-specific issue to me.

🇮🇳India prashant.c Dharamshala

@rkoller
+1 for this, for site builders or non-technical users this label is meaning less. Because this source is listing only modules it is better to rename it to "Modules".

From the usability point of view in the source tabs, I observed a few more things that consider to be improved:

  1. Currently the label for source and total results are displayed all together which giving impression that it is a single label. We can consider having the label and results count separated with parenthesis something like Modules(5630 results) or Modules(5630), Recipes(85 results), or Recipes(85), this would make it more user-friendly. "results" word also seems repetitive.
  2. Show a short summary about each source for each source label to make it clear what Modules, Recipes will do.

Thanks!

Production build 0.71.5 2024