- ๐ฎ๐ณIndia prashant.c Dharamshala
prashant.c โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia prashant.c Dharamshala
Was looking for the generic methods for the same. I have raised an MR with some additional checks, like the path should be internal only. Once this is reviewed, we can go ahead with writing tests also.
Current changes need to be reviewed
- ๐บ๐ธUnited States smustgrave
Seems to have pipeline failures. May be worth converting a spot where this is needed to help show why it should be added.
- ๐บ๐ธUnited States smustgrave
Test coverage is good, but I mean where in core could this be needed? Typically I see that functions that aren't called anywhere in core get deprecated and removed. So think we need least a spot or two in core where this is needed.
- ๐ฎ๐ณIndia prashant.c Dharamshala
I just did a keyword search in the codebase, and a few files in which this could be used are:
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/block...
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/lib/Drupal/Co...
- https://git.drupalcode.org/project/drupal/-/blob/11.x/core/modules/conte...
There could be many more like these.
- ๐บ๐ธUnited States smustgrave
Don't have to convert all but a few help show usefulness
- ๐ฎ๐ณIndia prashant.c Dharamshala
Was trying to find occurences of
$url->setOption('query', \Drupal::destination()->getAsArray())
and
$url->setOption('query', ['destination' => 'other/path')
, could only find one, pushed that change.Tests were added, so I am removing the tag for now.