#DX (Developer Experience)

Okay tests still failing, and I think its because maybe we still have a flaw here.

The commenting around the BC change in LibraryDiscoveryParser::setOverrideValue() is a bit unclear to me. It seems like it wants to check for the workaround like

libraries-override:
  contextual/drupal.contextual-links:
    css:
      component:
        /core/themes/stable/css/contextual/contextual.module.css: false

So to me that means it should be checking if the override like /core/themes/stable/css/contextual/contextual.module.css is from the base theme of the current theme (ie, direct parent theme, not grandparent), and if so, then throw the deprecation, but continue to work.

Is that the correct intention? If so I think its not working like that quite yet. Happy to dig a bit but wanted to check if that's the right direction first.

Thanks!

1. Started converting to MR
2. Updated some tests but more still fail, e.g. phpunit -c core/phpunit.xml core/tests/Drupal/KernelTests/Core/Asset/LibraryDiscoveryIntegrationTest.php --filter=testBaseThemeLibrariesOverrideInSubTheme
3. Updated issue summary to target D12 for removal of BC layer

Reroll for 10.3 with latest changes applied from issues/3487031 🐛 Performance Degraded after update to twig 3.14.2 Active

the conversion to OOP hooks broke this MR, corresponding code should be moved to the class files, I can take a look later this week

Re-solved the threads but appears to need a manual rebase (200 commits back), surprised the bot never picked it up.

I just ran into this again today 🙈😬

I have rebased and fixed the missing comment mentioned in #166.

Thanks @traviscarden :)

Congratulations on your first Core commit, @secretsayan! 😄

Committed and pushed 6b6facdc29e to 11.x and 167dc216f33 to 11.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.