#DX (Developer Experience)

We have \Drupal\Core\Entity\SynchronizableInterface since 2018 which is exactly this.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

I've split two issues for the missing tests.

1. ✨ Implement MatchesOtherConfigValue tests Active
2. ✨ Implement NoEntitiesExistYetWithHigherCardinality tests Active

Although there is some missing test:

1. The constraint MatchesOtherConfigValue needs tests
2. The constraint NoEntitiesExistYetWithHigherCardinality needs tests

Our tests are green :x

Rerolled

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

So glad to see this moving forward again! 🤓

Also, I had to do this yesterday:

  protected static $configSchemaCheckerExclusions = [
    // @todo Core bug: this is missing config schema: ``type: field.storage_settings.uri` does not exist! This is being fixed in https://www.drupal.org/project/drupal/issues/3324140.
    'field.storage.entity_test.test_required__file_uri',
    'field.storage.entity_test.test_optional__file_uri',
    // @todo Core bug: this is missing config schema: ``type: field.storage_settings.uuid` does not exist! This is being fixed in https://www.drupal.org/project/drupal/issues/3324140.
    'field.storage.entity_test.test_required__uuid',
    'field.storage.entity_test.test_optional__uuid',
  ];

That's for XB over at 📌 Provide visibility into which (core) field type props can be mapped into Content Type Templates vs not Active , fixing this would allow me to remove those exclusions!

With the move to Attributes, I think this is safe to close

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

This is not actionable until decisions are made with solid answers WRT the concerns I surfaced.

Answered some of the comments.

This is absolutely still relevant. There is no proper documentation on plugin types the way that there is for hooks.

Nobody has worked on it because it's a big undertaking.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Needs reroll to MR

I think most problems with this should be resolved when we get #2414951 working. I think that means we can close this issue.

Not too sure what's causing those unrelated test failures!

Hm … me neither, but this seems like yet another case of https://www.drupal.org/project/gitlab_templates → being wrong and running contrib module's test suites differently for non-maintainer-pushed commits than for maintainer-pushed commits 😬 (I wish I was kidding!)

Also: you're right, I misjudged, this is not a trivial move. 🙈 Thanks for removing the tag.

But … this issue is novice-like in the sense that you were able to do this without deep XB knowledge! 😄 What do you think would be a more appropriate tag? 😊

I could replicate the issue. The problem is dependencies:

Running `npm ls @typescript-eslint/eslint-plugin` shows these:

@drupal/experience_builder@0.0.0 /Users/tina/Sites/PNX/drupal-contrib/experience_builder/ui
├── @typescript-eslint/eslint-plugin@8.26.0
├─┬ eslint-config-react-app@7.0.1
│ ├── @typescript-eslint/eslint-plugin@5.62.0
│ └─┬ eslint-plugin-jest@25.7.0
│   └── @typescript-eslint/eslint-plugin@8.26.0 deduped invalid: "^4.0.0 || ^5.0.0" from node_modules/eslint-plugin-jest
└─┬ typescript-eslint@7.18.0
  └── @typescript-eslint/eslint-plugin@7.18.0

typescript-eslint can be updated (done in MR), but eslint-config-react-app doesn't have an update (yet? might be abandonned). I've added an override which seems to work (peerDependencies didn't work), but that may need a follow up task to remove when we can.
Otherwise we may be able to use eslint-plugin-react instead.

I now get linting errors as expected:

...experience_builder/ui/src/hooks/useCopyPasteComponents.ts
  65:14  warning  'err' is defined but never used  @typescript-eslint/no-unused-vars

...experience_builder/ui/src/services/componentAndLayout.ts
  55:18  warning  'err' is defined but never used  @typescript-eslint/no-unused-vars

Not too sure what's causing those unrelated test failures!

I would say this isn't so Novice, the tests are quite complicated. I had to:

1. Swap to standard profile
2. Modify cache tags in existing tests to match
3. Enable some new modules
4. Port over helper functions

Locally these tests are throwing a bunch of warnings but I'm testing out the ddev XB setup so it might be related to that.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!