I merged the part for MapContextDefinition, still need to determine what is necessary for the ListContextDefinition. It's probably similar.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
I'm going to leave that failing test until I can get another set of eyes that this needs to switch.
We need to test this with json_as_string and yaml_as_string data types... hmmmmm...
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
My understanding is artifacts are generally something that AI creates. In our case we also want pointers to things that may already exist and that we are modifying. Like if we ask AI to create a node, to me it's an artifact, if we ask it to load a node, is it still an artifact? Even if in both cases we intend to modify and save them. I just want to make sure we are using the correct terminology and would love to find some precedent somewhere.
michaellander → created an issue.
jurgenhaas → credited michaellander → .
jurgenhaas → credited michaellander → .
jurgenhaas → credited michaellander → .
Think maybe there's an issue here still.
Is this supposed to be == instead of !==?
if ($data_type !== 'yaml_as_string') {
return AppliesResult::notApplicable('The data type is not YAML.');
}
and
if ($data_type !== 'json_as_string') {
return AppliesResult::notApplicable('The data type is not JSON.');
}
Since we are saying to not deserialize them if they are one of these two types.
michaellander → changed the visibility of the branch 3540064-rename-arguments-and-provides to hidden.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue.
michaellander → created an issue. See original summary → .
michaellander → created an issue.
michaellander → created an issue. See original summary → .
marcus_johansson → credited michaellander → .
kristen pol → credited michaellander → .
@marcus_johansson, i'm good with it being merged
I've got an initial greenfield version of this to put up, that includes parts I cherrypicked from the Rules module. My version does not work through all the BC issues yet, which is the elephant in the room. I do have ideas around how we can sort out many of the known BC issues, but it's the part I am still nervous about. The requirements are not set in stone yet either and we should confirm there's agreement before we go too far into the solution.
michaellander → created an issue.
Let me follow up with @gantal. I know locally he was testing them against 3.0.x but he was running into a number of automated test failures and was trying to locate the issue. Will get you an answer shortly.
That sounds good! 3.0.x can be the new target.
if ($this->moduleHandler->moduleExists('ai_agents')) {
What's the plan with this and is it something I can help with now?