Config validation for ECA models

Created on 9 May 2024, about 1 year ago

Problem/Motivation

Let's build the schema and everything else that's required to be able to validate ECA config entities.

Note: this is related to πŸ“Œ Reconsider the structure of separated eca config entities Active in terms of the proprietary data should not be validated, regardless where this will eventually be stored.

πŸ“Œ Task
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jurgenhaas
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen
  • First commit to issue fork.
  • Merge request !459#3446331 Adjust schema constraints β†’ (Merged) created by lammensj
  • Pipeline finished with Success
    7 months ago
    Total: 503s
    #363673
  • Pipeline finished with Failed
    7 months ago
    Total: 662s
    #367168
  • Pipeline finished with Failed
    7 months ago
    Total: 648s
    #367178
  • Pipeline finished with Failed
    7 months ago
    Total: 724s
    #367184
  • Pipeline finished with Success
    7 months ago
    Total: 897s
    #367195
  • Pipeline finished with Failed
    7 months ago
    Total: 733s
    #367973
  • Pipeline finished with Success
    7 months ago
    Total: 3786s
    #367988
  • Pipeline finished with Success
    7 months ago
    Total: 679s
    #368125
  • Pipeline finished with Success
    5 months ago
    Total: 209s
    #420711
  • πŸ‡ΊπŸ‡ΈUnited States michaellander
  • Pipeline finished with Failed
    4 months ago
    Total: 479s
    #433778
  • Pipeline finished with Failed
    4 months ago
    Total: 228s
    #435061
  • Pipeline finished with Failed
    4 months ago
    Total: 253s
    #435069
  • Pipeline finished with Failed
    4 months ago
    Total: 530s
    #435074
  • Pipeline finished with Failed
    4 months ago
    Total: 545s
    #436106
  • πŸ‡ΊπŸ‡ΈUnited States michaellander
  • πŸ‡ΊπŸ‡ΈUnited States michaellander
  • Pipeline finished with Canceled
    4 months ago
    Total: 130s
    #442406
  • Pipeline finished with Failed
    4 months ago
    Total: 625s
    #442407
  • Pipeline finished with Failed
    4 months ago
    Total: 863s
    #444824
  • πŸ‡ΊπŸ‡ΈUnited States michaellander
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    Rebased for 3.0.x

  • Pipeline finished with Canceled
    2 months ago
    Total: 66s
    #489354
  • Pipeline finished with Failed
    2 months ago
    Total: 460s
    #489355
  • Pipeline finished with Failed
    21 days ago
    Total: 462s
    #525386
  • Pipeline finished with Failed
    21 days ago
    Total: 477s
    #525414
  • Pipeline finished with Failed
    21 days ago
    Total: 429s
    #525534
  • Pipeline finished with Failed
    21 days ago
    Total: 620s
    #525543
  • Pipeline finished with Failed
    21 days ago
    Total: 339s
    #525548
  • Pipeline finished with Failed
    21 days ago
    Total: 453s
    #525553
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    We're pretty close now. There are a few missing schema errors left when PhpUnit is trying to go through all our test cases. But I have merged all other related issues from 🌱 [META] Implement complete coverage of validatable config schema across plugins and entities Active so that we can finally go through all of these remaining issues.

    @michaellander thank you so much for everything you've done here together with your team. This has been a massive effort.

  • Pipeline finished with Failed
    21 days ago
    Total: 607s
    #525850
  • Pipeline finished with Canceled
    20 days ago
    Total: 338s
    #526077
  • Pipeline finished with Failed
    20 days ago
    Total: 474s
    #526087
  • Pipeline finished with Failed
    19 days ago
    Total: 485s
    #527112
  • Pipeline finished with Failed
    19 days ago
    Total: 408s
    #527196
  • Pipeline finished with Failed
    19 days ago
    Total: 504s
    #527241
  • Pipeline finished with Failed
    19 days ago
    Total: 524s
    #527284
  • Pipeline finished with Failed
    19 days ago
    Total: 607s
    #527299
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    This is now mostly done, only 4 tests are still failing like with this message:

    1) Drupal\Tests\eca_workflow\Kernel\WorkflowTransitionTest::testExecuteWithNoEntity
    Drupal\Component\Plugin\Exception\PluginNotFoundException: The "eca_workflow_transition:editorial" plugin does not exist. Valid plugin IDs for Drupal\Core\Action\ActionManager are: node_make_unsticky_action, node_make_sticky_action, node_promote_action, node_unpromote_action, user_unblock_user_action, user_remove_role_action, user_cancel_user_action, user_block_user_action, user_add_role_action, entity:unpublish_action:node, entity:save_action:node, entity:save_action:user, entity:publish_action:node, action_message_action, action_goto_action, action_send_email_action, entity:delete_action:node
    /builds/project/eca/web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php:53
    /builds/project/eca/web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryCachedTrait.php:28
    /builds/project/eca/web/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php:16
    /builds/project/eca/web/core/lib/Drupal/Component/Plugin/PluginManagerBase.php:85
    /builds/project/eca/src/PluginManager/Action.php:178
    /builds/project/eca/modules/workflow/tests/src/Kernel/WorkflowTransitionTest.php:101
    

    I'lΓΆl fix that over the weekend, and then we should be able to finish this off. What a big one !!!

  • Pipeline finished with Success
    18 days ago
    Total: 397s
    #527910
  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen

    Yeah, all tests are green. What an achievement. Thank you so much @michaellander, @lammensj, and everybody else who made this possible.

  • πŸ‡©πŸ‡ͺGermany jurgenhaas Gottmadingen
Production build 0.71.5 2024