.val().length in JavaScript counts)We found this issue with some custom JavaScript which shows to the user a counter how many characters are left. The counter shows "0 characters left" but the PHP validation claims that too many characters are used.
Problem is in FormValidator class the method performRequiredValidation(). mb_strlen($elements['#value']) counts evey new line as two characters. As suggested here https://stackoverflow.com/questions/68618268/mb-strlen-counts-new-lines-... the numbers of new lines should be deducted so that each new line becomes counted ony once:
if (isset($elements['#maxlength'])) {
$countCharacters = mb_strlen($elements['#value']) - substr_count($elements['#value'], "\n");
if ($countCharacters > $elements['#maxlength']) {
$form_state->setError($elements, $this->t('@name cannot be longer than %max characters but is currently %length characters long.', ['@name' => empty($elements['#title']) ? $elements['#parents'][0] : $elements['#title'], '%max' => $elements['#maxlength'], '%length' => $countCharacters]));
}
}
Tests
Code review
Needs work
9.5
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.
For the tests requested in #4