Add Textarea option to normalize newlines to \n

The patch in #34 doesn't apply to 10.3, so re-rolled it against both 10.3.x (for those of us who need this patch to be applied to their sites) and 11.x branches.
Also, removed the unrelated change and split patches to test and test+fix.

abramm → changed the visibility of the branch 11.x to hidden.

abramm → changed the visibility of the branch 9.2.x to hidden.

Added two MRs (test only and test + code change), let's see if tests still passes.

abramm → changed the visibility of the branch 3202631-add-textarea-option to hidden.

Thanks, looks good to me

This seems good but still needs a change record.

taran2l → changed the visibility of the branch 3202631-11.x-test-only to hidden.

Small code update + added a change record. Please review

It looks like the test is failing.

One test still fails

---- Drupal\Tests\Core\Render\Element\TextareaTest ----


Status    Group      Filename          Line Function                            
--------------------------------------------------------------------------------
[31mFail      Other      phpunit-367.xml      0 Drupal\Tests\Core\Render\Element\Te
[0m    PHPUnit Test failed to complete; Error: PHPUnit 10.5.30 by Sebastian
    Bergmann and contributors.
    
    Runtime:       PHP 8.3.11
    Configuration: /builds/issue/drupal-3202631/core/phpunit.xml.dist
    
    ..WWW..                                                             7 / 7
    (100%)
    
    Time: 00:00.038, Memory: 8.00 MB
    
    3 tests triggered 1 PHP warning:
    
    1)
    /builds/issue/drupal-3202631/core/lib/Drupal/Core/Render/Element/Textarea.php:66
    Undefined array key "#normalize_newlines"
    
    Triggered by:
    
    * Drupal\Tests\Core\Render\Element\TextareaTest::testValueCallback#2
     
    /builds/issue/drupal-3202631/core/tests/Drupal/Tests/Core/Render/Element/TextareaTest.php:22
    
    * Drupal\Tests\Core\Render\Element\TextareaTest::testValueCallback#3
     
    /builds/issue/drupal-3202631/core/tests/Drupal/Tests/Core/Render/Element/TextareaTest.php:22
    
    * Drupal\Tests\Core\Render\Element\TextareaTest::testValueCallback#4
     
    /builds/issue/drupal-3202631/core/tests/Drupal/Tests/Core/Render/Element/TextareaTest.php:22
    
    OK, but there were issues!
    Tests: 7, Assertions: 7, Warnings: 1.

The test was working earlier. It should be

  public function testNormalizeNewlines() {
    $form_state = $this->prophesize(FormStateInterface::class)->reveal();
    $element = ['#normalize_newlines' => TRUE];
    $input = "some\r\ndifferent\rline\nendings";
    $expected = "some\ndifferent\nline\nendings";
    $this->assertSame($expected, Textarea::valueCallback($element, $input, $form_state));
  }

It's green now.

I've refactored test a bit to be more robust and support more cases.

1) Drupal\Tests\Core\Render\Element\TextareaTest::testValueCallback with data set #5 ('some\ndifferent\nline\nendings', 'some\r\ndifferent\rline\nendings')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 #Warning: Strings contain different line endings!
-'some
-different
-line
+'some
line
 endings'

Ran test-only feature to see coverage
Summary appears complete
Code change itself seems pretty straight forward

LGTM!

There are no unanswered questions here and is does look straight forward as said in the previous comment.

Unfortunately, one of the comments was not wrapped correctly. I updated that one and made a change to another.

I then reviewed the test and found that most of the defaults for the element did not need to be set. That lead me to rework the test and the data provider. The data provider now sets the element configuration as needed and the structure is changed as well.

This now needs another review.

Coming back to check the change record. I see no evidence here that anyone has reviewed the change record. I took a brief look and was overwhelmed by the second paragraph with a long sentence that is hard to parse. Remember, the readers of change records will have varying levels of skills with the English language.

Setting to needs work for a review of the change record.

The comment changes look good to me.

tim.plunkett → made their first commit to this issue’s fork.

Big rebase after 📌 Slowly, very slowly start OOPifying the render system Needs review .
I rewrote the CR.

Changing from a task to a bug, as evidenced by 🐛 \r\n on the config form causes the property_restrictions to not be followed Active

I'm pretty sure there is duplication between this issue and 🐛 Maxlength validation counts newlines twice Needs work .

1 small comment on the MR.

Also, @alexpott brought up in 🐛 Maxlength validation counts newlines twice Needs work #27 that normalizing "\r\n" to "\n" will cause values to be stored differently between form and JSON:API submissions when textareas are used in entity form widgets. Should core widgets set their textarea's #normalize_newlines property to FALSE?

Small comments on the MR with 1 question.