Lviv
Account created on 3 April 2009, about 16 years ago
#

Merge Requests

More

Recent comments

🇺🇦Ukraine Taran2L Lviv

Implemented @luke.leber suggestion, please review. This should be ready to go in now

🇺🇦Ukraine Taran2L Lviv

@catch, in #80 @tim.plunkett has self-assigned this issue and no progress for over a year ... is anyone has a better idea on how to overcome this issue without dependency on the route system?

🇺🇦Ukraine Taran2L Lviv

Per @smustgrave suggestion I've made messages translatable, but this causes unexpected fatal errors in a few tests (I assume sometimes string_translation service is not ready yet/not available, but redirect already happens)

So, I've reverted those changes, so messages are as they are (i.e. not translatable)

However, I've one concern: UrlHelper is a simple class that does not depend on the container at all, and we are adding hook invocation to it.

🇺🇦Ukraine Taran2L Lviv

A few tests are still failing, will take a look later

🇺🇦Ukraine Taran2L Lviv

taran2l made their first commit to this issue’s fork.

🇺🇦Ukraine Taran2L Lviv

taran2l made their first commit to this issue’s fork.

🇺🇦Ukraine Taran2L Lviv

Went ahead and fixed this .... still supporting 9.5, it's up to you if you want to go like that

🇺🇦Ukraine Taran2L Lviv

taran2l made their first commit to this issue’s fork.

🇺🇦Ukraine Taran2L Lviv

thanks for the fast turnaround!

🇺🇦Ukraine Taran2L Lviv

taran2l changed the visibility of the branch 3482121-error-uploading-svg to hidden.

🇺🇦Ukraine Taran2L Lviv

hi @jwilson3

this pipeline shows that it works now with D11 -> https://git.drupalcode.org/issue/svg_image_field-3482121/-/pipelines/403938

I'm removing gitlab CI staff from this one, as there is another one for that already 📌 Make CI green again Active

🇺🇦Ukraine Taran2L Lviv

taran2l made their first commit to this issue’s fork.

🇺🇦Ukraine Taran2L Lviv

taran2l made their first commit to this issue’s fork.

🇺🇦Ukraine Taran2L Lviv

hi @dblanken @seanb

I've added FieldableEntityInterface back, the original change is doing a good refactoring, but it out of scope for this issue imo and makes it harder to understand and review (plus it's harder to combine patches)

🇺🇦Ukraine Taran2L Lviv

the conversion to OOP hooks broke this MR, corresponding code should be moved to the class files, I can take a look later this week

🇺🇦Ukraine Taran2L Lviv

taran2l created an issue.

🇺🇦Ukraine Taran2L Lviv

I've removed all refactoring to make everything a little bit easier to review and added a BC layer for the service constructor arguments change

🇺🇦Ukraine Taran2L Lviv

taran2l changed the visibility of the branch 8.x-1.x to hidden.

🇺🇦Ukraine Taran2L Lviv

With a post update hook it works as expected. Please review

🇺🇦Ukraine Taran2L Lviv

No, sorry, it does not work like that

🇺🇦Ukraine Taran2L Lviv

taran2l made their first commit to this issue’s fork.

🇺🇦Ukraine Taran2L Lviv

what about a single php-star-ignore line statement, it anyways will go away with the next major release?

🇺🇦Ukraine Taran2L Lviv

@anybody hi

Unfortunately, this is not how this thing should be fixed, as update runs after cache rebuild (usually), so I can't get to that.

Core always adds a BC layer when arguments change, this should be done here as well.

🇺🇦Ukraine Taran2L Lviv

could a new release be tagged?

🇺🇦Ukraine Taran2L Lviv

@catch, updated branch with the latest changes from the upstream (actually a different issues was causing merge conflict), should be good to go now

🇺🇦Ukraine Taran2L Lviv

@anybody, the MR is ready, PHPStan issue in unrelated deprecation, double asterisk in another issue, this is RTBC as far as I can tell

🇺🇦Ukraine Taran2L Lviv

There is a typo corrupting existing configs!

🇺🇦Ukraine Taran2L Lviv

It's green now.

I've refactored test a bit to be more robust and support more cases.

🇺🇦Ukraine Taran2L Lviv

Small code update + added a change record. Please review

🇺🇦Ukraine Taran2L Lviv

taran2l changed the visibility of the branch 3202631-11.x-test-only to hidden.

🇺🇦Ukraine Taran2L Lviv

taran2l made their first commit to this issue’s fork.

🇺🇦Ukraine Taran2L Lviv

hi @tim bozeman

Removing content from all fields feels counterproductive, especially for complex components that have conditional logic. Creating an empty sample value generator and changing ALL fields of ALL components to use it an overkill

To be honest, the expectation is an empty form, as core does.

🇺🇦Ukraine Taran2L Lviv

taran2l changed the visibility of the branch 3467485-fix-tests-and to hidden.

🇺🇦Ukraine Taran2L Lviv

taran2l made their first commit to this issue’s fork.

🇺🇦Ukraine Taran2L Lviv

Added a draft change record + concrete module version + fixed PHPunit

🇺🇦Ukraine Taran2L Lviv

taran2l changed the visibility of the branch issue/entity_print-2860122-2860122-how-to-set to hidden.

🇺🇦Ukraine Taran2L Lviv

taran2l changed the visibility of the branch 8.x-2.x to hidden.

🇺🇦Ukraine Taran2L Lviv

taran2l made their first commit to this issue’s fork.

🇺🇦Ukraine Taran2L Lviv

@mfb thanks for applying the suggestions. I think the result will be different if someone has more than 1 segment for APCu.

🇺🇦Ukraine Taran2L Lviv

taran2l made their first commit to this issue’s fork.

🇺🇦Ukraine Taran2L Lviv

taran2l changed the visibility of the branch project-update-bot-only to hidden.

🇺🇦Ukraine Taran2L Lviv

taran2l changed the visibility of the branch 3434099-automated-drupal-11 to hidden.

🇺🇦Ukraine Taran2L Lviv

hi @smustgrave, thanks for the offer, but in general it's D11 ready already (there is no deprecations), the only thing that I want to include is the new field categories UI ... plan to release it this week

Thank for the offer, but I don't think it's needed atm (At least for sole purpose of D11 version)

🇺🇦Ukraine Taran2L Lviv

this requires a follow-up, as now there is a warning with comparing 32 Mb to 32 MB (and the reason is described by @Nikit )

PHP APCu caching
Enabled (32 MB)
Depending on your configuration, Drupal can run with a 32 MB APCu limit. However, a 32 MB APCu limit (the default) or above is recommended, especially if your site uses additional custom or contributed modules.

🇺🇦Ukraine Taran2L Lviv

There were reports of the similar behaviour on one of our projects as well, but I cannot reproduce it reliably

🇺🇦Ukraine Taran2L Lviv

Taran2L changed the visibility of the branch 2969051--patch-rollout--8.x-3.6 to hidden.

🇺🇦Ukraine Taran2L Lviv

@Emircan Erkul there is no point of creating a new MR (unless the current one cannot be updated easily)

🇺🇦Ukraine Taran2L Lviv

Taran2L made their first commit to this issue’s fork.

🇺🇦Ukraine Taran2L Lviv

Taran2L changed the visibility of the branch Taran2L-9.2.x-patch-21075 to hidden.

🇺🇦Ukraine Taran2L Lviv

Taran2L changed the visibility of the branch 3040556-duplicate-entity-source-fix to hidden.

🇺🇦Ukraine Taran2L Lviv

Taran2L changed the visibility of the branch 9.5.x to hidden.

🇺🇦Ukraine Taran2L Lviv

Taran2L changed the visibility of the branch 11.x to hidden.

🇺🇦Ukraine Taran2L Lviv

Taran2L changed the visibility of the branch 3040556-duplicate-create-hook to hidden.

🇺🇦Ukraine Taran2L Lviv

Taran2L changed the visibility of the branch 3040556-duplicate-entity-source to hidden.

🇺🇦Ukraine Taran2L Lviv

Taran2L changed the visibility of the branch 3040556-duplicate-entity-source-9.5.x to hidden.

Production build 0.71.5 2024