Status report wrongly warns of APCu memory limit when admin language is not English

This will need tests to show the test.

Also was previously tagged for IS update.

Did not test the issue.

This will need tests to show the test.

See note #5.

Missed that.

Drupal 9.5.10

Drupal 10.2.0

To see this issue on a multilingual site, the string @size MB must be localized.

My solution fixes the issue while respecting the user language, however, I think the best solution is to make the byte comparison work correctly when comparing two byte representations in two different languages, or to just compare the byte size as numbers, not as strings.

@alayham Yeah, the suggestion all along has been to avoid any localization and compare number/byte sizes directly.

https://git.drupalcode.org/project/drupal/-/merge_requests/670/diffs#not...

This was only in needs work because it doesn't have tests which is still true.

Taran2L → changed the visibility of the branch 3142928-status-report-wrongly-d10.2 to hidden.

Taran2L → changed the visibility of the branch 3142928-status-report-wrongly-d10 to hidden.

Taran2L → changed the visibility of the branch 11.x to hidden.

I have same problem as #7

$apcu_actual_size = ByteSizeMarkup::create($memory_info['seg_size'], 'en');
doesn't help

if ($memory_info['seg_size'] < Bytes::toNumber($apcu_recommended_size))
doesn't help too

hi.
this patch work for me in drupal 10.2.7:
status-report-apcu-3142928.patch

go to /core/modules/system/
then edit system.install
in line 427 remove
$apcu_actual_size = ByteSizeMarkup::create($memory_info['seg_size']);
replace with
$apcu_actual_size = ByteSizeMarkup::create($memory_info['seg_size'], 'en');

Per #5 this isn't going to be testable in a useful way - we can't fake the apcu memory limit for system_requirements(). Also think this is a good example where the new policy on https://www.drupal.org/about/core/policies/core-change-policies/core-gat... → should apply.

Can the issue summary be updated with least proposed solution and before/after screenshots.

Also the 1 MR still visible is for 9.1.x and still a number of patches so not sure which is to be reviewed.

ivnish → changed the visibility of the branch 3142928-status-report-wrongly to hidden.

Can the issue summary be updated to include steps to reproduce the problem and ultimately what the proposed solution is.

btw that after screenshot is that the wrong item?

One comment on the MR.

btw that after screenshot is that the wrong item?

smustgrave, after screenshot doesn't have wrong warning about cache size

Latest change in the MR looks good, but probably needs one more round of manual testing?

I have the same problem. MR works for me

Committed and pushed 37d8ea5cb4 to 11.x and e1902fee88 to 11.0.x and eeca1aec09 to 10.4.x and 2664526bdb to 10.3.x. Thanks!

Thanks you a lot!

Oh wow, this is an old one. Thanks!

Just for info:
https://github.com/krakjoe/apcu/blob/v5.1.23/apc_sma.c#L565

info->seg_size = sma->size - (ALIGNWORD(sizeof(sma_header_t)) + ALIGNWORD(sizeof(block_t)) + ALIGNWORD(sizeof(block_t)));

seg_size = = 33554312b, not 33554432b (32M) - 120 bytes difference in my server.
so $apcu_recommended_size = '32 MB'; in system.install isn't exact value for comparing.

@Nikit nice details, thank you!

this requires a follow-up, as now there is a warning with comparing 32 Mb to 32 MB (and the reason is described by @Nikit )

PHP APCu caching
Enabled (32 MB)
Depending on your configuration, Drupal can run with a 32 MB APCu limit. However, a 32 MB APCu limit (the default) or above is recommended, especially if your site uses additional custom or contributed modules.

The follow-up is here: 🐛 APCu requirement for 32M is checking wrong value Needs review

Automatically closed - issue fixed for 2 weeks with no activity.

ivnish → closed merge request !8754