- πΊπΈUnited States smustgrave
This will need tests to show the test.
Also was previously tagged for IS update.
Did not test the issue.
- last update
12 months ago 29,661 pass, 48 fail - @neclimdul opened merge request.
- First commit to issue fork.
- Merge request !5884Fixed false APCu warning on some multilingual sites β (Open) created by alayham
- Status changed to Needs review
6 months ago 10:27pm 19 December 2023 - πΈπͺSweden alayham
To see this issue on a multilingual site, the string
@size MB
must be localized.My solution fixes the issue while respecting the user language, however, I think the best solution is to make the byte comparison work correctly when comparing two byte representations in two different languages, or to just compare the byte size as numbers, not as strings.
- Status changed to Needs work
6 months ago 10:36pm 19 December 2023 - πΊπΈUnited States neclimdul Houston, TX
@alayham Yeah, the suggestion all along has been to avoid any localization and compare number/byte sizes directly.
https://git.drupalcode.org/project/drupal/-/merge_requests/670/diffs#not...
This was only in needs work because it doesn't have tests which is still true.
- πΊπ¦Ukraine Taran2L Lviv
Taran2L β changed the visibility of the branch 3142928-status-report-wrongly-d10.2 to hidden.
- πΊπ¦Ukraine Taran2L Lviv
Taran2L β changed the visibility of the branch 3142928-status-report-wrongly-d10 to hidden.
- πΊπ¦Ukraine Taran2L Lviv
Taran2L β changed the visibility of the branch 11.x to hidden.
- ivnish Poland
I have same problem as #7
$apcu_actual_size = ByteSizeMarkup::create($memory_info['seg_size'], 'en');
doesn't helpif ($memory_info['seg_size'] < Bytes::toNumber($apcu_recommended_size))
doesn't help too hi.
this patch work for me in drupal 10.2.7:
status-report-apcu-3142928.patchgo to /core/modules/system/
then edit system.install
in line 427 remove
$apcu_actual_size = ByteSizeMarkup::create($memory_info['seg_size']);
replace with
$apcu_actual_size = ByteSizeMarkup::create($memory_info['seg_size'], 'en');- Status changed to Needs review
17 days ago 8:06am 9 June 2024 - π¬π§United Kingdom catch
Per #5 this isn't going to be testable in a useful way - we can't fake the apcu memory limit for system_requirements(). Also think this is a good example where the new policy on https://www.drupal.org/about/core/policies/core-change-policies/core-gat... β should apply.
- Status changed to Needs work
16 days ago 5:37pm 9 June 2024 - πΊπΈUnited States smustgrave
Can the issue summary be updated with least proposed solution and before/after screenshots.
Also the 1 MR still visible is for 9.1.x and still a number of patches so not sure which is to be reviewed.