- ๐บ๐ธUnited States smustgrave
This has been tagged for steps and issue summary. So moving to PNMI for that info.
- ๐ฎ๐ณIndia lavanyatalwar
Hi @catch,
I reviewed both the patch and the current codebase. It seems the patch is based on an older version of the code, which has since changed significantly.
Could you please take a look and confirm? - ๐ฌ๐งUnited Kingdom catch
The change mentioned in #25 is the one from this patch afaict https://www.drupal.org/files/drupal8.forms-system.2101427-35.patch โ
That code is still the same, so I think it's still relevant.
I think next steps would be:
1. Convert the changes here to an MR
2. Manually test the installer form with and without js enabled.
3. Revert the changes from the above patch to the language add form and manually test that. - ๐บ๐ธUnited States smustgrave
After applying the MR confirmed I'm getting the same results as the screenshots in the issue summary. Tested at various mobile widths and confirmed the breadcrumb__item always stayed at 24px.
Believe this one is good.
- ๐บ๐ธUnited States smustgrave
Came up as a daily BSI but seems already been triaged
Tagging for IS update and tests if possible, maybe the test can get the dialog width and check there?