🇺🇸United States @oheller

Re-roll patch 8 for subgroup v2.1.0.

It looks good to me, but someone else should test and validate the change.

oheller → changed the visibility of the branch 3474114-missing-block-plugin to hidden.

I followed README change and it makes sense to me.

I can confirm that the above code returns $values as either a string or an array. We are overriding the template in our theme to access {{ locality.code }} which breaks when $values is a string. Attached is the patch removing the code.

I have success with the defaults after updating from beta7 to beta8, but I still have the 3381787.patch applied.
Below is the code after it's applied. While debugging I noticed that the 2nd defaultStorageSettings() is never hit. Which is why applying the patch works.

If remove the patch I get an error. If I move the 'target_type' => 'view' into the 2nd function and delete the first, I get an error.

  /**
   * {@inheritdoc}
   */
  public static function defaultStorageSettings() {
    return [
      'target_type' => 'view',
      'handler' => 'default:view',
    ];
  }

  /**
   * {@inheritdoc}
   */
  public static function defaultFieldSettings() {
    return [
      'force_default' => 0,
      'allowed_views' => [],
      'allowed_display_types' => ['block' => 'block'],
      'handler' => 'default:view',
    ] + parent::defaultFieldSettings();
  }

After getting the WSOD + error, when I go back to the Manage fields screen I see the following error. I'm not sure if it's related.

Deprecated function: str_contains(): Passing null to parameter #1 ($haystack) of type string is deprecated in Drupal\Core\Entity\EntityReferenceSelection\SelectionPluginManager->getInstance() (line 45 of core/lib/Drupal/Core/Entity/EntityReferenceSelection/SelectionPluginManager.php).
Drupal\Core\Entity\EntityReferenceSelection\SelectionPluginManager->getInstance(Array) (Line: 101)
Drupal\Core\Entity\EntityReferenceSelection\SelectionPluginManager->getSelectionHandler(Object, Object) (Line: 97)
Drupal\Core\Entity\Plugin\Validation\Constraint\ValidReferenceConstraintValidator->validate(Object, Object) (Line: 202)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateConstraints(Object, '0000000000000ee20000000000000000', Array) (Line: 154)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validateNode(Object, Array, 1) (Line: 106)
Drupal\Core\TypedData\Validation\RecursiveContextualValidator->validate(Object, NULL, NULL) (Line: 93)
Drupal\Core\TypedData\Validation\RecursiveValidator->validate(Object) (Line: 132)
Drupal\Core\TypedData\TypedData->validate() (Line: 307)
Drupal\Core\Field\FieldItemList->defaultValuesFormValidate(Array, Array, Object) (Line: 377)
Drupal\field_ui\Form\FieldConfigEditForm->validateForm(Array, Object)
call_user_func_array(Array, Array) (Line: 82)
Drupal\Core\Form\FormValidator->executeValidateHandlers(Array, Object) (Line: 275)
Drupal\Core\Form\FormValidator->doValidateForm(Array, Object, 'field_config_edit_form') (Line: 118)
Drupal\Core\Form\FormValidator->validateForm('field_config_edit_form', Array, Object) (Line: 593)
Drupal\Core\Form\FormBuilder->processForm('field_config_edit_form', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 627)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 181)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 704)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

I've created a patch to add the field and template.

oheller → created an issue.

andrewozone → credited oheller → .

tekNorah → credited oheller → .

Here's a patch to remove the debugging notices.

oheller → created an issue.

At this point we should be using "v1" instead of the "v1beta1" per the documentation (https://cloud.google.com/recaptcha-enterprise/docs/migration-v1).

If you are using v1beta1 to create and annotate assessments, we recommend using v1because the new features, such as reCAPTCHA Enterprise account defender are available only on v1. v1 supports both API key and service account authentication.

Also the url that's constructed is pointing to the site secret and for enterprise it should be pointing to the site key instead.

Here is a patch for 1.0@beta8:

I have a webform specific version, working on making it also consider more general application.

oheller → created an issue.

Resolution works for me. I've updated the summary to reflect what is accepted.

Added the summary.

I'm working on this at DrupalCon2023 Pittsburgh.

I'm working on this at DrupalCon2023 Pittsburgh.

Looks good just some little changes:

This module allows items in a Views table to be rearranged with 'drag and drop' behavior.

Added the short summary.

I am working on this at DrupalCon2023 Pittsburgh.

I'm working on this for DrupalCon2023 Pittsburgh.

This works after applying the patch and clearing the cache. I feel good about the new class name.

I will review tomorrow.

I too was having this issue, here's the solution I arrived at:
Requirements: Using Gatsby + Webforms + Recaptcha v3 (invisible).

After reviewing captcha and recaptcha_v3 it seems that the verification doesn't work for a headless Drupal site. When following the xdebug path the "captcha" field never makes it into the form_state for future verification. So, it always works.

I ended up using simple_recaptcha because they have a well defined method SimpleReCaptchaFormManager::validateCaptchaToken(). I had to add my own helper module to add my webformelement and webformhandler because simple_Recaptcha adds the form validation to the button and uses ajax in it's provided simple_recaptcha_webform handler.

I created my own WebformElement, "HeadlessCaptcha", to add the headless_captcha element to use, and a WebformHandler "HeadlessCaptchaValidation" to handle the verification (using validateForm() instead of submitForm()).

I've got the front end (gatsby) to generate the token and the backend to send the token via the handler to verify the token. It succeeds when submitting the webform form gatsby, and fails when trying to send the form via Postman (without the captcha token). It also fails if the correct key's aren't present.

Composer.json scripts that aren't in the root composer.json file are ignored:
https://stackoverflow.com/questions/46769237/composer-run-script-of-nest....

oheller → created an issue.

oheller → created an issue.

I'm working on making the children issues.

oheller → created an issue.

oheller → created an issue.

First bullet point ready for review. I've updated the schema with entity_id and implemented the update_hook() to add the field to the tables.

Started the merge request branch during MidCamp. I will continue to work on this today.

oheller → made their first commit to this issue’s fork.

I'm not sure why but it seems like the files were caught in cache (I've got cache disabled locally). Once I removed and resolved that, the proper js files were loaded. Thanks for your help.

oheller → created an issue.

This has been implemented. In your behat.yml config file you can configure it as such:

Drupal\DrupalExtension:
text:
login_url: "/user"
logout_url: "/user/logout"
log_out: "Sign out"
log_in: "Sign in"
password_field: "Enter your password"
username_field: "Nickname"

This is also outlined in the documentation: https://behat-drupal-extension.readthedocs.io/en/v4.0.1/blackbox.html

We have updated the js/views/AppView.js LN: 44 with:

once('shs', this.$el)[0].classList.add('hidden');

This adds the hidden class but we don't have the taxonomy terms added to the containers.

If you open the browser inspector, you will see an error about Once not being a function. This is because jquery.once has been removed from core: https://www.drupal.org/node/3158256 → .

We need to update the library to call core/once and update AppView.js, around ln:42 to properly use once. I've tried but haven't succeeded yet.

I have created a submodule to add the button. It pulls the site id from the gatsby.settings:incrementalbuild_url to trigger the correct Gatsby environment.

I've included 2 patches. One to be included using the composer.json patches option. The other is to be applied with git from the project root using `git am file.patch`.

oheller → created an issue.