Rename Form/Settings.php to Avoid .gitignore Recognizing it as settings.php

Created on 16 March 2020, over 4 years ago
Updated 4 January 2024, 6 months ago

We have a multisite where the build artifact needs to be stored in the repo. We have noticed that .gitignore is ignoring the Form/Settings.php file because git doesn't notice case.

I propose changing the settings class to a more descriptive and unique class so it's not accidentally ignored by git.

✨ Feature request
Status

Closed: outdated

Version

2.0

Component

Code

Created by

🇺🇸United States oheller

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇮🇳India mrinalini9 New Delhi

    Added patch by updating the class name to IgnoreSettingsForm as suggested in #5, please review it.

    Thanks
    Mrinalini

  • 🇮🇳India mrinalini9 New Delhi

    Added the patch here as mentioned in #7, forgot to attach it by mistake.

  • Assigned to oheller
  • 🇺🇸United States oheller

    I will review tomorrow.

  • 🇺🇸United States oheller

    This works after applying the patch and clearing the cache. I feel good about the new class name.

  • Issue was unassigned.
  • Status changed to RTBC about 1 year ago
  • 🇺🇸United States oheller
  • Status changed to Closed: outdated 6 months ago
  • 🇨🇭Switzerland bircher 🇨🇿

    This issue is being closed because Config Ignore 2.x is deprecated.

    The new 3,x version has been re-written from the ground up and works in a totally different way, yet it provides the same backwards compatible functionality. All the 2.x tests pass in 3.x and the 3.x codebase is easier to maintain.
    Users of 2.x are strongly encouraged to upgrade to 3.x, as there is a very simple update path.

    So likely this issue is no longer relevant. If you think that this issue still applies please open it again and target the new branch. All issues on the 2.x branch were closed in bulk.

Production build 0.69.0 2024