undefined - Contrib.social

FILE: /tac_lite/src/Form/UserAccessForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------
  40 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
  41 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  63 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  98 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 103 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------


FILE: /tac_lite/src/Form/SchemeForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------
  98 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
 184 | ERROR   | Type hint "array" missing for $default_values
---------------------------------------------------------------------------------------------------------------


FILE: /tac_lite/src/Form/ConfigForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------
  33 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
  89 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 109 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------


FILE: /tac_lite/src/Cache/TacLiteGrantsCacheContext.php
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 78 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------

Please fix these issues as well.

Thanks!

📌 | Live Weather | Fix the issues reported by PHP_CodeSniffer

Comment 8 months ago →

🇮🇳India mrinalini9 New Delhi

Updated patch #6 by addressing #10 and some other phpcs issues (missing type hint), please review it.

Thanks!

📌 | Simple Proxy | Fix the issues reported by phpcs

Comment 8 months ago →

🇮🇳India mrinalini9 New Delhi

Updated patch #1 by addressing #5, please review it.

Thanks!

📌 | Simple Date block | Fix the issues reported by phpcs

Comment 8 months ago →

🇮🇳India mrinalini9 New Delhi

Hi,

I have reviewed patch #3, looks good to me. It applied cleanly:

Checking patch simple_date_block.info.yml...
Checking patch src/Plugin/Block/SimpleDateBlock.php...
Applied patch simple_date_block.info.yml cleanly.
Applied patch src/Plugin/Block/SimpleDateBlock.php cleanly.

And fixed all the phpcs issues as reported above.

So, for me, it is RTBC.

Thanks!

🐛 | Stripe Webhooks | Fix in-code links to event types documentation

Comment 8 months ago →

🇮🇳India mrinalini9 New Delhi

Added patch for the above fixes, please review it.

Thanks!

📌 | Equation Editor | Does not install on D10

Comment 8 months ago →

🇮🇳India mrinalini9 New Delhi

Updated patch #6 by addressing #8, please review it.

Thanks!

📌 | Nofollow List | filter implies this text format is not HTML anymore

Comment 8 months ago →

🇮🇳India mrinalini9 New Delhi

Updated patch #2 by addressing #3, please review it.

Thanks!

📌 | Weather Wave | Fix the issue reported by phpcs

Comment 8 months ago →

🇮🇳India mrinalini9 New Delhi

Hi,

Patch #2 is no longer applicable, need to reroll this.
So, moving this to Needs Work.

Thanks!

📌 | Pantheon Secrets | Fix the issues reported by phpcs

Comment 8 months ago →

🇮🇳India mrinalini9 New Delhi

Hi,

I have reviewed patch #10, it applied, but threw some trailing whitespace issues at the time of applying the patch:

3359008-10.patch:30: trailing whitespace.
    1) Add a new key through the Key module UI. Select Pantheon Secret as 
3359008-10.patch:32: trailing whitespace.
    1) Go to /admin/config/system/keys/pantheon and click on the "Sync Keys" 
3359008-10.patch:34: trailing whitespace.
    1) Use the provided drush command to sync all of your secrets 
3359008-10.patch:48: trailing whitespace.
1) Make sure you have access to a Drupal >= 9.4 site running PHP >= 8.0 
3359008-10.patch:56: trailing whitespace.
1) Install the required modules in your Drupal site and push the 
warning: squelched 9 whitespace errors
warning: 14 lines add whitespace errors.

Also, it fixed all the phpcs issues as reported, except this one:

FILE: /pantheon_secrets/README.md
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 48 | WARNING | Line exceeds 80 characters; contains 86 characters
-----------------------------------------------------------------------------------

Please fix all these issues.

Thanks & Regards,
Mrinalini

🐛 | Avatar Field Formatter | The file_url_generator service is not passed to the class constructor

Comment 8 months ago →

🇮🇳India mrinalini9 New Delhi

Updated patch #3 by addressing #4, please review it.

Thanks!

🐛 | Commerce Wishlist | Twig 3.0 issue

Comment 8 months ago →

🇮🇳India mrinalini9 New Delhi

Rerolled patch #3 and also addressed #4, please review it.

Thanks!

🐛 | Harmony Haven | Fix the issue reported by phpcs

Comment 8 months ago →

🇮🇳India mrinalini9 New Delhi

Rerolled patch #3 by addressing #6, please review it.

Thanks!

🐛 | stub project from issue ref | Undefined array key "plugin_ids" in SocialContentBlockOverride->loadOverrides()

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Hi,

I have checked patch #3, it applies cleanly on 11.5.x branch:

Checking patch modules/social_features/social_content_block/src/SocialContentBlockOverride.php...
Applied patch modules/social_features/social_content_block/src/SocialContentBlockOverride.php cleanly.

So, moving this to Needs Review.

Thanks!

✨ | Linkit | Add better support for linking to anchors

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Rerolled patch #36, please review it.

Thanks!

📌 | Zurb Views | Fix the warnings/errors reported by PHP_CodeSniffer

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Hi,

I have reviewed patch #12, it applied cleanly.

But has some trailing whitespace issues in the patch that need to be fixed:

drupal.org_files_issues_2023-10-10_3368542-12.patch:12: trailing whitespace.
 
drupal.org_files_issues_2023-10-10_3368542-12.patch:16: trailing whitespace.
 
drupal.org_files_issues_2023-10-10_3368542-12.patch:72: trailing whitespace.
 
drupal.org_files_issues_2023-10-10_3368542-12.patch:103: trailing whitespace.
 
drupal.org_files_issues_2023-10-10_3368542-12.patch:107: trailing whitespace.
 
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.

Also, there are still few phpcs errors left that need to be fixed:

FILE: /zurb_views/js/views-zurb.js
------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 17 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 3 empty lines
 19 | ERROR | [ ] More than 2 empty lines are not allowed
 20 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

Please fix all of these things.

Thanks & Regards,
Mrinalini

🐛 | Simplenews | Multilingual tokens are not translated

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Rerolled patch #7 for the 4.x-dev branch, please review it.

Thanks!

✨ | Dopup | Namespace dependencies in info files

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Reviewed patch #2, looks good to me. It applied cleanly and fixed the above mentioned issue as reported.
So, for me, it is RTBC.

Thanks!

📌 | Micro Blogging | Fix the issues reported by phpcs

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Reviewed patch #12, looks good to me. It applied cleanly and fixed all the phpcs issues.
So, for me, it is RTBC.

Thanks!

📌 | Micro Blogging | Fix the issues reported by phpcs

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Hi,

I have reviewed patch #10, looks good to me. It applied cleanly and fixed phpcs issues but still few of them are remaining that need to be fixed:

FILE: /microblogging/assets/js/timeline.js
------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------
  4 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
  7 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 22 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------


FILE: /microblogging/src/Ajax/UpdateTimelineCommand.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 42 | ERROR | Type hint "array" missing for $html
---------------------------------------------------------------------------------------------------------

Please fix these errors as well.

Thanks & Regards,
Mrinalini

🐛 | Superfish | Initial menu level not respected when displaying the menu

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Hi,

The source code in the above attached patch has already been merged to 8.x-1.x branch, that's why the patch is not applicable anymore.

Thanks!

🐛 | Create fields programmatically | Fix 'hidden' display region handling

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Added patch for the changes mentioned in #6, please review it.

Thanks!

✨ | Media entity dreambroker | Support for quality and lang query parameters

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Updated patch #3 by addressing #4, please review it.

Thanks!

🐛 | Anti-Duplicates | Title search should only search selected content type

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Hi,

I have rerolled patch #7, please review it.

Thanks!

🐛 | Entity Browser Enhance(d|r) | Fix Coding Standard Issues

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Hi,

I have reviewed patch #4, it applied cleanly but has some extra file changes i.e., in the .module file. Please revert this change as it's not required.
Also, still getting the below errors after applying the patch:

FILE: /entity_browser_enhanced/enhancers/multiselect/js/entity_browser_enhanced.multiselect.js
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
------------------------------------------------------------------------------------------------------------------------------------------------
 31 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 35 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 42 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 53 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 55 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 75 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 77 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------

Please fix these errors as well.

Thanks & Regards,
Mrinalini

🐛 | Drupal core | Use "@return" instead of "@returns"

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Hi,

I have reviewed patch #26, looks good to me.
It applied cleanly and replaced all the occurrences of @returns with @return at all places except the .js files in the core.
So, for me, it is RTBC.

Thanks & Regards,
Mrinalini

📌 | Content to Group | Drupal Coding Standards Issues | phpcs

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Reviewed patch #7, looks good to me. It applied cleanly and fixed all the PHPCS issues.
So, for me, it is RTBC.

Thanks!

📌 | Content to Group | Drupal Coding Standards Issues | phpcs

Comment 9 months ago →

🇮🇳India mrinalini9 New Delhi

Patch #7 needs review, so moving this to Needs Review.

📌 | LiveFilter | Fix the issues reported by phpcs

Comment 9 months ago →