🇮🇳India @mrinalini9

Fixed PHPStan issues reported by the bot in #51 but still some tests are failing that need to be fixed.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

Hi,

I have rerolled patch #262 and created MR for the 11.x branch, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

Fixed pipeline issues (PhpCodingStandard + Javascript linting) and have updated the MR, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

Addressed comments on MR as suggested and have updated it, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

Fixed phpstan issues reported by the bot and have updated the MR, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

Fixed phpstan and phpcs pipeline issues and updated the MR, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

Fixed phpcs and phpstan issues and have updated the MR, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

Fixed PHPStan issues reported by bot in #45, please review it.

Thanks!

Hi,

I have made the class final, please review it.

Thanks!

Hi,

I was getting below error while ran PHPStan on file (core/modules/ban/src/Form/BanDeleteMultiple.php) instead of the error mentioned on #39:

vendor/bin/phpstan analyse core/modules/ban/src/Form/BanDeleteMultiple.php
1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

------ -----------------------------------------------------------------------------------
Line BanDeleteMultiple.php
------ -----------------------------------------------------------------------------------
46 Unsafe usage of new static().
💡 See: https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static
------ -----------------------------------------------------------------------------------

[ERROR] Found 1 error

I have fixed this error and have updated MR, please review it.

Thanks & Regards,
Mrinalini

mrinalini9 → made their first commit to this issue’s fork.

mrinalini9 → made their first commit to this issue’s fork.

I have tried 'composer require drmonty/smartmenus:1.1.1' but that not worked and allow me to install. Then, i have tried 'composer require drmonty/smartmenus: ^1.1' as suggested in #15 that worked for me. So, have created MR based on that, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

Fixed PHP Coding Standard pipeline issues, please review it.
Thanks!

Created MR for patch changes in #18 for 11.x branch, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

mrinalini9 → made their first commit to this issue’s fork.

Addressed comments on MR as mentioned in #68, please review it.

mrinalini9 → made their first commit to this issue’s fork.

Rerolled patch #74 into an MR, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

mrinalini9 → made their first commit to this issue’s fork.

Addressed comments on MR, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

mrinalini9 → made their first commit to this issue’s fork.

Created MR for the patch changes in #27 for the 11.x branch, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

Created MR for the 11.x branch, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

mrinalini9 → made their first commit to this issue’s fork.

Fixed pipeline issues, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

Addressed comments on the MR, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

mrinalini9 → made their first commit to this issue’s fork.

mrinalini9 → made their first commit to this issue’s fork.

mrinalini9 → made their first commit to this issue’s fork.

Hi,

I have tried to create MR for the changes mentioned in patch #48 but was unable to do so because the MR points to branch 9.5.x instead of 11.x. Also, I have tried to create a new branch from 11.x but getting the below error:

Thanks & Regards,
Mrinalini

mrinalini9 → made their first commit to this issue’s fork.

mrinalini9 → made their first commit to this issue’s fork.

Fixed pipeline failure issues in the MR, please review it.
Thanks!

mrinalini9 → made their first commit to this issue’s fork.

mrinalini9 → made their first commit to this issue’s fork.

Fixed pipeline issues and updated MR, please review it.
Thanks!

Created MR for the changes in patch #44, please review.

Hi,

I have created MR from the patch #101 to run tests, please review it.

Thanks!

mrinalini9 → made their first commit to this issue’s fork.

Hi,

Fixed the test case failure issue in #20, please review it.

Thanks!

Hi,
Rerolled patch #31 for 11.x branch, please review it.
Thanks!

quietone → credited mrinalini9 → .

Hi,

I am facing the same issue as mentioned above, please let me know if anyone has any solution to resolve this.

Thanks!

Updated patch #35 by addressing #38, please review it.

Thanks!

Updated patch #11 by addressing #13, please review it.

Thanks!

Reviewed patch #2, looks good to me.

It applied cleanly and fixed the phpcs issues except the below issues that need to be fixed as well:

FILE: /tac_lite/src/Form/UserAccessForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------
  40 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
  41 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  63 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  98 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 103 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------


FILE: /tac_lite/src/Form/SchemeForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------
  98 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
 184 | ERROR   | Type hint "array" missing for $default_values
---------------------------------------------------------------------------------------------------------------


FILE: /tac_lite/src/Form/ConfigForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------
  33 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
  89 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 109 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------


FILE: /tac_lite/src/Cache/TacLiteGrantsCacheContext.php
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 78 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------

Please fix these issues as well.

Thanks!

Updated patch #6 by addressing #10 and some other phpcs issues (missing type hint), please review it.

Thanks!

Updated patch #1 by addressing #5, please review it.

Thanks!

Hi,

I have reviewed patch #3, looks good to me. It applied cleanly:

Checking patch simple_date_block.info.yml...
Checking patch src/Plugin/Block/SimpleDateBlock.php...
Applied patch simple_date_block.info.yml cleanly.
Applied patch src/Plugin/Block/SimpleDateBlock.php cleanly.

And fixed all the phpcs issues as reported above.

So, for me, it is RTBC.

Thanks!

Added patch for the above fixes, please review it.

Thanks!

Updated patch #6 by addressing #8, please review it.

Thanks!

Updated patch #2 by addressing #3, please review it.

Thanks!

Hi,

Patch #2 is no longer applicable, need to reroll this.
So, moving this to Needs Work.

Thanks!

Hi,

I have reviewed patch #10, it applied, but threw some trailing whitespace issues at the time of applying the patch:

3359008-10.patch:30: trailing whitespace.
    1) Add a new key through the Key module UI. Select Pantheon Secret as 
3359008-10.patch:32: trailing whitespace.
    1) Go to /admin/config/system/keys/pantheon and click on the "Sync Keys" 
3359008-10.patch:34: trailing whitespace.
    1) Use the provided drush command to sync all of your secrets 
3359008-10.patch:48: trailing whitespace.
1) Make sure you have access to a Drupal >= 9.4 site running PHP >= 8.0 
3359008-10.patch:56: trailing whitespace.
1) Install the required modules in your Drupal site and push the 
warning: squelched 9 whitespace errors
warning: 14 lines add whitespace errors.

Also, it fixed all the phpcs issues as reported, except this one:

FILE: /pantheon_secrets/README.md
-----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------
 48 | WARNING | Line exceeds 80 characters; contains 86 characters
-----------------------------------------------------------------------------------

Please fix all these issues.

Thanks & Regards,
Mrinalini

Updated patch #3 by addressing #4, please review it.

Thanks!

Rerolled patch #3 and also addressed #4, please review it.

Thanks!

Rerolled patch #3 by addressing #6, please review it.

Thanks!

Hi,

I have checked patch #3, it applies cleanly on 11.5.x branch:

Checking patch modules/social_features/social_content_block/src/SocialContentBlockOverride.php...
Applied patch modules/social_features/social_content_block/src/SocialContentBlockOverride.php cleanly.

So, moving this to Needs Review.

Thanks!

Rerolled patch #36, please review it.

Thanks!

Hi,

I have reviewed patch #12, it applied cleanly.

But has some trailing whitespace issues in the patch that need to be fixed:

drupal.org_files_issues_2023-10-10_3368542-12.patch:12: trailing whitespace.
 
drupal.org_files_issues_2023-10-10_3368542-12.patch:16: trailing whitespace.
 
drupal.org_files_issues_2023-10-10_3368542-12.patch:72: trailing whitespace.
 
drupal.org_files_issues_2023-10-10_3368542-12.patch:103: trailing whitespace.
 
drupal.org_files_issues_2023-10-10_3368542-12.patch:107: trailing whitespace.
 
warning: squelched 5 whitespace errors
warning: 10 lines add whitespace errors.

Also, there are still few phpcs errors left that need to be fixed:

FILE: /zurb_views/js/views-zurb.js
------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------------------
 10 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 17 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 3 empty lines
 19 | ERROR | [ ] More than 2 empty lines are not allowed
 20 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

Please fix all of these things.

Thanks & Regards,
Mrinalini

Rerolled patch #7 for the 4.x-dev branch, please review it.

Thanks!

Reviewed patch #2, looks good to me. It applied cleanly and fixed the above mentioned issue as reported.
So, for me, it is RTBC.

Thanks!

Reviewed patch #12, looks good to me. It applied cleanly and fixed all the phpcs issues.
So, for me, it is RTBC.

Thanks!

Hi,

I have reviewed patch #10, looks good to me. It applied cleanly and fixed phpcs issues but still few of them are remaining that need to be fixed:

FILE: /microblogging/assets/js/timeline.js
------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------
  4 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
  7 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 22 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------


FILE: /microblogging/src/Ajax/UpdateTimelineCommand.php
---------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------
 42 | ERROR | Type hint "array" missing for $html
---------------------------------------------------------------------------------------------------------

Please fix these errors as well.

Thanks & Regards,
Mrinalini

Hi,

The source code in the above attached patch has already been merged to 8.x-1.x branch, that's why the patch is not applicable anymore.

Thanks!

Added patch for the changes mentioned in #6, please review it.

Thanks!

Updated patch #3 by addressing #4, please review it.

Thanks!

Hi,

I have rerolled patch #7, please review it.

Thanks!

Hi,

I have reviewed patch #4, it applied cleanly but has some extra file changes i.e., in the .module file. Please revert this change as it's not required.
Also, still getting the below errors after applying the patch:

FILE: /entity_browser_enhanced/enhancers/multiselect/js/entity_browser_enhanced.multiselect.js
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 8 LINES
------------------------------------------------------------------------------------------------------------------------------------------------
 31 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 35 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 42 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 46 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 53 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 55 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 75 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
 77 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------

Please fix these errors as well.

Thanks & Regards,
Mrinalini

Hi,

I have reviewed patch #26, looks good to me.
It applied cleanly and replaced all the occurrences of @returns with @return at all places except the .js files in the core.
So, for me, it is RTBC.

Thanks & Regards,
Mrinalini

Reviewed patch #7, looks good to me. It applied cleanly and fixed all the PHPCS issues.
So, for me, it is RTBC.

Thanks!

Patch #7 needs review, so moving this to Needs Review.

Hi,

I have reviewed patch #2, looks good to me. It applied cleanly and fixed all the phpcs issues as mentioned above.
So, for me, it is RTBC.

Thanks!

Hi,

I have reviewed patch #4, looks good to me. It applied cleanly and fixed all the phpcs issues as mentioned above.
So, for me, it is RTBC.

Thanks!

Updated patch #1 by addressing #2, please review it.

Thanks!

Rerolled patch #2, please review it.

Thanks!

Rerolled patch #2, please review it.

Thanks!

smustgrave → credited mrinalini9 → .

Rerolled patch #34, please review it.

Thanks!

Rerolled patch #417 for 11.x branch, please review it.

Thanks!

Updated patch #2 by addressing #4, please review it.

Thanks!

Rerolled patch #10, please review it.

Thanks!