Allow tokens in entity reference views selection arguments

This breaks when trying to create new nodes with a reference field.

It's because there's no ID yet to pass.

I got it working by altering handleArgs:

- if (isset($this->configuration['entity_info'])) {
+ if (isset($this->configuration['entity_info']) && $this->configuration['entity_info']['id']) {

The last submitted patch, 245: 1699378.patch, failed testing. View results →

+++ b/core/modules/views/src/Plugin/EntityReferenceSelection/ViewsSelection.php
@@ -8,14 +8,15 @@
-use Drupal\Core\StringTranslation\StringTranslationTrait;

This removal of the "use" statement is throwing an error for me, and it doesn't seem relevant to the rest of the code changes in this file. Maybe this was an accident?

Adding it back to 245 fixes it for me.

I recently came across this whilst recreating a D7 site (yay, token arguments) in D9 (booo, no token arguments). In case anyone is looking for a workaround for dynamic arguments to entity reference view displays whilst this issue gets resolved, you can specify the arguments in a form_alter like this:

  $form['field_something']['widget'][0]['target_id']['#selection_settings']['view']['arguments'][0] = $arg_thingy;

Here's a reroll of the patch for 9.5.9.

This patch is causing this issue, 💬 Drupal\views\Plugin\EntityReferenceSelection\ViewsSelection::__construct(): Argument #8 ($token) must be of type Drupal\views\Plugin\EntityReferenceSelection\Token, Drupal\eca\Token\ContribToken given Closed: works as designed

Rerolled JonPugh #245 ✨ Allow tokens in entity reference views selection arguments Needs work for Drupal 9.5.9

in #245 and #252 this line is removed:
-use Drupal\Core\StringTranslation\StringTranslationTrait;

I had to add this line back in. I had fatal error:
"PHP message: PHP Fatal error: Trait "Drupal\views\Plugin\EntityReferenceSelection\StringTranslationTrait" not found in /drupal9.5.9/html/core/modules/views/src/Plugin/EntityReferenceSelection/ViewsSelection.php on line 32

re-roll for 10.1.x

Couldn't generate the interdiff, changes to fix the issue with above patch and compatibility

Seems to have test failures.

Also was previously tagged for tests and issue summary which appear to still be needed.

for 10.1.6, #247 failed. #254 applied and works as needed.

Here's a quick reroll. I D10 I was seeing errors about there being no value for "$element['#array_parents']" on regular node forms for any select or radio fields added directly to the top-level of the form. This updated patch just wraps the foreach that loops through array_parents in an if statement.