[meta] Remove usage of t() in tests not testing translation

Tagging for coding standards and moving to the 'other' component where such issues live.

📌 Remove remaining uses of t() in assertEquals() calls Fixed landed.

I think we are down to the final few stragglers, opened 📌 Remove remaining unnecessary uses of t() in tests Active to cover those.

I also am leaning towards closing 📌 Remove uses of t() in setLabel() and setDescription() calls Needs work as won't fix as we are effectively testing that APIs can receive TranslatableMarkup, as they would outside of tests.

smustgrave → credited adeshsharma → .

smustgrave → credited chaitanyadessai → .

smustgrave → credited Hardik_Patel_12 → .

smustgrave → credited paulocs → .

quietone → credited dawehner → .

quietone → credited duaelfr → .

quietone → credited geertvd → .

quietone → credited joelpittet → .

quietone → credited lokapujya → .

quietone → credited mile23 → .

quietone → credited xjm → .

quietone → credited mohrerao → .

quietone → credited mrinalini9 → .

Closed that related issue and moved credit here

And the number of instances has risen since #30.

$ find core -type f -iname '*Test.php' | xargs grep '[^a-zA-Z]t(' | wc -l
274

Trying to confirm that this is done, since 📌 Remove remaining unnecessary uses of t() in tests Active has been committed. I searched Test files using the grep in that issue and ignored all the files listed in that IS that are valid uses of t(). Then ignored the tests in package_manager because which isn't testing translations but tests validation messages where the methods have a type hint for TranslatableMarkup. That left 16 files with 26 instances of t() that need to be checked.

1. core/modules/comment/tests/src/Kernel/Views/CommentUserNameTest.php
2. core/modules/file/tests/src/Functional/FileManagedFileElementTest.php
3. core/modules/language/tests/src/Functional/LanguageUILanguageNegotiationTest.php
4. core/modules/locale/tests/src/Functional/LocaleTranslatedSchemaDefinitionTest.php
5. core/modules/migrate/tests/modules/migrate_high_water_test/src/Plugin/migrate/source/HighWaterTest.php
6. core/modules/migrate/tests/src/Kernel/MigrateEntityContentValidationTest.php
7. core/modules/navigation/tests/src/Functional/NavigationLogoTest.php
8. core/modules/navigation/tests/src/Unit/TopBarItemManagerTest.php
9. core/modules/shortcut/tests/src/Functional/ShortcutLinksTest.php
10. core/modules/system/tests/src/Kernel/System/RunTimeRequirementsTest.php
11. core/modules/views/tests/src/Kernel/Handler/FieldKernelTest.php
12. core/modules/views_ui/tests/src/Unit/ViewListBuilderTest.php
13. core/tests/Drupal/KernelTests/Core/TypedData/TypedDataTest.php
14. core/tests/Drupal/KernelTests/Core/Updater/UpdateRequirementsTest.php
15. core/tests/Drupal/KernelTests/Core/Url/LinkGenerationTest.php
16. core/tests/Drupal/Tests/Core/Template/TwigExtensionTest.php

Of those, 13, is testing translations. The rest includes some that were missed in 📌 Remove remaining unnecessary uses of t() in tests Active and others from commits made this month. There is nothing to prevent added other unnecessary uses of t() in tests so lets' fix this last group and stop chasing new introduced cases. Right now, we can only rely on review to prevent the addition of more unnecessary uses of t() in tests.

Here is the script I used for finding usages of t() in tests.

Postponing until the issues to fix "DrupalPractice.Objects.GlobalFunction" in tests is complete. 📌 [META] Replace t() calls inside of classes Active

Used the script provided and believe all instances have been found.

This appears to be removing one assertion entirely instead of updating it to not use t().

Work is not needed, the line is a duplicate.

nod_ → closed merge request !10995

Committed e4df448 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.