๐Ÿ‡ฎ๐Ÿ‡ณIndia @Hardik_Patel_12

India
Account created on 6 October 2015, over 9 years ago
#

Merge Requests

More

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Applying new patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Applying new patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Adding new patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Adding patch for .info.yml file to support D9

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Adding patch for Drupal 9 support

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Hardik_Patel_12 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Hardik_Patel_12 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Returning to "needs work" as a test is required.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Hardik_Patel_12 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Hardik_Patel_12 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Conveying uncertainty, there appears to be a plausible opportunity to convert it into a kernel test case. Furthermore, I have removed the links integrated into the parent issue. Any insights or feedback on this approach would be highly appreciated.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Hardik_Patel_12 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

I attempted to analyze the reasons behind the failure of test cases, and my findings indicate that the failure is associated with the Drupal\Tests\jsonapi\Kernel\TestCoverageTest::testEntityTypeRestTestCoverage test.

The issue lies in the expectation discrepancy, where the test is anticipating the presence of core/modules/jsonapi/tests/src/Functional/ActionTest.php โ†’ core/modules/system/tests/src/Functional/Jsonapi/ActionTest, instead of the actual path, which is core/modules/jsonapi/tests/src/Functional/ActionTest.php โ†’ core/modules/action/tests/src/Functional/Jsonapi/ActionTest.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Hi @PrabuEla, could you please include the interdiff for a review of the latest changes? Alternatively, you may utilize the existing Merge Request (MR) to implement your modifications.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

@bnjmnm, I have observed similar challenges in several other issues. When using the patch method, it leads to significant unrelated failures for the composer and other components, similar to the problems described in issues #55 and #58. However, the Merge Request (MR) method is functioning properly.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

The test is unsuccessful because the code $info = TestDiscovery::getTestInfo($classname, $doc_comment); is returning "PHPUnit-" as the type in core/tests/Drupal/Tests/Core/Test/TestDiscoveryTest.php ,while the expectation is for simpletest.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Updated the DI in permission callbacks for TaxonomyPermissions.php, a change record is still needed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Updated the template_preprocess_field__comment hook name in Olivero and starterkit_theme, but a change record is still needed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Updating deprecation message for drupal:11.0.0.
The invocation of \Drupal::request() is located within a static function in DbUpdateController, making it uncertain whether it should be modified.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Updating the template_preprocess_field__comment hook name in Olivero and starterkit_theme.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

The Book and CKEditor modules are no longer part of the core in version 11.x. Therefore, the patch at #20 is no longer applicable.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

I've revised the issue description; please feel free to suggest any further changes if you think they are needed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Added type hinting in the batch process and changed the limit from 25 to 50 in the post_update hook.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Rerolling patch against Drupal 11.x and adding interdiff.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Attached patch against Drupal 11.x

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Solving failed test cases and rerolling for 11.x

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Hardik_Patel_12 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

The changes have been fixed on the 2.x.0 branch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

I have solved the warnings given by PHPCS and here is the patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Appreciate everyone's efforts โ€“ the problem has been resolved in the 2.x.0 branch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Thank you, everyone, for your contributions. I've made revisions to the code to incorporate wildcard logic. You can review the changes here: https://www.drupal.org/project/page_specific_class/issues/3373861 ๐Ÿ› The wildcard not work correct Fixed

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

The issue has been fixed to the 2.0.x branch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Thanks @Pracheth, the issue has been fixed to the 2.0.x branch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Thanks, @Pablo_Pukha and @Yogesh Kambari, the issue has been fixed to the 2.0.x branch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Adding patch which provide D10 compatibility.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

The New Drupal 10 compatibility module is released, thank you all for your efforts.

๐Ÿ‡ฎ๐Ÿ‡ณIndia Hardik_Patel_12 India

Tried to solve failed test case. Kindly review a patch.

Production build 0.71.5 2024