Line ending normalizing is broken on WAMP

Proposed solution:

Fix the normalization of line endings to work on windows.
Now:

// Normalize line endings. $doc_comment = preg_replace('/\r\n|\r/', '\n', $doc_comment);

My patch:

// Normalize line endings. $doc_comment = str_replace('\r\n', '\n', $doc_comment); $doc_comment = str_replace('\r', '\n', $doc_comment);

And a screenshot of the fixed version is attached and linked → .

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
needs-review-queue-bot
The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
Comment almost 2 years ago →
🇮🇳India ranjith_kumar_k_u Kerala
Rerolled #35
Comment 11 months ago →
🇮🇳India Hardik_Patel_12 India
The test is unsuccessful because the code $info = TestDiscovery::getTestInfo($classname, $doc_comment); is returning "PHPUnit-" as the type in core/tests/Drupal/Tests/Core/Test/TestDiscoveryTest.php ,while the expectation is for simpletest.

Problem description: