- 🇫🇷France andypost
DraggableListBuilder should also be replaced.
it has changes as trait extracted already via 📌 Extract DraggableListBuilderTrait from DraggableListBuilder for use with content entities Needs work
btw Action module is going to be deprecated, see 📌 [meta] Tasks to deprecate Actions UI module Active
- Status changed to Needs review
9 months ago 5:15pm 2 March 2024 - 🇫🇷France andypost
Rebased and updated deprecation for 10.3
The
\Drupal\Core\Config\Entity\DraggableListBuilder::__construct()
has following comment so should stay as is// Do not inject the form builder for backwards-compatibility. $this->formBuilder = \Drupal::formBuilder();
Also updated IS
- Status changed to Needs work
9 months ago 7:03pm 2 March 2024 - Status changed to Needs review
9 months ago 10:04pm 2 March 2024 - 🇬🇧United Kingdom joachim
Does this need a CR? Entity handlers and plugin classes are internal.
- Status changed to RTBC
9 months ago 5:11pm 3 March 2024 - Status changed to Fixed
9 months ago 12:17pm 4 March 2024 - 🇬🇧United Kingdom catch
Does this need a CR? Entity handlers and plugin classes are internal.
IMO we should not add CRs for internal code, especially not constructor changes, and just link to the issue itself - however the extra work's already been done here and the docs for when to add a CR aren't conclusive either way, so committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
- 🇳🇿New Zealand quietone
The change record here should include a before and after example to help the reader. And I think it needs rewording to be easier to read.
- 🇫🇷France andypost
Re #43 sometimes we add like https://www.drupal.org/node/3395991 →
@quietone I think CR can add, that classes extending this ones should be updated to pass
form_builder
service to parent Automatically closed - issue fixed for 2 weeks with no activity.