- Issue created by @quietone
- π³πΏNew Zealand quietone
There are no migrations to move, this was already done in #3067299: Move actions migrations and tests to system module β .
- π³πΏNew Zealand quietone
I did not find action module in any profile.
- π«π·France andypost
Filed child issue π Create actions 1.x branch for Drupal 11 Postponed
- π«π·France andypost
Removing references to the extension from database dumps.
Looks that's the only task from summary left
- π«π·France andypost
There's only one usage in
drupal-9.4.0.filled.standard.php.gz
(core.extension
) and later in routing'data' => 'a:3:{s:6:"module";a:60:{s:6:"action";i:0;s:14:"automated_cron";i:0;s:3:"ban";i:0;s:10:"basic_auth";i:0;s:5:"block";i:0;s:13:"block_content";i:0;s:4:"book";i:0;s:10:"breakpoint";i:0;s:9:"ckeditor5";i:0;s:7:"comment";i:0;s:6:"config";i:0;s:18:"config_translation";i:0;s:7:"contact";i:0;s:19:"content_translation";i:0;s:10:"contextual";i:0;s:8:"datetime";i:0;s:5:"dblog";i:0;s:6:"editor";i:0;s:5:"field";i:0;s:8:"field_ui";i:0;s:4:"file";i:0;s:6:"filter";i:0;s:4:"help";i:0;s:7:"history";i:0;s:5:"image";i:0;s:8:"language";i:0;s:4:"link";i:0;s:6:"locale";i:0;s:7:"menu_ui";i:0;s:7:"migrate";i:0;s:14:"migrate_drupal";i:0;s:5:"mysql";i:0;s:4:"node";i:0;s:7:"options";i:0;s:10:"page_cache";i:0;s:4:"path";i:0;s:10:"path_alias";i:0;s:5:"pgsql";i:0;s:16:"responsive_image";i:0;s:4:"rest";i:0;s:6:"search";i:0;s:13:"serialization";i:0;s:8:"shortcut";i:0;s:6:"sqlite";i:0;s:10:"statistics";i:0;s:6:"syslog";i:0;s:6:"system";i:0;s:8:"taxonomy";i:0;s:9:"telephone";i:0;s:4:"text";i:0;s:7:"toolbar";i:0;s:4:"tour";i:0;s:7:"tracker";i:0;s:6:"update";i:0;s:4:"user";i:0;s:8:"views_ui";i:0;s:5:"forum";i:1;s:17:"menu_link_content";i:1;s:5:"views";i:10;s:8:"standard";i:1000;}s:5:"theme";a:3:{s:5:"stark";i:0;s:5:"claro";i:0;s:7:"olivero";i:0;}s:7:"profile";s:8:"standard";}',
- πΊπΈUnited States dww
Whoops, a bit late to the game. Wish I saw all this in time to have posted this to π± [Policy] Deprecate Action (UI) module in D10 and move to contrib in D11 Fixed , but that's already done and decided...
While I mostly agree that the "Actions UI" module is confusing and not terribly helpful on its own, π Dynamically provide action plugins for every moderation state change Needs work is categorized as a "Major feature", followed by 152 (which is very high for most core issues). Perhaps that issue can be changed so that you don't have to enable the Action UI to create individual actions for the content_moderation transitions you want, and it would instead dynamically provide actions for everything automatically. But that'd introduce its own UI problems, since then everywhere you get a list of actions, you might have dozens of new actions you have to hide that don't make sense, etc. It's clunky, but having to manually create the actions you actually need (instead of getting everything automatically) is kinda helpful.
Anyway, would love to hear thoughts on how to handle (much needed) functionality like that issue, if we have no more Actions UI in core.
Thanks/sorry!
-Derek - π«π·France andypost
As I see we have no contribution to actions at all because of this incomplete transition to contrib
To unblock we should deprecate it or unblock issues
- π³πΏNew Zealand quietone
Found tests that are not in the action module that are installing the action.
- π«π·France andypost
curious about tests as node/comment actions require actions UI to be configured
which means we can not do functional testing without it
- π³πΏNew Zealand quietone
Can you point to a specific test? My searching does not find any other test that installs the Action module. The comment tests look like they use actions but not the UI provided by the Action module.
- π«π·France andypost
Added links to #14 - both plugins require ui to configure keywords
- π¬π§United Kingdom catch
CommentActionsTest directly updates the plugin configuration to test the keywords functionality, so I think the plugin and tests will continue to work if we move action module to contrib.
However, I'm not sure those two plugins make sense without a UI, so maybe we should also consider an issue to move them into the actions_ui module?
- π«π·France andypost
Not sure it makes sense to deprecate them, because there's goto,message,email actions in core https://git.drupalcode.org/project/drupal/-/tree/11.x/core/lib/Drupal/Co...
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Just ran into obscure Action-related edge cases over at #3361534-70: KernelTestBase::$strictConfigSchema = TRUE and BrowserTestBase::$strictConfigSchema = TRUE do not actually strictly validate β . Glad to see this happening!
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Oh and per #3266458-11: [Policy] Deprecate Action (UI) module in D10 and move to contrib in D11 β , I think this issue is a bit misleading β is this tweak accurate? π
- π«π·France andypost
Last blocker is RTBC π Move some Action plugins to Action module Needs review
Now it needs infra team to create project and then I can split 1.x branch in π Create actions 1.x branch for Drupal 11 Postponed
- π«π·France andypost
Now only deprecation of module is lest π Final steps to deprecate Actions module Postponed
I'm going to append split in contrib after π Move some Action plugins to Action module Needs review
Btw the cleanup landed with 2 follow-ups
- π Stop using action in user module in role entity hooks Active
- π [PP-1] Move configurable user actions to the actions module Active - π«π·France andypost
Docs updated https://www.drupal.org/node/3223395#s-action β
- π«π·France andypost
- π¬π§United Kingdom catch
The project page could use an update: https://www.drupal.org/project/action β
- Status changed to RTBC
9 months ago 10:06pm 14 March 2024 - π«π·France andypost
I did update of project page, looks we can mark it fixed
- Status changed to Fixed
9 months ago 10:40am 25 March 2024 - π«π·France andypost
Filed follow-up π Move permission, jsonapi and rest tests out action module Active
Automatically closed - issue fixed for 2 weeks with no activity.