Dynamically provide action plugins for every moderation state change

hi,

Patch Not working for 9.5.1,
i am able to publish/unpublish specifically, but not able to do using bulk operations.
any working patch available ?

thanks

Self review

For Drupal 10 applying the patch no longer seeing the options appear.

Issue summary may need to be updated for how to get to show.

Any info regarding the issues in 9.5.1 / 10? Have only tested in 9.4.10 just now -- I applied #215 and it works, however:

I am not sure why there is an access check for the user having edit permissions for the node in question. The permission controlling this functionality should be solely the transition permissions within Content Moderation, like it is with the Content Moderation form that appears on a node (the user does not need edit permissions in order to use that form and transition the node using that form).

Patch #218 not working for 9.5.4

Confirming that the patch in #218 📌 Dynamically provide action plugins for every moderation state change Needs work works on Drupal 9.5.8.

Not sure what might have been going on for @daniel-korte with 9.5.4.

Yup, disregard #219. It was a configuration issue on my end.

Can someone confirm if #218 📌 Dynamically provide action plugins for every moderation state change Needs work works on Drupal 10 or any other update around for D10?

@Parashram, the moderated_content_bulk_publish module allows similar functionality and is compatible with Drupal 10.
Brief explanation; if you have an out of the box workflow, use 2.0.x, however if you have a custom workflow try 3.0.x and adjust the configuration as necessary to fit your workflow.
Check the readme 2x and the project page for more information.

I can confirm that the patch in #218 works very well in Drupal 10.1.1, PHP 8.1.8!

I tested as an admin and as a user who does not have permission to change to the state they tried to bulk update to. The only thing that seemed a little strange (to me at least) was that the access denied message for the user without permissions came after the bulk operation looked like it had run. Seems like a little better UX to have the message appear before the running the operation (perhaps when the user clicks Apply on the moderation state action screen).

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Try to fix deprecation errors.

Dynamically create/update/delete action instances when:

create/update/delete operation happens on a workflow entity by implementing hook workflow (insert|update|delete).
changes to the workflow entity happen during config import.
changes to the workflow entity are done hook_update_N.

According to the issue summary this still needs to be done or marked complete.

Is there need to keep configurable actions in core? In context of 📌 [PP-1] Move configurable user actions to the actions module Active

Will this issue be fixed anytime soon?

I have a request where I would like to use content moderation but I cannot do this without bulk operations in the content admin page.

Created a new MR based on 11.x using the patches from #218 and #228 to trigger GitLab CI checks and to make addressing the remaining tasks easier.

Leaving status as "Needs work" for #229.

Hi,

Thanks for everyone's work on this so far.

Just creating a fixed diff file from the last commit 2643761b so we can test this in multiple development environments (Drupal 10.3.5 / PHP 8.2.18).

Hi,

I have moved content_moderation_update_110001 to `content_moderation.post_update.php` file to prevent any feature conflict with hook_update_N implementations

When I tried the version in the 2797583-11.x branch, the action failed to run on translations with an error stating "This value should not be null." I looked into this and was able to find that the translation was being validated even though its isValidationRequired flag was FALSE. Given this, my assumption is that the validation check doesn't always need to be run. However, if this is incorrect please let me know and we can reassess.

For now, I've pushed an update to the branch that checks the isValidationRequired flag and only performs the validation if it returns TRUE. Otherwise, it sets $violations to 0. It also checks to make sure $violations is an instance of EntityConstraintViolationList before attempting to use the count() method.

With this code in place, I'm able to use the action on both untranslated and translated nodes.

I attempted to apply the latest diff to Drupal 10.4, but it was unsuccessful. Do you have any plans to address this?

@chamilsabjeewa I had the same problem the other day. I created a 10.4.x branch and opened a merge request for it. You can get a working patch from there. It's working well for me so far on 10.4.2.

Hi @jsutta
I am using Drupal 10.4.3, and this patch does not solve the problem.