#Workflow Initiative

Hello,

Thank you for the work done!

I notice that the "Revisions" link in the primary local tasks is not positioned in the same place as on the node entity type:.

Indeed, an entry is missing in taxonomy.links.tasks.yml.
Here is the one present in the node entity type:

entity.node.version_history:
  route_name: entity.node.version_history
  base_route: entity.node.canonical
  title: 'Revisions'
  weight: 20

What do you think?

Changed Target Branch to 11.x and updated latest changes as patch for backup before target branch change.

@amateescu: Great news! This was on my hot-list for long, but never found time.

From my mental notes:
> Add a boolean temporary base field to the workspace entity type
As "managed" workspace, it shloudl rather be a "Owner"/"Provider" base field, so modules can recognize their workspaces (which obeoletes the boolean field).

WDYT?

catch → closed merge request !10147

catch → credited lauriii → .

Thanks this looks good, nice catch on the moved toolbar hook implementation.

Committed/pushed to 11.x and cherry-picked to 11.1.x, thanks!

Why don’t I see removals of the new Hooks added to workspaces_ui to support toolbar, etc.

That was because of 📌 [ignore] Convert everything everywhere all at once Active , fixed in https://git.drupalcode.org/project/drupal/-/merge_requests/10147/diffs?c...

amateescu → changed the visibility of the branch 2972622-split-workspaces_ui to active.

amateescu → changed the visibility of the branch 2972622-split-workspaces_ui to hidden.

RTBC

The approach makes sense to me. It feels a little bit weird to have workspace tests need to enable workspaces_ui but for integration tests the UI is obviously needed.

But one curious observation:

Why don’t I see removals of the new Hooks added to workspaces_ui to support toolbar, etc.

I had expected a big removal from workspaces.module, but there is nothing.

Maybe that is related to the hook_help problem?

The suggestion from #27 sounds great, pushed it to the MR.

Started working on this.

Allows users to stage content or preview a full site by using multiple workspaces on a single site.

Change to maybe this?

Provides an API for staging and previewing content in a full site context.

As a core product manager I think this makes sense. It allows us more flexibility in the future to possibly remove the big UI for example from core if we think its not an 80% use case even if content moderation or node preview is.

Only minor note is the description of the original module now does not reflect what it does? The module does not provide full site previews after this MR.

Allows users to stage content or preview a full site by using multiple workspaces on a single site.

This is minor IMHO but would be still useful to fix to make it easier to understand what's the relation between the two modules. But leaving needs review for more reviews as appropriate.

#141 still works for 10.3.8