- đ¸đŽSlovenia alesr
I stumbled upon a related issue to this one.
Simple scenario: specific user role needs to be able to Publish/Unpublish one specific content type.
I don't understand why this cannot be added as permission which would solve this issue too.
Instead of giving this user role the whole "Administer content" permission with all the caveats which apply to all content types and/or setting
$form['status']['#access'] = TRUE;
in the form_alter. - First commit to issue fork.
- Merge request !11605Issue #3059030: Show disabled Published checkbox when user doesnt have access â (Open) created by acbramley
- đŚđşAustralia acbramley
I think the disabled checkbox with description text makes a lot of sense, it also follows patterns we already have in other areas such as how ModerationHandlers disabled the Create new revision checkbox.
The last patch contained a huge amount of unrelated code so I'm spinning up an MR with just the NodeForm change.
We also need to specifically check the permission so we don't surface the checkbox when content_moderation is installed (i.e we don't want to change content_moderation's NodeAccessTest.
MR going up to see what issues this may cause
- đŚđşAustralia acbramley
We only had 1 test failure which wasn't for the status checkbox, but the Published status in the meta information. I've fixed that and added additional test coverage for the checkbox
- đşđ¸United States smustgrave
Since this appears to be a UI change can the summary get some bfore/after screenshots please
Thanks!
- đłđąNetherlands ifrik
This works for me, and it will finally show users without the right permissions what the publish status is, but also they can't change it.
- đşđ¸United States smustgrave
Instead of a new test could the existing tests be expanded, where you made the edits.
- đŚđşAustralia acbramley
@smustgrave I don't feel like
testNodeMetaInformation
is the right place to test the visibility of the Published checkbox. I prefer test cases to be succinct in what they test rather than having massive test cases asserting all sorts of things. It makes it easier to maintain and understand why something failed when it does. - đşđ¸United States smustgrave
But does this warrant a full bootstrap being a functional test?