The current way of associating a revision with a workspace has a couple of problems:
- the association history is lost when a workspace is published to Live, because we delete all entries from the workspace_association tables
- when we introduce workspace hierarchies, operations on the workspace_association entities will be either 1) very costly, because we have to update all the associations of a workspace as well as its descendants, or 2) bypass the Entity API completely, which makes the current implementation completely unnecessary overhead :)
- track the workspace in which a revision was created in a (revision metadata) base field
- convert the workspace_association entity type to a custom index table
Discuss, agree on the proposed resolution, write upgrade path and tests.
Nope.
The workspace_association will be a service in the container instead of an entity type.
All entity types supported by Workspaces will have an additional revision metadata (reference) field: workspace
TBD.
Fixed
8.8 ⚰️
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
+++ b/core/modules/workspaces/workspaces.install
@@ -32,6 +34,27 @@ function workspaces_requirements($phase) {
+ * Implements hook_module_preinstall().
...
+function workspaces_module_preinstall($module) {
+ if ($module !== 'workspaces') {
+ return;
This hook should be moved to .module file so this condition is useless, faced in #3118155-20: Improve hook_module_preinstall & hook_module_preuninstall to include recommendations for config import and pass an $is_syncing argument →