- @amateescu opened merge request.
- Status changed to Needs review
8 months ago 2:39pm 8 March 2024 - π·π΄Romania amateescu
Rerolled the latest patch and turned it into a MR.
- π·π΄Romania amateescu
The MR is fully ready for reviews now, hiding old patches.
- Status changed to RTBC
8 months ago 7:41pm 15 March 2024 - πΊπΈUnited States smustgrave
Using block_content json tests as references and a few other. The test coverage seems to line up with what we've done in others.
LGTM!
- π¬π§United Kingdom catch
I looked at this two or three times and the UNCACHEABLE/MISS changes put me off committing it just yet, but... I can't think of anything else we can do here, and this is in the base class for test coverage that even the subclasses don't directly interact with, it'll make it less likely that the next entity type has to do anything special, then noticed Wim pointing out we already do the same thing elsewhere already in the test coverage. So... committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!
- Status changed to Fixed
8 months ago 10:35am 25 March 2024 Automatically closed - issue fixed for 2 weeks with no activity.