Cannot save unpublished versions of published content for users without manage book privileges

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

The issue summary needs an update as it mentions D8, are the steps the same for D10?
What was the proposed solution to solve the problem?
Remaining tasks?
etc.

What is the latest here? How soon might we expect a review to take place? Thanks.

The issue continues to exist in Drupal 10.

hiding the patches for clarity as MR are encouraged and preferred. That said could a 11.x MR be opened or current one target branch updated.

It's impossible to rebase the old MR https://git.drupalcode.org/project/drupal/-/merge_requests/3109 onto D11 hence I cherry-picked the top commit into a new MR against 11.x branch.

Another alternative is to set your local version of the old merge request branch to your cherry-pick branch and then force-push it. That would re-use the old merge request.

Is there a way to get a patch/fix for this on 10.2.x?

Moving to contrib but very much still needed.

#101 🐛 Cannot save unpublished versions of published content for users without manage book privileges Needs work Was over a year ago wondering if this bug had been patched.

smustgrave → posted 2 patches with no information shortly after.

I am still seeing You can only change the book outline for the published version of this content and wonder when/if the book module will be fixed?

There probably needs to be a new issue fork and merge request on the new repo.

My merge commit in #112 applies the patch from comment @93, but now I see that there has been additional work done in later commits. I'll try to add those to the new merge request.

Changed to 2.0.x but test appears to be failing

So tweaked the function call some that if current user has permission "add any content to books" it skips checking if content type is allowed. This should cover any backwards compatibility concerns. Thoughts?

Will eventually have to fix that error too.

Still seems to have relevant test failure.

Fixed the test

Repro steps.

Drupal 10.3 standard install profile.

1. Have a published book and basic page.
2. Enable content moderation workflow and add basic page and book content types to the editorial workflow.
3. Give content editor role the create_new_draft, Add non-book content to outlines, and create new books permissions. Do not give them "Add content and child pages to books and manage their hierarchies."
4. Login as content editor. Attempt to save as draft.
5. Error message prevents save: "You can only change the book outline for the published version of this content."

Testing steps.

same setup as above.

1. Still logged in as a content editor, attempt to save the same nodes as step 1 in the repro steps.
2. The nodes save as expected.
3. Give the content editor access to the published transition.
4. Edit the nodes and add them to a book outline and change the state to "published".
5. The nodes save as expected, and the nodes are added to the books.

Moving to RTBC.

Automatically closed - issue fixed for 2 weeks with no activity.