jjchinquist → credited rominronin → .
Update: I will need to add some js code to the sidekick_js library to prevent the default close actions.
Since yesterday afternoon I've been investigating the modal persistence issue, I'm embarrassed to say how long it took me to realise that the controller returning the AJAX response is where the dialog options are parsed.
Now that I finally found where to control the behaviour, I plan to update it.
On clicking the 'Open Sidekick' button:
- the button should load the iframe and insert it onto the page
- the button should be updated so it toggles the visibility of the iframe
I'll dive in to this topic to figure out how to achieve this in D10: https://www.drupal.org/docs/drupal-apis/ajax-api/core-ajax-callback-comm... →
Created a merge request!
rominronin → made their first commit to this issue’s fork.
rominronin → created an issue.
Forgot to add this before :)
This has been fixed in 1.0.0-alpha2. Closing
rominronin → made their first commit to this issue’s fork.
What is the latest here? How soon might we expect a review to take place? Thanks.
rominronin → created an issue.
Following issue.