rominronin → created an issue. See original summary → .
This patch simply removes the breaking js from the module (we will revisit it later, since it's necessary for the sidekick chat feature to be content aware).
Disregard the last message for now (possibly turn it into a future task).
While debugging the issue I found the cause, and it will require a separate task to fix completely 3485590 🐛 sidekick.js conflicts Active .
For now, I implemented a fix for the alt text generation on create forms, bear in mind if you select any of the `Show Sidekick in Sidebar` options except `Don't display` (admin/config/services/sidekick), you will likely encounter issues until that task is resolved.
Marking as fixed for now.
rominronin → created an issue.
I took a deeper dive into what's going on behind the image alt text issue, and there are numerous issues with the workflow and implementation, so I think it's better to redefine what's intended and work towards that:
- As normal, a site builder can define, per image field, if alt or title fields should be enabled
- Sidekick can be enabled on the form display settings page per image field.
- IF enabled, there should be a checkbox to select alt field (as the sidekick target for this field)
- On the form (add or edit) page, the 'enable sidekick' setting should be checked, then the generate button should be displayed according to the form field settings.
- If 'enable sidekick' is not checked, the default core settings should be respected without interference
This last point is just one of the issues we currently have with the workflow.
jjchinquist → credited rominronin → .
jjchinquist → credited rominronin → .
Ready, willing and able to contribute
rominronin → created an issue.
rominronin → created an issue.
The validation message was included. There is however another issue: the functionality doesn't work on the node/add form at all. This needs reviewing and fixing.
rominronin → changed the visibility of the branch 3479664-meta-description-generation to hidden.
rominronin → changed the visibility of the branch 3479664-meta-description-generation to hidden.
One of the API input parameters ('prefer') was hard-coded.
This was completed, but somehow regressed in the refactor. It has now been restored in https://www.drupal.org/project/sidekick/issues/3480769 🐛 modal button does not work in Claro Theme Active
A publicly accessible image URL needs to be delivered to the API. This is not possible in local development or protected stage environments (without additional work).
Finding a solution to this is currently beyond the scope of the module.
We decided to notify users of API errors using Drupal's form field validation messages, so they at least understand why alt text cannot be generated (in non-public environments).
rominronin → created an issue.
rominronin → created an issue.
rominronin → created an issue.
rominronin → created an issue.
The general issues are broadly fixed with the last merge. Development will continue per issue.
rominronin → created an issue.
rominronin → created an issue.
This has now been fixed, and much of the standard functionality has been restored
Closing. This will be dealt with over here: https://www.drupal.org/project/sidekick/issues/3479535 🐛 Fix general issues causing breaks Active
Closing. This will be dealt with over here: https://www.drupal.org/project/sidekick/issues/3479535 🐛 Fix general issues causing breaks Active
rominronin → created an issue.
rominronin → created an issue.
Pushed to the dev branch (accidentally)
rominronin → created an issue.
Would be nice to include instructions for correctly configuring the/a linter. Out of the box, the automatic eshint scan finds a random .eslintrc file in the modules folder.
I'm reopening this issue, since the js seems to conflict with the image widget ajax process.
I'm reopening this issue, since the js seems to conflict with the image widget ajax process.
Grienauer → credited rominronin → .
jjchinquist → credited rominronin → .
Update: I will need to add some js code to the sidekick_js library to prevent the default close actions.
Since yesterday afternoon I've been investigating the modal persistence issue, I'm embarrassed to say how long it took me to realise that the controller returning the AJAX response is where the dialog options are parsed.
Now that I finally found where to control the behaviour, I plan to update it.
On clicking the 'Open Sidekick' button:
- the button should load the iframe and insert it onto the page
- the button should be updated so it toggles the visibility of the iframe
I'll dive in to this topic to figure out how to achieve this in D10: https://www.drupal.org/docs/drupal-apis/ajax-api/core-ajax-callback-comm... →
Created a merge request!
rominronin → made their first commit to this issue’s fork.
rominronin → created an issue.
Forgot to add this before :)
This has been fixed in 1.0.0-alpha2. Closing
rominronin → made their first commit to this issue’s fork.
What is the latest here? How soon might we expect a review to take place? Thanks.
rominronin → created an issue.
Following issue.