Modal Button Title and close behavior

Created on 9 June 2023, over 1 year ago
Updated 2 February 2024, 8 months ago

Problem/Motivation

Currently the Sidekick Modal Button is called "click here for Sidekick modal"
I would suggest "open Sidekick" as a title.

Also is it possible, that if the modal is closed, it gets just hidden and not closed?
If a user closes and opens the modal again, the content is lost, it would be good to prevent that.

📌 Task
Status

Active

Version

1.0

Component

User interface

Created by

🇦🇹Austria Grienauer Vienna

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Grienauer
  • 🇦🇹Austria Grienauer Vienna

    Part one was done in dev release.
    It is still open, to not close/remove context of sidekick when closing sidekick in modal window)

  • First commit to issue fork.
  • 🇦🇹Austria rominronin Vienna

    Since yesterday afternoon I've been investigating the modal persistence issue, I'm embarrassed to say how long it took me to realise that the controller returning the AJAX response is where the dialog options are parsed.

    Now that I finally found where to control the behaviour, I plan to update it.

    On clicking the 'Open Sidekick' button:
    - the button should load the iframe and insert it onto the page
    - the button should be updated so it toggles the visibility of the iframe

    I'll dive in to this topic to figure out how to achieve this in D10: https://www.drupal.org/docs/drupal-apis/ajax-api/core-ajax-callback-comm...

  • 🇦🇹Austria rominronin Vienna

    Update: I will need to add some js code to the sidekick_js library to prevent the default close actions.

Production build 0.71.5 2024