Hmm I still don't know about this.
I tested it out, and when I check the box I see a list like this , there doesnt seem to be a way to create a new book from this, just add to the existing list. If this does work, I don't know about having a checkbox that you uncheck to remove from the book, it just doesn't seem like a big improvement over the current setup overall.
Seems like I needed mocking to do the headers test. I wasn't really familiar with that but I got ChatGPT to help me. It seems fine?
All green now.
I think it's core, really all Diff (and it looks like other modules) is doing is trying to get some information from Workflow about the state previous revisions were in, but Workflow is throwing an exception. There should probably be some mechanism in Workflow to set entities using deleted moderation states to "draft" or something, but that's a separate topic. For now, I think it makes sense for Workflow to not throw an exception here if it can't load the state.
I pushed up the fix for that, just need to write a test.
mdranove → changed the visibility of the branch 11.x to hidden.
mdranove → changed the visibility of the branch 3304672-invalidargumentexception-the-state to hidden.
There's still an issue, but it's a different one from the one I originally reported. Updated the repro steps.
Ok so it looks like the changes in https://www.drupal.org/project/better_exposed_filters/issues/3528584 🐛 Html validation error due to non allowed attributes Active were what caused this issue.
I have it working in the latest MR by reverting those changes, fixing up the ajax js a little bit. Also added a test.
Not sure what the implications are for the issue reported in 3528584 🐛 Html validation error due to non allowed attributes Active .
I'll put it in NR for now.
This works but the update to the bef_links_use_ajax.js is not needed, the fix works without it. Updates to that should be resolved in https://www.drupal.org/project/better_exposed_filters/issues/3555023 →
It's not fixed by #3542106: Pager links doesn't work when ajax is enabled. I added the test here as requested, but let's just be aware this will cause a merge conflict with 3075674 🐛 Option "All" doesn't work for links Active since they both are going to rely on this test.
- Remove old "note" regarding functionality that is not available in 8.0 and is "postponed" until 9.5.0.
- Removed note referencing an ongoing discussion in https://www.drupal.org/project/drupal/issues/2609250 🐛 Lazy builder broken (#type defaults not loaded) Needs work about whether or not to allow the #type property in lazy builders.
Ok so I've pushed up a fix. There's a test for this that already exists in Select All/None link appears even when not enabled 🐛 Select All/None link appears even when not enabled Active , just needs to be modified to have ajax enabled on the view. I think what would be good is to merge that one first, then modify the test in it after it's merged. So I'll just put this into NR for now and then we can edit the test once 3555036 is merged.
On further review found that ajax being broken with links was a preexisting bug for 7.1.x. Opened 3555023 →
Noticed that the changes break AJAX with links. Moving back to NW.
mdranove → changed the visibility of the branch 3075674-select-all-none-links-preprocess to hidden.
mdranove → changed the visibility of the branch 3075674-option-all-doesnt to hidden.
The MR is only for select elements, as the repro steps state "Select a filter option from the dropdown menu.."
Radios/checkboxes are not mentioned and not covered by this.
Updated based on feedback. Moving to needs review.
Also opened 3553402 to address textual references to "Drupal 8".
Hello,
Was using UI Patterns Views to display a views row component inside of a views format component.
I took a look and yes we were using "force using fields". I unchecked that and all seems to work as expected. So if that's the expectation then this can be closed
Thank you
I tested this out but I noticed that when you go to edit a book node that is already part of a book, or is the top level page in a book, the "Create new book" checkbox appears and is checked. This is confusing as I would think at this point the option to create a new book should no longer exist.
Additionally, if you uncheck the checkbox and save, nothing changes, and then when you edit the book node again the checkbox remains checked.
All in all a somewhat confusing UX. Im wondering if the behavior should be that if the node is already in a book the checkbox disappears.
Sure thing, this is from a fresh install.
The pencil icon is not on the image in the WYSWYG, it's when you are viewing the media library using the CkEditor 5 drupal-media widget.
Updated the auto_submit js and added a test.
I ran into some issues with select autosubmit more generally using the default widget and a fresh install, but it was unrelated. Might capture in a separate issue.
The documentation on the api page and in core/lib/Drupal/Core/Entity/entity.api.php have been updated to recommend $entity->getOriginal() instead of $entity->original, which makes this issue no longer relevant.
mdranove → changed the visibility of the branch 3551842-allowed-type-with to hidden.
Removed permission, added update hook, updated tests, updated access controller.
That permission is still good I think, I updated the route access controller to check for it. Also updated tests. Moving to NR.
This is caused by this code in BookNodeOutlineAccessCheck.php
if (!empty($node->getBook()['bid']) && !$node->isNew() || $this->currentUser->hasPermission('add any content to books')) {
return AccessResult::allowed();
}
MR to remove this, moving to NR.
Unrelated, but I noticed that this config doesn't seem to do anything. In this example screenshot, I can add articles as child type of book pages and vice versa.
Yeah, good point, because of https://www.drupal.org/node/3295826 → now you can get the original entity by doing $entity->getOriginal(). I see this in the doc comment for hook_ENTITY_TYPE_presave, not sure if we want to also add it to hook_entity_presave.
mdranove → changed the visibility of the branch 3191463-improve-hookentitypresave-documentation to hidden.
I can't confirm the issue exactly. My d11 install shows the outline like this
That being said, it does seem nicer to have the directional arrows inline with the titles of the book.
Change is simple enough, I tested it and it works well. Moving to RTBC.
mdranove → changed the visibility of the branch 3230281-issue to hidden.
mdranove → changed the visibility of the branch 3230281-6mm to hidden.
mdranove → changed the visibility of the branch 3230281-link-to-drupal to hidden.
mdranove → changed the visibility of the branch 3230281-link-to-drupal-theming to hidden.
mdranove → changed the visibility of the branch 3230281-drupal-theming-guide-links to hidden.
Changes introduced in 3533929 📌 [2.1.0] Views Rows source : add an option to be able to return each row as an array of visible fields Active seem to be the issue. Component loads as expected after reverting.
Fair questions, yes I did remember to clear cache (thankfully), and yes was just viewing the page., not editing.
Found the issue, the id instead of the title was getting passed to the hidden <h2> that's in the book navigation template.
Does this need a test?
I hesitate to add repro steps until https://www.drupal.org/project/drupal/issues/3462677 🐛 Exposed Filter in Views Redirects to Page Display Path Instead of Block Path Active is resolved, but this is potentially still an issue. If drupal core 3462677 is resolved, would be worth testing the following:
- Create a view with both a page and block
- Add global combine fields filter and an exposed sort "Combine sort order with sort by" checked.
- Add the block to a page and try the sort and make sure it works.
yeah looks like there was an error that phpcs was not catching locally? Weird. Anyway, fixed it.