mdranove → changed the visibility of the branch 3191463-improve-hookentitypresave-documentation to hidden.
I can't confirm the issue exactly. My d11 install shows the outline like this
That being said, it does seem nicer to have the directional arrows inline with the titles of the book.
Change is simple enough, I tested it and it works well. Moving to RTBC.
mdranove → changed the visibility of the branch 3230281-issue to hidden.
mdranove → changed the visibility of the branch 3230281-6mm to hidden.
mdranove → changed the visibility of the branch 3230281-link-to-drupal to hidden.
mdranove → changed the visibility of the branch 3230281-link-to-drupal-theming to hidden.
mdranove → changed the visibility of the branch 3230281-drupal-theming-guide-links to hidden.
Changes introduced in 3533929 📌 [2.1.0] Views Rows source : add an option to be able to return each row as an array of visible fields Active seem to be the issue. Component loads as expected after reverting.
Fair questions, yes I did remember to clear cache (thankfully), and yes was just viewing the page., not editing.
Found the issue, the id instead of the title was getting passed to the hidden <h2> that's in the book navigation template.
Does this need a test?
I hesitate to add repro steps until https://www.drupal.org/project/drupal/issues/3462677 🐛 Exposed Filter in Views Redirects to Page Display Path Instead of Block Path Active is resolved, but this is potentially still an issue. If drupal core 3462677 is resolved, would be worth testing the following:
- Create a view with both a page and block
- Add global combine fields filter and an exposed sort "Combine sort order with sort by" checked.
- Add the block to a page and try the sort and make sure it works.
yeah looks like there was an error that phpcs was not catching locally? Weird. Anyway, fixed it.
This is ready for review.
I used chatgpt to generate the js, edited it slightly, ran the npm commands to build it, then tested on drupal 11.2 and 10.2 sandboxes. Works as expected.
Also added helper text to the field widget.
mdranove → created an issue.
mdranove → made their first commit to this issue’s fork.
Hi @anybody.
Yes looks like 🐛 It's possible to overflow the number of allowed items with edit selection Active is a duplicate issue, although the proposed resolution is different than what is done here. I tried the patch provided in the ticket and it throws an exception on my Drupal 10.2,
I recommend moving forward with this MR.
Reopening this. Ran into this issue on 11.2.2 core. Added repro steps
mdranove → created an issue.
mdranove → created an issue.
mdranove → created an issue.
mdranove → created an issue.
Here it is as a patch
Disclaimer: I wrote most of this myself using xdebug to figure out what to set, but I consulted generative AI software for a couple of things as well.
mdranove → created an issue.
Reviewed this, looks good, has update hook and tests, works as expected. Moving to RTBC
Hello, was taking a look at this. Wasn't able to reproduce, although I am little confused. There isn't a traversal links block, the traversal links are enabled in the book content type display config. Markup for that is preprocessed then sent to book-navigation.html.twig. Seems like yours might be using a twig override or other preprocessing. They look like this ootb (with book olivero)
This was a duplicate of https://www.drupal.org/project/views_scored_sort/issues/3523003 🐛 Datetime object is incorrect Active .
This is still busted for datetime fields. MOving back to NW
mdranove → created an issue.
Yes this sounds good, please open a feature request on Book and we can continue the work there.
mdranove → made their first commit to this issue’s fork.
Merged changes locally and pushed back up.
mdranove → created an issue.
Followed the repo steps on a local install of 10.4.7 with book 2.0.2.
Translation of node published without issue and viewing while logged out did not produce an exception.
Are there other repro steps that might trigger this error?
I had this same issue. patch works well, looks like a clean solution. Created MR and moving to NR. I think if we want to do some js work that should be done in a separate issue.
mdranove → changed the visibility of the branch 2825730-issue-with-selections to active.
mdranove → changed the visibility of the branch 2825730-issue-with-selections to hidden.
mdranove → made their first commit to this issue’s fork.
Added issues for the modules listed above.
- Book PDF - book_pdf/issues/3531561 🌱 Plan for Book 3.0 release Active
- Book Access Code - book_access_code/issues/3531550 🌱 Upcoming Book 3.0 release Active
- Custom Book Block - custom_book_block/issues/3531551 🌱 Plan for Book 3.0 release Active
- Book Tree Menu - book_tree_menu/issues/3531553 🌱 Plan for Book 3.0 release Active
- booktree - booktree/issues/3531554 🌱 Plan for Book 3.0 release Active
- Book menu sync - book_menu_sync/issues/3531558 🌱 Plan for Book 3.0 release Active
mdranove → created an issue.
mdranove → created an issue.
mdranove → created an issue.
mdranove → created an issue.
mdranove → created an issue.
mdranove → created an issue.
mdranove → created an issue.
mdranove → created an issue.
mdranove → made their first commit to this issue’s fork.
mdranove → created an issue.
mdranove → created an issue.
mdranove → created an issue.
Tested on drupal 11 install. Placed a book navigation block. With both show_top_item and use_top_level_title enabled, both configurations work as described.
Pushed up a commit to shorten the description for show_top_item. Moving to RTBC.
Reviewed on drupal 11.1.7, book 2.0. /book path only viewable to users with the permission. Update hook applies permission to any user with the access content permission.
mdranove → made their first commit to this issue’s fork.
I reviewed the docs, saw this
Alternatively, reorder nodes on the book listing. Choose Structure >> Books to see a list of the existing books. Click on the Edit Order And Titles button for the book you want to edit, drag the nodes into the structure and order them, click on Save Book Pages to save the changes.
That being said, I went ahead and
- Added info about the new setting to change the sorting method on the book settings tab.
- Fixed a few typos.
- Added information about the book_olivero submodule.
- Added info about the new setting to change the sorting method on the book settings tab.
- Fixed a few typos.
- Added information about the book_olivero submodule.