- Issue created by @VladimirAus
- 🇦🇺Australia VladimirAus Brisbane, Australia
✅ Automated fixes applied
✅ MR created
🛑 Remaining fixesFILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/linkchecker.admin.inc ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 5 WARNINGS AFFECTING 10 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 115 | ERROR | The array declaration extends to column 593 (the limit is 80). The array content should be split up over multiple lines 147 | WARNING | #options values usually have to run through t() for translation 148 | WARNING | #options values usually have to run through t() for translation 149 | WARNING | #options values usually have to run through t() for translation 150 | WARNING | #options values usually have to run through t() for translation 151 | WARNING | #options values usually have to run through t() for translation 159 | ERROR | The array declaration extends to column 107 (the limit is 80). The array content should be split up over multiple lines 199 | ERROR | The array declaration extends to column 801 (the limit is 80). The array content should be split up over multiple lines 254 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines 255 | ERROR | The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/linkchecker.pages.inc --------------------------------------------------------------------------------------------------------------------------------------- FOUND 7 ERRORS AFFECTING 7 LINES --------------------------------------------------------------------------------------------------------------------------------------- 118 | ERROR | Type hint "SelectQueryInterface" missing for $query 120 | ERROR | The array declaration extends to column 172 (the limit is 80). The array content should be split up over multiple lines 159 | ERROR | The array declaration extends to column 133 (the limit is 80). The array content should be split up over multiple lines 197 | ERROR | The array declaration extends to column 157 (the limit is 80). The array content should be split up over multiple lines 231 | ERROR | The array declaration extends to column 240 (the limit is 80). The array content should be split up over multiple lines 268 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines 269 | ERROR | The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines --------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/linkchecker.module ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 45 ERRORS AND 32 WARNINGS AFFECTING 75 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 12 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 18 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 25 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 45 | WARNING | '@todo' should match the format '@todo Fix problem X here.' 54 | WARNING | Line exceeds 80 characters; contains 102 characters 155 | ERROR | Missing parameter type 158 | ERROR | Missing parameter type 164 | ERROR | Missing parameter type 168 | ERROR | Missing parameter type 179 | ERROR | Missing parameter type 197 | ERROR | Description for the @return value is missing 232 | ERROR | Description for the @return value is missing 240 | WARNING | Line exceeds 80 characters; contains 90 characters 359 | WARNING | Line exceeds 80 characters; contains 89 characters 410 | WARNING | Line exceeds 80 characters; contains 87 characters 521 | ERROR | The array declaration extends to column 273 (the limit is 80). The array content should be split up over multiple lines 563 | WARNING | Line exceeds 80 characters; contains 89 characters 601 | ERROR | The array declaration extends to column 248 (the limit is 80). The array content should be split up over multiple lines 646 | ERROR | The array declaration extends to column 114 (the limit is 80). The array content should be split up over multiple lines 702 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines 707 | ERROR | The array declaration extends to column 191 (the limit is 80). The array content should be split up over multiple lines 711 | ERROR | The array declaration extends to column 216 (the limit is 80). The array content should be split up over multiple lines 714 | ERROR | The array declaration extends to column 223 (the limit is 80). The array content should be split up over multiple lines 744 | ERROR | The array declaration extends to column 218 (the limit is 80). The array content should be split up over multiple lines 747 | ERROR | The array declaration extends to column 224 (the limit is 80). The array content should be split up over multiple lines 776 | ERROR | The array declaration extends to column 222 (the limit is 80). The array content should be split up over multiple lines 779 | ERROR | The array declaration extends to column 219 (the limit is 80). The array content should be split up over multiple lines 882 | WARNING | Line exceeds 80 characters; contains 195 characters 895 | WARNING | Line exceeds 80 characters; contains 195 characters 919 | ERROR | The array declaration extends to column 319 (the limit is 80). The array content should be split up over multiple lines 922 | ERROR | The array declaration extends to column 269 (the limit is 80). The array content should be split up over multiple lines 1019 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 1023 | ERROR | The array declaration extends to column 327 (the limit is 80). The array content should be split up over multiple lines 1026 | ERROR | The array declaration extends to column 273 (the limit is 80). The array content should be split up over multiple lines 1111 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 1111 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 1111 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 1115 | ERROR | The array declaration extends to column 318 (the limit is 80). The array content should be split up over multiple lines 1118 | ERROR | The array declaration extends to column 269 (the limit is 80). The array content should be split up over multiple lines 1253 | ERROR | The array declaration extends to column 178 (the limit is 80). The array content should be split up over multiple lines 1339 | WARNING | Line exceeds 80 characters; contains 81 characters 1343 | WARNING | Line exceeds 80 characters; contains 84 characters 1347 | WARNING | Line exceeds 80 characters; contains 82 characters 1391 | ERROR | The array declaration extends to column 178 (the limit is 80). The array content should be split up over multiple lines 1431 | WARNING | Line exceeds 80 characters; contains 81 characters 1435 | WARNING | Line exceeds 80 characters; contains 84 characters 1439 | WARNING | Line exceeds 80 characters; contains 82 characters 1535 | WARNING | Line exceeds 80 characters; contains 81 characters 1539 | WARNING | Line exceeds 80 characters; contains 84 characters 1543 | WARNING | Line exceeds 80 characters; contains 82 characters 1602 | WARNING | Line exceeds 80 characters; contains 81 characters 1606 | ERROR | Missing parameter comment 1608 | ERROR | Type hint "array" missing for $links 1631 | WARNING | Line exceeds 80 characters; contains 87 characters 1635 | ERROR | Missing parameter comment 1637 | ERROR | Type hint "array" missing for $links 1660 | WARNING | Line exceeds 80 characters; contains 97 characters 1664 | ERROR | Missing parameter comment 1666 | ERROR | Type hint "array" missing for $links 1699 | ERROR | Type hint "array" missing for $links 1700 | ERROR | The array declaration extends to column 246 (the limit is 80). The array content should be split up over multiple lines 1709 | WARNING | Line exceeds 80 characters; contains 83 characters 1719 | ERROR | Type hint "array" missing for $links 1720 | ERROR | The array declaration extends to column 249 (the limit is 80). The array content should be split up over multiple lines 1729 | WARNING | Line exceeds 80 characters; contains 93 characters 1740 | ERROR | Type hint "array" missing for $links 1741 | ERROR | The array declaration extends to column 254 (the limit is 80). The array content should be split up over multiple lines 1846 | ERROR | Description for the @return value is missing 1909 | WARNING | Line exceeds 80 characters; contains 176 characters 2041 | WARNING | '@todo' should match the format '@todo Fix problem X here.' 2099 | WARNING | Line exceeds 80 characters; contains 99 characters 2192 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines 2317 | WARNING | '@todo' should match the format '@todo Fix problem X here.' 2614 | ERROR | The array declaration extends to column 135 (the limit is 80). The array content should be split up over multiple lines 2624 | ERROR | Description for the @return value is missing 2631 | WARNING | Line exceeds 80 characters; contains 81 characters 2754 | WARNING | Line exceeds 80 characters; contains 83 characters ------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/linkchecker.drush.inc ----------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------- 23 | ERROR | Comment indentation error, expected only 1 spaces ----------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/linkchecker.info ------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------ 5 | ERROR | It's only necessary to declare files[] if they declare a class or interface. ------------------------------------------------------------------------------------------ FILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/CHANGELOG.txt ---------------------------------------------------------------------- FOUND 0 ERRORS AND 41 WARNINGS AFFECTING 41 LINES ---------------------------------------------------------------------- 4 | WARNING | Line exceeds 80 characters; contains 94 characters 9 | WARNING | Line exceeds 80 characters; contains 84 characters 10 | WARNING | Line exceeds 80 characters; contains 94 characters 17 | WARNING | Line exceeds 80 characters; contains 89 characters 18 | WARNING | Line exceeds 80 characters; contains 90 characters 19 | WARNING | Line exceeds 80 characters; contains 116 characters 20 | WARNING | Line exceeds 80 characters; contains 112 characters 23 | WARNING | Line exceeds 80 characters; contains 125 characters 25 | WARNING | Line exceeds 80 characters; contains 86 characters 39 | WARNING | Line exceeds 80 characters; contains 103 characters 40 | WARNING | Line exceeds 80 characters; contains 91 characters 43 | WARNING | Line exceeds 80 characters; contains 135 characters 51 | WARNING | Line exceeds 80 characters; contains 83 characters 57 | WARNING | Line exceeds 80 characters; contains 86 characters 59 | WARNING | Line exceeds 80 characters; contains 152 characters 68 | WARNING | Line exceeds 80 characters; contains 98 characters 70 | WARNING | Line exceeds 80 characters; contains 97 characters 96 | WARNING | Line exceeds 80 characters; contains 125 characters 99 | WARNING | Line exceeds 80 characters; contains 100 characters 114 | WARNING | Line exceeds 80 characters; contains 84 characters 154 | WARNING | Line exceeds 80 characters; contains 111 characters 159 | WARNING | Line exceeds 80 characters; contains 89 characters 162 | WARNING | Line exceeds 80 characters; contains 156 characters 166 | WARNING | Line exceeds 80 characters; contains 87 characters 167 | WARNING | Line exceeds 80 characters; contains 94 characters 170 | WARNING | Line exceeds 80 characters; contains 88 characters 174 | WARNING | Line exceeds 80 characters; contains 95 characters 183 | WARNING | Line exceeds 80 characters; contains 85 characters 187 | WARNING | Line exceeds 80 characters; contains 89 characters 191 | WARNING | Line exceeds 80 characters; contains 139 characters 199 | WARNING | Line exceeds 80 characters; contains 141 characters 223 | WARNING | Line exceeds 80 characters; contains 106 characters 224 | WARNING | Line exceeds 80 characters; contains 105 characters 225 | WARNING | Line exceeds 80 characters; contains 137 characters 228 | WARNING | Line exceeds 80 characters; contains 102 characters 255 | WARNING | Line exceeds 80 characters; contains 164 characters 266 | WARNING | Line exceeds 80 characters; contains 108 characters 277 | WARNING | Line exceeds 80 characters; contains 96 characters 279 | WARNING | Line exceeds 80 characters; contains 110 characters 287 | WARNING | Line exceeds 80 characters; contains 111 characters 288 | WARNING | Line exceeds 80 characters; contains 87 characters ---------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/README.txt ---------------------------------------------------------------------- FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES ---------------------------------------------------------------------- 9 | WARNING | Line exceeds 80 characters; contains 94 characters 41 | WARNING | Line exceeds 80 characters; contains 82 characters 43 | WARNING | Line exceeds 80 characters; contains 93 characters 46 | WARNING | Line exceeds 80 characters; contains 97 characters 47 | WARNING | Line exceeds 80 characters; contains 87 characters 48 | WARNING | Line exceeds 80 characters; contains 84 characters 49 | WARNING | Line exceeds 80 characters; contains 100 characters 50 | WARNING | Line exceeds 80 characters; contains 94 characters ---------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/linkchecker.redirect.inc -------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------- 20 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 21 | ERROR | The array declaration extends to column 107 (the limit is 80). The array content should be split up over multiple lines 39 | ERROR | Type hint "array" missing for $urls -------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/linkchecker.install --------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------------- 361 | ERROR | Comment indentation error, expected only 3 spaces 473 | ERROR | The array declaration extends to column 222 (the limit is 80). The array content should be split up over multiple lines 496 | ERROR | The array declaration extends to column 222 (the limit is 80). The array content should be split up over multiple lines --------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/linkchecker.test ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 26 ERRORS AND 7 WARNINGS AFFECTING 33 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 8 | ERROR | Doc comment is empty 13 | ERROR | Doc comment is empty 24 | ERROR | Doc comment is empty 44 | ERROR | Doc comment is empty 219 | ERROR | The array declaration extends to column 116 (the limit is 80). The array content should be split up over multiple lines 254 | ERROR | The array declaration extends to column 187 (the limit is 80). The array content should be split up over multiple lines 266 | ERROR | The array declaration extends to column 266 (the limit is 80). The array content should be split up over multiple lines 275 | ERROR | The array declaration extends to column 115 (the limit is 80). The array content should be split up over multiple lines 278 | WARNING | Line exceeds 80 characters; contains 193 characters 298 | ERROR | The array declaration extends to column 126 (the limit is 80). The array content should be split up over multiple lines 305 | ERROR | The array declaration extends to column 105 (the limit is 80). The array content should be split up over multiple lines 310 | ERROR | The array declaration extends to column 187 (the limit is 80). The array content should be split up over multiple lines 320 | ERROR | The array declaration extends to column 266 (the limit is 80). The array content should be split up over multiple lines 402 | ERROR | Doc comment is empty 407 | ERROR | Doc comment is empty 418 | ERROR | Doc comment is empty 450 | ERROR | Doc comment is empty 495 | ERROR | The array declaration extends to column 116 (the limit is 80). The array content should be split up over multiple lines 514 | ERROR | The array declaration extends to column 248 (the limit is 80). The array content should be split up over multiple lines 521 | ERROR | The array declaration extends to column 248 (the limit is 80). The array content should be split up over multiple lines 524 | ERROR | Doc comment is empty 538 | WARNING | Line exceeds 80 characters; contains 98 characters 546 | WARNING | Line exceeds 80 characters; contains 86 characters 550 | WARNING | Line exceeds 80 characters; contains 90 characters 567 | ERROR | The array declaration extends to column 248 (the limit is 80). The array content should be split up over multiple lines 574 | ERROR | The array declaration extends to column 248 (the limit is 80). The array content should be split up over multiple lines 577 | ERROR | Parameter $fail_count is not described in comment 620 | ERROR | Doc comment is empty 631 | ERROR | Doc comment is empty 638 | ERROR | Doc comment is empty 645 | WARNING | Line exceeds 80 characters; contains 82 characters 680 | WARNING | Line exceeds 80 characters; contains 86 characters 682 | WARNING | Line exceeds 80 characters; contains 87 characters ----------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/linkchecker.batch.inc --------------------------------------------------------------------------------------------------------------------------------------- FOUND 16 ERRORS AFFECTING 16 LINES --------------------------------------------------------------------------------------------------------------------------------------- 13 | ERROR | The array declaration extends to column 160 (the limit is 80). The array content should be split up over multiple lines 52 | ERROR | Type hint "array" missing for $operations 67 | ERROR | The array declaration extends to column 259 (the limit is 80). The array content should be split up over multiple lines 71 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines 106 | ERROR | Type hint "array" missing for $operations 125 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines 160 | ERROR | Type hint "array" missing for $operations 185 | ERROR | The array declaration extends to column 82 (the limit is 80). The array content should be split up over multiple lines 206 | ERROR | Type hint "array" missing for $context 226 | ERROR | Type hint "array" missing for $operations 251 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines 272 | ERROR | Type hint "array" missing for $context 291 | ERROR | Type hint "array" missing for $operations 316 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines 337 | ERROR | Type hint "array" missing for $context 357 | ERROR | Type hint "array" missing for $operations --------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/tesboss/_PROJECTS/drupal/linkchecker/modules/linkchecker_bean/linkchecker_bean.module ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 6 ERRORS AND 7 WARNINGS AFFECTING 13 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 9 | WARNING | Doc comment indicates hook_form_alter() but function signature is "linkchecker_bean_form_linkchecker_admin_settings_form_alter" instead of | | "linkchecker_bean_form_alter". Did you mean hook_form_FORM_ID_alter()? 21 | WARNING | All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with | | "linkchecker_bean" but found "linkchecker_scan_beans" 80 | ERROR | The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines 204 | WARNING | Line exceeds 80 characters; contains 81 characters 208 | WARNING | Line exceeds 80 characters; contains 84 characters 212 | WARNING | Line exceeds 80 characters; contains 82 characters 256 | WARNING | Line exceeds 80 characters; contains 81 characters 284 | ERROR | The array declaration extends to column 246 (the limit is 80). The array content should be split up over multiple lines 316 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines 339 | ERROR | Type hint "array" missing for $operations 350 | WARNING | Line exceeds 80 characters; contains 85 characters 403 | ERROR | The array declaration extends to column 184 (the limit is 80). The array content should be split up over multiple lines 406 | ERROR | The array declaration extends to column 187 (the limit is 80). The array content should be split up over multiple lines ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- Time: 2.16 secs; Memory: 30MB
- 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
- last update
12 months ago 7 pass - First commit to issue fork.
- last update
12 months ago 7 pass - 🇮🇳India nitin_lama India
Remaining issues:
FILE: /home/system/Documents/contribution/linkchecker-3335579/linkchecker.test ------------------------------------------------------------------------------ FOUND 13 ERRORS AND 7 WARNINGS AFFECTING 20 LINES ------------------------------------------------------------------------------ 8 | ERROR | Doc comment is empty 13 | ERROR | Doc comment is empty 24 | ERROR | Doc comment is empty 44 | ERROR | Doc comment is empty 297 | WARNING | Line exceeds 80 characters; contains 193 characters 445 | ERROR | Doc comment is empty 450 | ERROR | Doc comment is empty 461 | ERROR | Doc comment is empty 493 | ERROR | Doc comment is empty 576 | ERROR | Doc comment is empty 590 | WARNING | Line exceeds 80 characters; contains 98 characters 598 | WARNING | Line exceeds 80 characters; contains 86 characters 602 | WARNING | Line exceeds 80 characters; contains 90 characters 635 | ERROR | Parameter $fail_count is not described in comment 678 | ERROR | Doc comment is empty 689 | ERROR | Doc comment is empty 696 | ERROR | Doc comment is empty 703 | WARNING | Line exceeds 80 characters; contains 82 characters 738 | WARNING | Line exceeds 80 characters; contains 86 characters 740 | WARNING | Line exceeds 80 characters; contains 87 characters ------------------------------------------------------------------------------ FILE: /home/system/Documents/contribution/linkchecker-3335579/linkchecker.module ---------------------------------------------------------------------------------------------------------------------- FOUND 21 ERRORS AND 28 WARNINGS AFFECTING 49 LINES ---------------------------------------------------------------------------------------------------------------------- 12 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 18 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 25 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 45 | WARNING | '@todo' should match the format '@todo Fix problem X here.' 54 | WARNING | Line exceeds 80 characters; contains 102 characters 155 | ERROR | Missing parameter type 158 | ERROR | Missing parameter type 164 | ERROR | Missing parameter type 168 | ERROR | Missing parameter type 179 | ERROR | Missing parameter type 197 | ERROR | Description for the @return value is missing 232 | ERROR | Description for the @return value is missing 240 | WARNING | Line exceeds 80 characters; contains 90 characters 359 | WARNING | Line exceeds 80 characters; contains 89 characters 410 | WARNING | Line exceeds 80 characters; contains 87 characters 567 | WARNING | Line exceeds 80 characters; contains 89 characters 924 | WARNING | Line exceeds 80 characters; contains 195 characters 937 | WARNING | Line exceeds 80 characters; contains 195 characters 1408 | WARNING | Line exceeds 80 characters; contains 81 characters 1412 | WARNING | Line exceeds 80 characters; contains 84 characters 1416 | WARNING | Line exceeds 80 characters; contains 82 characters 1503 | WARNING | Line exceeds 80 characters; contains 81 characters 1507 | WARNING | Line exceeds 80 characters; contains 84 characters 1511 | WARNING | Line exceeds 80 characters; contains 82 characters 1607 | WARNING | Line exceeds 80 characters; contains 81 characters 1611 | WARNING | Line exceeds 80 characters; contains 84 characters 1615 | WARNING | Line exceeds 80 characters; contains 82 characters 1674 | WARNING | Line exceeds 80 characters; contains 81 characters 1678 | ERROR | Missing parameter comment 1680 | ERROR | Type hint "array" missing for $links 1703 | WARNING | Line exceeds 80 characters; contains 87 characters 1707 | ERROR | Missing parameter comment 1709 | ERROR | Type hint "array" missing for $links 1732 | WARNING | Line exceeds 80 characters; contains 97 characters 1736 | ERROR | Missing parameter comment 1738 | ERROR | Type hint "array" missing for $links 1771 | ERROR | Type hint "array" missing for $links 1786 | WARNING | Line exceeds 80 characters; contains 83 characters 1796 | ERROR | Type hint "array" missing for $links 1811 | WARNING | Line exceeds 80 characters; contains 93 characters 1822 | ERROR | Type hint "array" missing for $links 1933 | ERROR | Description for the @return value is missing 1996 | WARNING | Line exceeds 80 characters; contains 176 characters 2128 | WARNING | '@todo' should match the format '@todo Fix problem X here.' 2186 | WARNING | Line exceeds 80 characters; contains 99 characters 2412 | WARNING | '@todo' should match the format '@todo Fix problem X here.' 2723 | ERROR | Description for the @return value is missing 2730 | WARNING | Line exceeds 80 characters; contains 81 characters 2853 | WARNING | Line exceeds 80 characters; contains 83 characters ---------------------------------------------------------------------------------------------------------------------- FILE: /home/system/Documents/contribution/linkchecker-3335579/CHANGELOG.txt --------------------------------------------------------------------------- FOUND 0 ERRORS AND 41 WARNINGS AFFECTING 41 LINES --------------------------------------------------------------------------- 4 | WARNING | Line exceeds 80 characters; contains 94 characters 9 | WARNING | Line exceeds 80 characters; contains 84 characters 10 | WARNING | Line exceeds 80 characters; contains 94 characters 17 | WARNING | Line exceeds 80 characters; contains 89 characters 18 | WARNING | Line exceeds 80 characters; contains 90 characters 19 | WARNING | Line exceeds 80 characters; contains 116 characters 20 | WARNING | Line exceeds 80 characters; contains 112 characters 23 | WARNING | Line exceeds 80 characters; contains 125 characters 25 | WARNING | Line exceeds 80 characters; contains 86 characters 39 | WARNING | Line exceeds 80 characters; contains 103 characters 40 | WARNING | Line exceeds 80 characters; contains 91 characters 43 | WARNING | Line exceeds 80 characters; contains 135 characters 51 | WARNING | Line exceeds 80 characters; contains 83 characters 57 | WARNING | Line exceeds 80 characters; contains 86 characters 59 | WARNING | Line exceeds 80 characters; contains 152 characters 68 | WARNING | Line exceeds 80 characters; contains 98 characters 70 | WARNING | Line exceeds 80 characters; contains 97 characters 96 | WARNING | Line exceeds 80 characters; contains 125 characters 99 | WARNING | Line exceeds 80 characters; contains 100 characters 114 | WARNING | Line exceeds 80 characters; contains 84 characters 154 | WARNING | Line exceeds 80 characters; contains 111 characters 159 | WARNING | Line exceeds 80 characters; contains 89 characters 162 | WARNING | Line exceeds 80 characters; contains 156 characters 166 | WARNING | Line exceeds 80 characters; contains 87 characters 167 | WARNING | Line exceeds 80 characters; contains 94 characters 170 | WARNING | Line exceeds 80 characters; contains 88 characters 174 | WARNING | Line exceeds 80 characters; contains 95 characters 183 | WARNING | Line exceeds 80 characters; contains 85 characters 187 | WARNING | Line exceeds 80 characters; contains 89 characters 191 | WARNING | Line exceeds 80 characters; contains 139 characters 199 | WARNING | Line exceeds 80 characters; contains 141 characters 223 | WARNING | Line exceeds 80 characters; contains 106 characters 224 | WARNING | Line exceeds 80 characters; contains 105 characters 225 | WARNING | Line exceeds 80 characters; contains 137 characters 228 | WARNING | Line exceeds 80 characters; contains 102 characters 255 | WARNING | Line exceeds 80 characters; contains 164 characters 266 | WARNING | Line exceeds 80 characters; contains 108 characters 277 | WARNING | Line exceeds 80 characters; contains 96 characters 279 | WARNING | Line exceeds 80 characters; contains 110 characters 287 | WARNING | Line exceeds 80 characters; contains 111 characters 288 | WARNING | Line exceeds 80 characters; contains 87 characters --------------------------------------------------------------------------- FILE: /home/system/Documents/contribution/linkchecker-3335579/linkchecker.pages.inc ----------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES ----------------------------------------------------------------------------------- 118 | ERROR | Type hint "SelectQueryInterface" missing for $query 207 | ERROR | No key specified for array entry; first entry specifies key ----------------------------------------------------------------------------------- FILE: /home/system/Documents/contribution/linkchecker-3335579/modules/linkchecker_bean/linkchecker_bean.module -------------------------------------------------------------------------------------------------------------- FOUND 27 ERRORS AND 3 WARNINGS AFFECTING 28 LINES -------------------------------------------------------------------------------------------------------------- 205 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 206 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 207 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 208 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 209 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 210 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 211 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters 211 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 212 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 213 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 214 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 215 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 216 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 217 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 218 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 219 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 220 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 222 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 223 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 224 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 225 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 226 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 227 | ERROR | [x] Line indented incorrectly; expected 8 spaces, found 6 228 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 4 229 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 230 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 230 | ERROR | [x] Closing brace indented incorrectly; expected 2 spaces, found 0 259 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 351 | ERROR | [ ] Type hint "array" missing for $operations 362 | WARNING | [ ] Line exceeds 80 characters; contains 85 characters -------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 26 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------- FILE: /home/system/Documents/contribution/linkchecker-3335579/README.txt ------------------------------------------------------------------------ FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES ------------------------------------------------------------------------ 9 | WARNING | Line exceeds 80 characters; contains 94 characters 41 | WARNING | Line exceeds 80 characters; contains 82 characters 43 | WARNING | Line exceeds 80 characters; contains 93 characters 46 | WARNING | Line exceeds 80 characters; contains 97 characters 47 | WARNING | Line exceeds 80 characters; contains 87 characters 48 | WARNING | Line exceeds 80 characters; contains 84 characters 49 | WARNING | Line exceeds 80 characters; contains 100 characters 50 | WARNING | Line exceeds 80 characters; contains 94 characters ------------------------------------------------------------------------ FILE: /home/system/Documents/contribution/linkchecker-3335579/linkchecker.redirect.inc -------------------------------------------------------------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------------------------------------------------------------- 20 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 21 | ERROR | The array declaration extends to column 107 (the limit is 80). The array content should be split up over multiple lines 39 | ERROR | Type hint "array" missing for $urls -------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/system/Documents/contribution/linkchecker-3335579/linkchecker.info ------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------ 5 | ERROR | It's only necessary to declare files[] if they declare a class or interface. ------------------------------------------------------------------------------------------ FILE: /home/system/Documents/contribution/linkchecker-3335579/linkchecker.module ------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------ 1069 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 1169 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 1169 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 1169 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible ------------------------------------------------------------------------------------------------------------ FILE: /home/system/Documents/contribution/linkchecker-3335579/modules/linkchecker_bean/linkchecker_bean.module ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 9 | WARNING | Doc comment indicates hook_form_alter() but function signature is "linkchecker_bean_form_linkchecker_admin_settings_form_alter" instead of "linkchecker_bean_form_alter". Did you mean | | hook_form_FORM_ID_alter()? 21 | WARNING | All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "linkchecker_bean" but found | | "linkchecker_scan_beans" ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/system/Documents/contribution/linkchecker-3335579/linkchecker.admin.inc ----------------------------------------------------------------------------------- FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES ----------------------------------------------------------------------------------- 155 | WARNING | #options values usually have to run through t() for translation 156 | WARNING | #options values usually have to run through t() for translation 157 | WARNING | #options values usually have to run through t() for translation 158 | WARNING | #options values usually have to run through t() for translation 159 | WARNING | #options values usually have to run through t() for translation -----------------------------------------------------------------------------------
- Assigned to nitin_lama
- 🇮🇳India nitin_lama India
Command used:
phpcs --standard=Drupal --extensions='php,module,inc,install,test,profile,theme,info,txt,md' phpcs --standard=DrupalPractice --extensions='php,module,inc,install,test,profile,theme,info,txt,md'
- Issue was unassigned.
- 🇦🇺Australia VladimirAus Brisbane, Australia
VladimirAus → changed the visibility of the branch 3335579-d7-coding-standard to hidden.
- 🇦🇺Australia VladimirAus Brisbane, Australia
VladimirAus → changed the visibility of the branch 3335579-d7-coding-standard to hidden.
- last update
12 months ago 7 pass - 🇦🇺Australia VladimirAus Brisbane, Australia
VladimirAus → changed the visibility of the branch 3335579-d7-coding-standard to active.
- last update
12 months ago 7 pass - 🇮🇳India zkhan.aamir
Hi,
MR #14 applied successfully.
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib/linkchecker (7.x-1.x) $ curl https://git.drupalcode.org/project/linkchecker/-/merge_requests/38.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 72666 0 72666 0 0 145k 0 --:--:-- --:--:-- --:--:-- 146k patching file .gitlab-ci.yml patching file linkchecker.admin.inc patching file linkchecker.batch.inc patching file linkchecker.drush.inc patching file linkchecker.install patching file linkchecker.module patching file linkchecker.pages.inc patching file linkchecker.test patching file modules/linkchecker_bean/linkchecker_bean.module
Still errors and warning remaining.
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib $ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,js,yml linkchecker/ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\linkchecker\CHANGELOG.txt ------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 41 WARNINGS AFFECTING 41 LINES ------------------------------------------------------------------------------------------ 4 | WARNING | Line exceeds 80 characters; contains 94 characters 9 | WARNING | Line exceeds 80 characters; contains 84 characters 10 | WARNING | Line exceeds 80 characters; contains 94 characters 17 | WARNING | Line exceeds 80 characters; contains 89 characters 18 | WARNING | Line exceeds 80 characters; contains 90 characters 19 | WARNING | Line exceeds 80 characters; contains 116 characters 20 | WARNING | Line exceeds 80 characters; contains 112 characters 23 | WARNING | Line exceeds 80 characters; contains 125 characters 25 | WARNING | Line exceeds 80 characters; contains 86 characters 39 | WARNING | Line exceeds 80 characters; contains 103 characters 40 | WARNING | Line exceeds 80 characters; contains 91 characters 43 | WARNING | Line exceeds 80 characters; contains 135 characters 51 | WARNING | Line exceeds 80 characters; contains 83 characters 57 | WARNING | Line exceeds 80 characters; contains 86 characters 59 | WARNING | Line exceeds 80 characters; contains 152 characters 68 | WARNING | Line exceeds 80 characters; contains 98 characters 70 | WARNING | Line exceeds 80 characters; contains 97 characters 96 | WARNING | Line exceeds 80 characters; contains 125 characters 99 | WARNING | Line exceeds 80 characters; contains 100 characters 114 | WARNING | Line exceeds 80 characters; contains 84 characters 154 | WARNING | Line exceeds 80 characters; contains 111 characters 159 | WARNING | Line exceeds 80 characters; contains 89 characters 162 | WARNING | Line exceeds 80 characters; contains 156 characters 166 | WARNING | Line exceeds 80 characters; contains 87 characters 167 | WARNING | Line exceeds 80 characters; contains 94 characters 170 | WARNING | Line exceeds 80 characters; contains 88 characters 174 | WARNING | Line exceeds 80 characters; contains 95 characters 183 | WARNING | Line exceeds 80 characters; contains 85 characters 187 | WARNING | Line exceeds 80 characters; contains 89 characters 191 | WARNING | Line exceeds 80 characters; contains 139 characters 199 | WARNING | Line exceeds 80 characters; contains 141 characters 223 | WARNING | Line exceeds 80 characters; contains 106 characters 224 | WARNING | Line exceeds 80 characters; contains 105 characters 225 | WARNING | Line exceeds 80 characters; contains 137 characters 228 | WARNING | Line exceeds 80 characters; contains 102 characters 255 | WARNING | Line exceeds 80 characters; contains 164 characters 266 | WARNING | Line exceeds 80 characters; contains 108 characters 277 | WARNING | Line exceeds 80 characters; contains 96 characters 279 | WARNING | Line exceeds 80 characters; contains 110 characters 287 | WARNING | Line exceeds 80 characters; contains 111 characters 288 | WARNING | Line exceeds 80 characters; contains 87 characters ------------------------------------------------------------------------------------------ FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\linkchecker\linkchecker.admin.inc -------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES -------------------------------------------------------------------------------------------------- 155 | WARNING | #options values usually have to run through t() for translation 156 | WARNING | #options values usually have to run through t() for translation 157 | WARNING | #options values usually have to run through t() for translation 158 | WARNING | #options values usually have to run through t() for translation 159 | WARNING | #options values usually have to run through t() for translation -------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\linkchecker\linkchecker.info --------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------- 5 | ERROR | It's only necessary to declare files[] if they declare a class or interface. --------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\linkchecker\linkchecker.module ---------------------------------------------------------------------------------------------------------------------- FOUND 15 ERRORS AND 32 WARNINGS AFFECTING 45 LINES ---------------------------------------------------------------------------------------------------------------------- 12 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 18 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 25 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph 45 | WARNING | '@todo' should match the format '@todo Fix problem X here.' 54 | WARNING | Line exceeds 80 characters; contains 102 characters 155 | ERROR | Missing parameter type 158 | ERROR | Missing parameter type 164 | ERROR | Missing parameter type 168 | ERROR | Missing parameter type 179 | ERROR | Missing parameter type 197 | ERROR | Description for the @return value is missing 232 | ERROR | Description for the @return value is missing 240 | WARNING | Line exceeds 80 characters; contains 90 characters 359 | WARNING | Line exceeds 80 characters; contains 89 characters 410 | WARNING | Line exceeds 80 characters; contains 87 characters 567 | WARNING | Line exceeds 80 characters; contains 89 characters 924 | WARNING | Line exceeds 80 characters; contains 195 characters 937 | WARNING | Line exceeds 80 characters; contains 195 characters 1069 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 1169 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 1169 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 1169 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible 1408 | WARNING | Line exceeds 80 characters; contains 81 characters 1412 | WARNING | Line exceeds 80 characters; contains 84 characters 1416 | WARNING | Line exceeds 80 characters; contains 82 characters 1503 | WARNING | Line exceeds 80 characters; contains 81 characters 1507 | WARNING | Line exceeds 80 characters; contains 84 characters 1511 | WARNING | Line exceeds 80 characters; contains 82 characters 1607 | WARNING | Line exceeds 80 characters; contains 81 characters 1611 | WARNING | Line exceeds 80 characters; contains 84 characters 1615 | WARNING | Line exceeds 80 characters; contains 82 characters 1674 | WARNING | Line exceeds 80 characters; contains 81 characters 1678 | ERROR | Missing parameter comment 1703 | WARNING | Line exceeds 80 characters; contains 87 characters 1707 | ERROR | Missing parameter comment 1732 | WARNING | Line exceeds 80 characters; contains 97 characters 1736 | ERROR | Missing parameter comment 1786 | WARNING | Line exceeds 80 characters; contains 83 characters 1811 | WARNING | Line exceeds 80 characters; contains 93 characters 1933 | ERROR | Description for the @return value is missing 1996 | WARNING | Line exceeds 80 characters; contains 176 characters 2128 | WARNING | '@todo' should match the format '@todo Fix problem X here.' 2186 | WARNING | Line exceeds 80 characters; contains 99 characters 2412 | WARNING | '@todo' should match the format '@todo Fix problem X here.' 2723 | ERROR | Description for the @return value is missing 2730 | WARNING | Line exceeds 80 characters; contains 81 characters 2853 | WARNING | Line exceeds 80 characters; contains 83 characters ---------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\linkchecker\linkchecker.pages.inc -------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------- 207 | ERROR | No key specified for array entry; first entry specifies key -------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\linkchecker\linkchecker.redirect.inc -------------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------------------------------------------------------------- 20 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines 21 | ERROR | The array declaration extends to column 107 (the limit is 80). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\linkchecker\linkchecker.test --------------------------------------------------------------------------------------------- FOUND 13 ERRORS AND 7 WARNINGS AFFECTING 20 LINES --------------------------------------------------------------------------------------------- 8 | ERROR | Doc comment is empty 13 | ERROR | Doc comment is empty 24 | ERROR | Doc comment is empty 44 | ERROR | Doc comment is empty 297 | WARNING | Line exceeds 80 characters; contains 193 characters 445 | ERROR | Doc comment is empty 450 | ERROR | Doc comment is empty 461 | ERROR | Doc comment is empty 493 | ERROR | Doc comment is empty 576 | ERROR | Doc comment is empty 590 | WARNING | Line exceeds 80 characters; contains 98 characters 598 | WARNING | Line exceeds 80 characters; contains 86 characters 602 | WARNING | Line exceeds 80 characters; contains 90 characters 635 | ERROR | Parameter $fail_count is not described in comment 678 | ERROR | Doc comment is empty 689 | ERROR | Doc comment is empty 696 | ERROR | Doc comment is empty 703 | WARNING | Line exceeds 80 characters; contains 82 characters 738 | WARNING | Line exceeds 80 characters; contains 86 characters 740 | WARNING | Line exceeds 80 characters; contains 87 characters --------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\linkchecker\modules\linkchecker_bean\linkchecker_bean.module ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 9 | WARNING | Doc comment indicates hook_form_alter() but function signature is "linkchecker_bean_form_linkchecker_admin_settings_form_alter" instead of | | "linkchecker_bean_form_alter". Did you mean hook_form_FORM_ID_alter()? 21 | WARNING | All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "linkchecker_bean" | | but found "linkchecker_scan_beans" 207 | WARNING | Line exceeds 80 characters; contains 81 characters 211 | WARNING | Line exceeds 80 characters; contains 84 characters 215 | WARNING | Line exceeds 80 characters; contains 82 characters ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: C:\Users\Admin\Desktop\projects\drupal\web\modules\contrib\linkchecker\README.txt --------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES --------------------------------------------------------------------------------------- 9 | WARNING | Line exceeds 80 characters; contains 94 characters 41 | WARNING | Line exceeds 80 characters; contains 82 characters 43 | WARNING | Line exceeds 80 characters; contains 93 characters 46 | WARNING | Line exceeds 80 characters; contains 97 characters 47 | WARNING | Line exceeds 80 characters; contains 87 characters 48 | WARNING | Line exceeds 80 characters; contains 84 characters 49 | WARNING | Line exceeds 80 characters; contains 100 characters 50 | WARNING | Line exceeds 80 characters; contains 94 characters --------------------------------------------------------------------------------------- Time: 1.11 secs; Memory: 32MB
- First commit to issue fork.
- last update
10 months ago 7 pass - 🇮🇳India Anjali Mehta
Anjali Mehta → made their first commit to this issue’s fork.
- last update
10 months ago Build Successful - First commit to issue fork.
- last update
10 months ago Build Successful - Status changed to Needs review
9 months ago 5:30am 12 February 2024 - 🇮🇳India zkhan.aamir
Hi,
MR #19 applied successfully.
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib/linkchecker (7.x-1.x) $ curl https://git.drupalcode.org/project/linkchecker/-/merge_requests/38.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 114k 0 114k 0 0 268k 0 --:--:-- --:--:-- --:--:-- 269k patching file .gitlab-ci.yml patching file CHANGELOG.txt patching file README.txt patching file linkchecker-node-form.js patching file linkchecker.admin.inc patching file linkchecker.batch.inc patching file linkchecker.drush.inc patching file linkchecker.info patching file linkchecker.install patching file linkchecker.module patching file linkchecker.pages.inc patching file linkchecker.redirect.inc patching file linkchecker.test patching file modules/linkchecker_bean/linkchecker_bean.module
All the issues are resolved
Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,js,yml linkchecker/ Admin@DESKTOP-252TO6V MINGW64 ~/Desktop/projects/drupal/web/modules/contrib $
- Status changed to Needs work
3 months ago 7:45am 15 August 2024 - 🇵🇭Philippines cleavinjosh
Hi @Preethy_ray,
I applied MR!38, I encountered one hunk failed.
This is the issue remaining after I run
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml
.➜ linkchecker git:(7.x-1.x) curl https://git.drupalcode.org/project/linkchecker/-/merge_requests/38.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 114k 0 114k 0 0 241k 0 --:--:-- --:--:-- --:--:-- 241k patching file .gitlab-ci.yml patching file CHANGELOG.txt patching file README.txt patching file linkchecker-node-form.js patching file linkchecker.admin.inc patching file linkchecker.batch.inc patching file linkchecker.drush.inc patching file linkchecker.info patching file linkchecker.install patching file linkchecker.module Hunk #28 FAILED at 1213. 1 out of 58 hunks FAILED -- saving rejects to file linkchecker.module.rej patching file linkchecker.pages.inc patching file linkchecker.redirect.inc patching file linkchecker.test patching file modules/linkchecker_bean/linkchecker_bean.module ➜ linkchecker git:(7.x-1.x) ✗ .. ➜ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml linkchecker FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/linkchecker/linkchecker.module --------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES --------------------------------------------------------------------------------------------------- 1211 | ERROR | [x] Use null coalesce operator instead of ternary operator. 1214 | ERROR | [x] Expected 1 blank line after function; 2 found --------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------- Time: 1.36 secs; Memory: 28MB ➜ contrib
Thank you.
- Merge request !79Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix → (Open) created by apaderno
- 🇮🇹Italy apaderno Brescia, 🇮🇹
A Drupal 7 module cannot use the null coalescent operator, since it needs to be compatible with PHP 5.6.
- Status changed to RTBC
3 months ago 3:15pm 15 August 2024 - 🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → changed the visibility of the branch 3335579-gitlab-ci-reports to hidden.